Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-8918

dev-support/test-patch.sh is parsing modified files wrong

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.2-alpha
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      dev-support/test-patch.sh is parsing modified files wrong from the patch.

      In test-patch.sh script, for running findbugs command, it is trying to find out the modified files by doing the following command

      $GREP '^+++\|^---' $PATCH_DIR/patch | cut -c '5-' | $GREP -v /dev/null | sort | uniq > $TMP
      

      A patch file can have an entry with xml comments removed, which would match that to be a filename. If you look at the last line of the below text, it would match the filename to be '^M'

      -<?xml version="1.0"?>^M
      -<!--^M
      -   Licensed to the Apache Software Foundation (ASF) under one or more^M-   contributor license agreements.  See the NOTICE file distributed with^M
      -   this work for additional information regarding copyright ownership.^M
      -   The ASF licenses this file to You under the Apache License, Version 2.0^M-   (the "License"); you may not use this file except in compliance with^M
      -   the License.  You may obtain a copy of the License at^M
      -^M
      -       http://www.apache.org/licenses/LICENSE-2.0^M
      -^M
      -   Unless required by applicable law or agreed to in writing, software^M
      -   distributed under the License is distributed on an "AS IS" BASIS,^M
      -   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.^M
      -   See the License for the specific language governing permissions and^M
      -   limitations under the License.^M
      --->^M
      

        Activity

        Hide
        raja@cmbasics.com Raja Aluri added a comment -

        I am not sure, how jenkins is going to handle this change, this is changing the bootstrapping/patching code itself. I tested it on my local system, by moving it out of the source tree and calling the test-patch.sh from outside source tree.

        Show
        raja@cmbasics.com Raja Aluri added a comment - I am not sure, how jenkins is going to handle this change, this is changing the bootstrapping/patching code itself. I tested it on my local system, by moving it out of the source tree and calling the test-patch.sh from outside source tree.
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12548825/HADOOP-8918.trunk.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1616//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1616//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12548825/HADOOP-8918.trunk.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1616//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1616//console This message is automatically generated.
        Hide
        sureshms Suresh Srinivas added a comment -

        @Raja, good find.

        +1 for the patch.

        Show
        sureshms Suresh Srinivas added a comment - @Raja, good find. +1 for the patch.
        Hide
        sureshms Suresh Srinivas added a comment -

        I committed this patch to trunk. Since Jenkins does not run on branch-2, I am just leaving this change in trunk.

        Thank you Raja.

        Show
        sureshms Suresh Srinivas added a comment - I committed this patch to trunk. Since Jenkins does not run on branch-2, I am just leaving this change in trunk. Thank you Raja.
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2851 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2851/)
        HADOOP-8918. test-patch.sh is parsing modified files wrong. Contributed by Raja Aluri. (Revision 1397411)

        Result = SUCCESS
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397411
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2851 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2851/ ) HADOOP-8918 . test-patch.sh is parsing modified files wrong. Contributed by Raja Aluri. (Revision 1397411) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397411 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2913 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2913/)
        HADOOP-8918. test-patch.sh is parsing modified files wrong. Contributed by Raja Aluri. (Revision 1397411)

        Result = SUCCESS
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397411
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2913 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2913/ ) HADOOP-8918 . test-patch.sh is parsing modified files wrong. Contributed by Raja Aluri. (Revision 1397411) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397411 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2875 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2875/)
        HADOOP-8918. test-patch.sh is parsing modified files wrong. Contributed by Raja Aluri. (Revision 1397411)

        Result = FAILURE
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397411
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2875 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2875/ ) HADOOP-8918 . test-patch.sh is parsing modified files wrong. Contributed by Raja Aluri. (Revision 1397411) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397411 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1193 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1193/)
        HADOOP-8918. test-patch.sh is parsing modified files wrong. Contributed by Raja Aluri. (Revision 1397411)

        Result = SUCCESS
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397411
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1193 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1193/ ) HADOOP-8918 . test-patch.sh is parsing modified files wrong. Contributed by Raja Aluri. (Revision 1397411) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397411 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1224 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1224/)
        HADOOP-8918. test-patch.sh is parsing modified files wrong. Contributed by Raja Aluri. (Revision 1397411)

        Result = SUCCESS
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397411
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1224 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1224/ ) HADOOP-8918 . test-patch.sh is parsing modified files wrong. Contributed by Raja Aluri. (Revision 1397411) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397411 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

          People

          • Assignee:
            raja@cmbasics.com Raja Aluri
            Reporter:
            raja@cmbasics.com Raja Aluri
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development