Hadoop Common
  1. Hadoop Common
  2. HADOOP-8911

CRLF characters in source and text files

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1-win, 3.0.0
    • Fix Version/s: 1-win, 2.0.3-alpha
    • Component/s: build
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Source code in hadoop-common repo has a bunch of files that have CRLF endings.
      With more development happening on windows there is a higher chance of more CRLF files getting into the source tree.
      I would like to avoid that by creating .gitattributes file which prevents sources from having CRLF entries in text files.
      But before adding the .gitattributes file we need to normalize the existing tree, so that people when they sync after .giattributes change wont end up with a bunch of modified files in their workspace.
      I am adding a couple of links here to give more primer on what exactly is the issue and how we are trying to fix it.

      1. http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in
      2. http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git

      I will submit a separate bug and patch for .gitattributes

      1. HADOOP-8911.trunk.patch
        649 kB
        Suresh Srinivas
      2. HADOOP-8911.trunk.patch
        649 kB
        Raja Aluri
      3. HADOOP-8911.branch-2.patch
        648 kB
        Raja Aluri
      4. HADOOP-8911.branch-1-win.patch
        521 kB
        Raja Aluri

        Activity

        Raja Aluri created issue -
        Raja Aluri made changes -
        Field Original Value New Value
        Attachment HADOOP-8911.patch [ 12548598 ]
        Raja Aluri made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Target Version/s 1-win [ 12320361 ]
        Raja Aluri made changes -
        Attachment HADOOP-8911.branch-1-win.patch [ 12548641 ]
        Attachment HADOOP-8911.branch-2.patch [ 12548642 ]
        Attachment HADOOP-8911.trunk.patch [ 12548643 ]
        Raja Aluri made changes -
        Attachment HADOOP-8911.patch [ 12548598 ]
        Suresh Srinivas made changes -
        Fix Version/s 1-win [ 12320361 ]
        Affects Version/s 3.0.0 [ 12320357 ]
        Suresh Srinivas made changes -
        Attachment HADOOP-8911.trunk.patch [ 12548698 ]
        Suresh Srinivas made changes -
        Assignee Raja Aluri [ raja@cmbasics.com ]
        Suresh Srinivas made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 3.0.0 [ 12320357 ]
        Fix Version/s 1-win [ 12320361 ]
        Fix Version/s 2.0.3-alpha [ 12323273 ]
        Resolution Fixed [ 1 ]
        Suresh Srinivas made changes -
        Hadoop Flags Reviewed [ 10343 ]
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Allen Wittenauer made changes -
        Fix Version/s 3.0.0 [ 12320357 ]

          People

          • Assignee:
            Raja Aluri
            Reporter:
            Raja Aluri
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development