Hadoop Common
  1. Hadoop Common
  2. HADOOP-8861

FSDataOutputStream.sync should call flush() if the underlying wrapped stream is not Syncable

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.3
    • Fix Version/s: 1.2.0
    • Component/s: fs
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Currently FSDataOutputStream.sync is a no-op if the wrapped stream is not Syncable. Instead it should call flush() if the wrapped stream is not syncable.

      This behavior is already present in trunk, but branch-1 does not have this.

      1. HADOOP-8861-2.patch
        2 kB
        Amareshwari Sriramadasu
      2. HADOOP-8861.patch
        0.5 kB
        Amareshwari Sriramadasu

        Issue Links

          Activity

          Hide
          Amareshwari Sriramadasu added a comment -

          The trivial patch doing the fix

          Show
          Amareshwari Sriramadasu added a comment - The trivial patch doing the fix
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12546845/HADOOP-8861.patch
          against trunk revision .

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1537//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12546845/HADOOP-8861.patch against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1537//console This message is automatically generated.
          Hide
          Amareshwari Sriramadasu added a comment -

          Hadoop QA failed applying the patch as the patch is against branch-1. The issue does not exist in trunk, so fix is needed only for branch-1

          Show
          Amareshwari Sriramadasu added a comment - Hadoop QA failed applying the patch as the patch is against branch-1. The issue does not exist in trunk, so fix is needed only for branch-1
          Hide
          Amareshwari Sriramadasu added a comment -

          I ran tests on branch-1, both commit and smoke tests pass. After that, the build fails saying unable to delete userlog file. I see the same behavior in jenkins builds as well - https://builds.apache.org/job/Hadoop-1-Code-Coverage/159/consoleText

          Show
          Amareshwari Sriramadasu added a comment - I ran tests on branch-1, both commit and smoke tests pass. After that, the build fails saying unable to delete userlog file. I see the same behavior in jenkins builds as well - https://builds.apache.org/job/Hadoop-1-Code-Coverage/159/consoleText
          Hide
          Uma Maheswara Rao G added a comment -

          Thanks Amareshwari, for the patch.

          Change make sense to me. Do you mind having a small test like TestLocalFileSystem#testSyncable in trunk.
          Other than that, +1 for the patch.

          Show
          Uma Maheswara Rao G added a comment - Thanks Amareshwari, for the patch. Change make sense to me. Do you mind having a small test like TestLocalFileSystem#testSyncable in trunk. Other than that, +1 for the patch.
          Hide
          Matt Foley added a comment -

          Moved to 1.2.0 upon release of 1.1.0.

          Show
          Matt Foley added a comment - Moved to 1.2.0 upon release of 1.1.0.
          Hide
          Amareshwari Sriramadasu added a comment -

          Patch with test added in TestLocalFileSystem

          Show
          Amareshwari Sriramadasu added a comment - Patch with test added in TestLocalFileSystem
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12549677/HADOOP-8861-2.patch
          against trunk revision .

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1646//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12549677/HADOOP-8861-2.patch against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1646//console This message is automatically generated.
          Hide
          Amareshwari Sriramadasu added a comment -

          Hadoop QA failed to apply the patch since it is against branch-1. I ran the tests on box, the result is the same as earlier - both commit and smoke tests pass. After that, the build fails saying unable to delete userlog file.

          Also, the TestLocalFileSystem result:

          [junit] Running org.apache.hadoop.fs.TestLocalFileSystem
          [junit] Tests run: 7, Failures: 0, Errors: 0, Time elapsed: 12.196 sec

          Show
          Amareshwari Sriramadasu added a comment - Hadoop QA failed to apply the patch since it is against branch-1. I ran the tests on box, the result is the same as earlier - both commit and smoke tests pass. After that, the build fails saying unable to delete userlog file. Also, the TestLocalFileSystem result: [junit] Running org.apache.hadoop.fs.TestLocalFileSystem [junit] Tests run: 7, Failures: 0, Errors: 0, Time elapsed: 12.196 sec
          Hide
          Uma Maheswara Rao G added a comment -

          +1, I will commit it in some time. Thanks Amareshwari

          Show
          Uma Maheswara Rao G added a comment - +1, I will commit it in some time. Thanks Amareshwari
          Hide
          Uma Maheswara Rao G added a comment -

          I have just committed to branch-1.
          Committed revision 1400256.

          Show
          Uma Maheswara Rao G added a comment - I have just committed to branch-1. Committed revision 1400256.
          Hide
          Matt Foley added a comment -

          Closed upon release of Hadoop 1.2.0.

          Show
          Matt Foley added a comment - Closed upon release of Hadoop 1.2.0.

            People

            • Assignee:
              Amareshwari Sriramadasu
              Reporter:
              Amareshwari Sriramadasu
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development