Details

    • Type: Test Test
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 3.0.0
    • Component/s: fs
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      The TestDFSShell's textTest(…) currently tests all sorts of binary and compressed files, but doesn't test plaintext files. We should add one test for plaintext as well.

        Activity

        Harsh J created issue -
        Harsh J made changes -
        Field Original Value New Value
        Labels newbie
        Akira AJISAKA made changes -
        Attachment HADOOP-8844-1.patch [ 12591043 ]
        Hide
        Akira AJISAKA added a comment -

        I attached a patch to add one test for plaintext.

        Show
        Akira AJISAKA added a comment - I attached a patch to add one test for plaintext.
        Akira AJISAKA made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12591043/HADOOP-8844-1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2746//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2746//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12591043/HADOOP-8844-1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2746//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2746//console This message is automatically generated.
        Hide
        Harsh J added a comment -

        +1, this looks good! Committing to trunk.

        Show
        Harsh J added a comment - +1, this looks good! Committing to trunk.
        Harsh J made changes -
        Assignee Akira AJISAKA [ ajisakaa ]
        Hide
        Harsh J added a comment -

        Thanks for contributing this test Akira! Hope to see many more.

        Show
        Harsh J added a comment - Thanks for contributing this test Akira! Hope to see many more.
        Harsh J made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 3.0.0 [ 12320357 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-trunk-Commit #4045 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4045/)
        HADOOP-8844. Add a plaintext fs -text test-case. Contributed by Akira AJISAKA. (harsh) (Revision 1500190)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1500190
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java
        Show
        Hudson added a comment - Integrated in Hadoop-trunk-Commit #4045 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4045/ ) HADOOP-8844 . Add a plaintext fs -text test-case. Contributed by Akira AJISAKA. (harsh) (Revision 1500190) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1500190 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Yarn-trunk #262 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/262/)
        HADOOP-8844. Add a plaintext fs -text test-case. Contributed by Akira AJISAKA. (harsh) (Revision 1500190)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1500190
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java
        Show
        Hudson added a comment - Integrated in Hadoop-Yarn-trunk #262 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/262/ ) HADOOP-8844 . Add a plaintext fs -text test-case. Contributed by Akira AJISAKA. (harsh) (Revision 1500190) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1500190 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1452 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1452/)
        HADOOP-8844. Add a plaintext fs -text test-case. Contributed by Akira AJISAKA. (harsh) (Revision 1500190)

        Result = FAILURE
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1500190
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1452 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1452/ ) HADOOP-8844 . Add a plaintext fs -text test-case. Contributed by Akira AJISAKA. (harsh) (Revision 1500190) Result = FAILURE harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1500190 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1479 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1479/)
        HADOOP-8844. Add a plaintext fs -text test-case. Contributed by Akira AJISAKA. (harsh) (Revision 1500190)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1500190
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1479 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1479/ ) HADOOP-8844 . Add a plaintext fs -text test-case. Contributed by Akira AJISAKA. (harsh) (Revision 1500190) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1500190 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        283d 1h 11m 1 Akira AJISAKA 05/Jul/13 23:04
        Patch Available Patch Available Resolved Resolved
        4h 13m 1 Harsh J 06/Jul/13 03:17

          People

          • Assignee:
            Akira AJISAKA
            Reporter:
            Harsh J
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development