[HADOOP-8770] NN should not RPC to self to find trash defaults (causes deadlock)

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 2.0.2-alpha
• Fix Version/s: 2.0.2-alpha
• Component/s: trash
• Hadoop Flags: Reviewed
• Assignee: Eli Collins
• Reporter: Todd Lipcon
• Created: 30/Aug/12 23:24
• Updated: 11/Oct/12 17:45
• Resolved: 05/Sep/12 19:45

Description

When transitioning a SBN to active, I ran into the following situation:

• the TrashPolicy first gets loaded by an IPC Server Handler thread. The initialize function then tries to make an RPC to the same node to find out the defaults.
• This is happening inside the NN write lock (since it's part of the active initialization). Hence, all of the other handler threads are already blocked waiting to get the NN lock.
• Since no handler threads are free, the RPC blocks forever and the NN never enters active state.

We need to have a general policy that the NN should never make RPCs to itself for any reason, due to potential for deadlocks like this.

Issue Links

• relates to: HDFS-3881 Detect and disallow self IPC
• relates to: HDFS-3882 NN trash emptier should not delete files via the client
• relates to: HADOOP-8689 Make trash a server side configuration option