Hadoop Common
  1. Hadoop Common
  2. HADOOP-8754

Deprecate all the RPC.getServer() variants

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 2.0.2-alpha
    • Component/s: ipc
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In HADOOP-8736, a Builder is introduced to replace all the getServer() variants. This JIRA is to delete all the getServer() variants once all the other components replaced this method with the Builder.

      1. HADOOP-8754.patch
        3 kB
        Brandon Li
      2. HADOOP-8754.patch
        2 kB
        Brandon Li

        Issue Links

          Activity

          Brandon Li created issue -
          Brandon Li made changes -
          Field Original Value New Value
          Link This issue relates to HADOOP-8736 [ HADOOP-8736 ]
          Hide
          Todd Lipcon added a comment -

          Please deprecate them for one version before removal. I believe some downstream projects use Hadoop IPC.

          Show
          Todd Lipcon added a comment - Please deprecate them for one version before removal. I believe some downstream projects use Hadoop IPC.
          Hide
          Suresh Srinivas added a comment -

          Todd, from what I know there are copies of Hadoop RPC and not the RPC implementation from common itself. Which downstream projects are using the implementation from common?

          Show
          Suresh Srinivas added a comment - Todd, from what I know there are copies of Hadoop RPC and not the RPC implementation from common itself. Which downstream projects are using the implementation from common?
          Hide
          Suresh Srinivas added a comment -

          Created HADOOP-8759 to add appropriate annotations.

          Show
          Suresh Srinivas added a comment - Created HADOOP-8759 to add appropriate annotations.
          Hide
          Todd Lipcon added a comment -

          I'm not sure how many other examples there are, but it looks like HAMA at least uses RPC.getServer.

          Show
          Todd Lipcon added a comment - I'm not sure how many other examples there are, but it looks like HAMA at least uses RPC.getServer.
          Hide
          Brandon Li added a comment -

          OK. Let's be a bit conservative, deprecate them first. Modifying the title accordingly...

          Show
          Brandon Li added a comment - OK. Let's be a bit conservative, deprecate them first. Modifying the title accordingly...
          Brandon Li made changes -
          Summary remove all the RPC.getServer() variants Deprecate all the RPC.getServer() variants
          Brandon Li made changes -
          Attachment HADOOP-8754.patch [ 12544071 ]
          Brandon Li made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12544071/HADOOP-8754.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

          org.apache.hadoop.ha.TestZKFailoverController

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1410//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1410//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12544071/HADOOP-8754.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.ha.TestZKFailoverController +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1410//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1410//console This message is automatically generated.
          Hide
          Brandon Li added a comment -

          The test failure is not introduced by this patch.
          No unit test needed for the change since it just deprecates a few methods.

          Show
          Brandon Li added a comment - The test failure is not introduced by this patch. No unit test needed for the change since it just deprecates a few methods.
          Hide
          Suresh Srinivas added a comment -

          A quick comment - Can you please a comment indicating, the method is deprecated, use the Builder instead.

          Show
          Suresh Srinivas added a comment - A quick comment - Can you please a comment indicating, the method is deprecated, use the Builder instead.
          Brandon Li made changes -
          Attachment HADOOP-8754.patch [ 12544090 ]
          Hide
          Brandon Li added a comment -

          New patch has the comments. Thanks!

          Show
          Brandon Li added a comment - New patch has the comments. Thanks!
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12544090/HADOOP-8754.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

          org.apache.hadoop.fs.TestHarFileSystem
          org.apache.hadoop.fs.TestFileContextDeleteOnExit
          org.apache.hadoop.fs.permission.TestFsPermission
          org.apache.hadoop.fs.TestS3_LocalFileContextURI
          org.apache.hadoop.fs.s3native.TestInMemoryNativeS3FileSystemContract
          org.apache.hadoop.fs.TestFileSystemCaching
          org.apache.hadoop.fs.TestAfsCheckPath
          org.apache.hadoop.fs.TestGetFileBlockLocations
          org.apache.hadoop.fs.TestFsShellCopy
          org.apache.hadoop.fs.TestLocalFileSystem

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1416//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1416//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12544090/HADOOP-8754.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.fs.TestHarFileSystem org.apache.hadoop.fs.TestFileContextDeleteOnExit org.apache.hadoop.fs.permission.TestFsPermission org.apache.hadoop.fs.TestS3_LocalFileContextURI org.apache.hadoop.fs.s3native.TestInMemoryNativeS3FileSystemContract org.apache.hadoop.fs.TestFileSystemCaching org.apache.hadoop.fs.TestAfsCheckPath org.apache.hadoop.fs.TestGetFileBlockLocations org.apache.hadoop.fs.TestFsShellCopy org.apache.hadoop.fs.TestLocalFileSystem +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1416//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1416//console This message is automatically generated.
          Brandon Li made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Brandon Li made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Suresh Srinivas added a comment -

          Test failures are unrelated to this patch.

          Show
          Suresh Srinivas added a comment - Test failures are unrelated to this patch.
          Hide
          Suresh Srinivas added a comment -

          +1 for the patch.

          Show
          Suresh Srinivas added a comment - +1 for the patch.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12544090/HADOOP-8754.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

          org.apache.hadoop.ha.TestZKFailoverController

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1419//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1419//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12544090/HADOOP-8754.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.ha.TestZKFailoverController +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1419//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1419//console This message is automatically generated.
          Hide
          Brandon Li added a comment -

          Test failure is not related with this patch.

          Show
          Brandon Li added a comment - Test failure is not related with this patch.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have committed this. Thanks, Brandon!

          Also thanks Suresh for reviewing it.

          Show
          Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Brandon! Also thanks Suresh for reviewing it.
          Tsz Wo Nicholas Sze made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Fix Version/s 2.2.0-alpha [ 12322473 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2765 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2765/)
          HADOOP-8754. Deprecate all the RPC.getServer() variants. Contributed by Brandon Li (Revision 1381845)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1381845
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2765 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2765/ ) HADOOP-8754 . Deprecate all the RPC.getServer() variants. Contributed by Brandon Li (Revision 1381845) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1381845 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2702 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2702/)
          HADOOP-8754. Deprecate all the RPC.getServer() variants. Contributed by Brandon Li (Revision 1381845)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1381845
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2702 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2702/ ) HADOOP-8754 . Deprecate all the RPC.getServer() variants. Contributed by Brandon Li (Revision 1381845) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1381845 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2726 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2726/)
          HADOOP-8754. Deprecate all the RPC.getServer() variants. Contributed by Brandon Li (Revision 1381845)

          Result = FAILURE
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1381845
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2726 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2726/ ) HADOOP-8754 . Deprecate all the RPC.getServer() variants. Contributed by Brandon Li (Revision 1381845) Result = FAILURE szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1381845 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1158 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1158/)
          HADOOP-8754. Deprecate all the RPC.getServer() variants. Contributed by Brandon Li (Revision 1381845)

          Result = FAILURE
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1381845
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1158 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1158/ ) HADOOP-8754 . Deprecate all the RPC.getServer() variants. Contributed by Brandon Li (Revision 1381845) Result = FAILURE szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1381845 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1189 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1189/)
          HADOOP-8754. Deprecate all the RPC.getServer() variants. Contributed by Brandon Li (Revision 1381845)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1381845
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1189 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1189/ ) HADOOP-8754 . Deprecate all the RPC.getServer() variants. Contributed by Brandon Li (Revision 1381845) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1381845 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Brandon Li
              Reporter:
              Brandon Li
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development