Hadoop Common
  1. Hadoop Common
  2. HADOOP-8703

distcpV2: turn CRC checking off for 0 byte size

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.3
    • Fix Version/s: 0.23.3, 2.0.2-alpha
    • Component/s: None
    • Labels:
      None
    • Release Note:
      distcp skips CRC on 0 byte files.

      Description

      DistcpV2 (hadoop-tools/hadoop-distcp/..) can fail from checksum failure, sometimes when copying a 0 byte file. Root cause of this may have to do with an inconsistent nature of HDFS when creating 0 byte files, however distcp can avoid this issue by not checking CRC when size is zero.

      This issue was reported as part of HADOOP-8233, though it seems like a better idea to treat this particular aspect on it's own.

      1. HADOOP-8703-branch-0.23.patch
        0.9 kB
        Dave Thompson
      2. HADOOP-8703-branch-0.23.patch
        0.9 kB
        Dave Thompson

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        8m 45s 1 Dave Thompson 15/Aug/12 16:30
        Patch Available Patch Available Resolved Resolved
        3h 50m 1 Robert Joseph Evans 15/Aug/12 20:20
        Resolved Resolved Closed Closed
        56d 22h 24m 1 Arun C Murthy 11/Oct/12 18:45
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Arun C Murthy made changes -
        Fix Version/s 2.0.2-alpha [ 12322473 ]
        Fix Version/s 3.0.0 [ 12320357 ]
        Fix Version/s 2.1.0-alpha [ 12321441 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1168 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1168/)
        HADOOP-8703: Fix formatting issue. (Revision 1373599)
        HADOOP-8703. distcpV2: turn CRC checking off for 0 byte size (Dave Thompson via bobby) (Revision 1373581)

        Result = FAILURE
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373599
        Files :

        • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java

        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373581
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1168 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1168/ ) HADOOP-8703 : Fix formatting issue. (Revision 1373599) HADOOP-8703 . distcpV2: turn CRC checking off for 0 byte size (Dave Thompson via bobby) (Revision 1373581) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373599 Files : /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373581 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1136 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1136/)
        HADOOP-8703: Fix formatting issue. (Revision 1373599)
        HADOOP-8703. distcpV2: turn CRC checking off for 0 byte size (Dave Thompson via bobby) (Revision 1373581)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373599
        Files :

        • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java

        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373581
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1136 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1136/ ) HADOOP-8703 : Fix formatting issue. (Revision 1373599) HADOOP-8703 . distcpV2: turn CRC checking off for 0 byte size (Dave Thompson via bobby) (Revision 1373581) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373599 Files : /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373581 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #345 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/345/)
        svn merge -c 1373599. FIXES: HADOOP-8703 (Revision 1373602)
        svn merge -c 1373581 FIXES: HADOOP-8703. distcpV2: turn CRC checking off for 0 byte size (Dave Thompson via bobby) (Revision 1373588)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373602
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java

        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373588
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #345 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/345/ ) svn merge -c 1373599. FIXES: HADOOP-8703 (Revision 1373602) svn merge -c 1373581 FIXES: HADOOP-8703 . distcpV2: turn CRC checking off for 0 byte size (Dave Thompson via bobby) (Revision 1373588) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373602 Files : /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373588 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2610 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2610/)
        HADOOP-8703: Fix formatting issue. (Revision 1373599)

        Result = FAILURE
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373599
        Files :

        • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2610 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2610/ ) HADOOP-8703 : Fix formatting issue. (Revision 1373599) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373599 Files : /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2609 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2609/)
        HADOOP-8703. distcpV2: turn CRC checking off for 0 byte size (Dave Thompson via bobby) (Revision 1373581)

        Result = FAILURE
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373581
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2609 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2609/ ) HADOOP-8703 . distcpV2: turn CRC checking off for 0 byte size (Dave Thompson via bobby) (Revision 1373581) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373581 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java
        Hide
        Alejandro Abdelnur added a comment -

        Bobby, no worries, not at all. If we'd happen to keep tabs I'd be far in the lead

        Show
        Alejandro Abdelnur added a comment - Bobby, no worries, not at all. If we'd happen to keep tabs I'd be far in the lead
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2581 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2581/)
        HADOOP-8703: Fix formatting issue. (Revision 1373599)
        HADOOP-8703. distcpV2: turn CRC checking off for 0 byte size (Dave Thompson via bobby) (Revision 1373581)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373599
        Files :

        • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java

        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373581
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2581 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2581/ ) HADOOP-8703 : Fix formatting issue. (Revision 1373599) HADOOP-8703 . distcpV2: turn CRC checking off for 0 byte size (Dave Thompson via bobby) (Revision 1373581) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373599 Files : /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373581 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2646 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2646/)
        HADOOP-8703: Fix formatting issue. (Revision 1373599)
        HADOOP-8703. distcpV2: turn CRC checking off for 0 byte size (Dave Thompson via bobby) (Revision 1373581)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373599
        Files :

        • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java

        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373581
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2646 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2646/ ) HADOOP-8703 : Fix formatting issue. (Revision 1373599) HADOOP-8703 . distcpV2: turn CRC checking off for 0 byte size (Dave Thompson via bobby) (Revision 1373581) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373599 Files : /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373581 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java
        Hide
        Robert Joseph Evans added a comment -

        Thanks for catching that Alejandro, my bad. I have amended the commit. If you see any other problems please let me know.

        Show
        Robert Joseph Evans added a comment - Thanks for catching that Alejandro, my bad. I have amended the commit. If you see any other problems please let me know.
        Hide
        Alejandro Abdelnur added a comment -

        IF block not within {},it should even if a single line. IMO we should amend the commit.

        Show
        Alejandro Abdelnur added a comment - IF block not within {},it should even if a single line. IMO we should amend the commit.
        Robert Joseph Evans made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 2.1.0-alpha [ 12321441 ]
        Fix Version/s 3.0.0 [ 12320357 ]
        Resolution Fixed [ 1 ]
        Hide
        Robert Joseph Evans added a comment -

        Thanks Dave,

        +1 I put this into trunk, branch-2, branch-2.1-alpha and branch-0.23

        Show
        Robert Joseph Evans added a comment - Thanks Dave, +1 I put this into trunk, branch-2, branch-2.1-alpha and branch-0.23
        Dave Thompson made changes -
        Attachment HADOOP-8703-branch-0.23.patch [ 12541101 ]
        Hide
        Dave Thompson added a comment -

        Doh! Same patch, sans tab.

        Show
        Dave Thompson added a comment - Doh! Same patch, sans tab.
        Hide
        Daryn Sharp added a comment -

        +1 Pending tab change.

        Show
        Daryn Sharp added a comment - +1 Pending tab change.
        Hide
        Robert Joseph Evans added a comment -

        The change looks good, but there is a tab in there, please change it to be spaces. Other then that +1.

        Show
        Robert Joseph Evans added a comment - The change looks good, but there is a tab in there, please change it to be spaces. Other then that +1.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12541073/HADOOP-8703-branch-0.23.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-tools/hadoop-distcp.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1307//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1307//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12541073/HADOOP-8703-branch-0.23.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-tools/hadoop-distcp. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1307//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1307//console This message is automatically generated.
        Dave Thompson made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Release Note distcp skips CRC on 0 byte files.
        Dave Thompson made changes -
        Field Original Value New Value
        Attachment HADOOP-8703-branch-0.23.patch [ 12541073 ]
        Hide
        Dave Thompson added a comment -

        Attaching a patch to skip CRC check on 0 byte files.

        Show
        Dave Thompson added a comment - Attaching a patch to skip CRC check on 0 byte files.
        Dave Thompson created issue -

          People

          • Assignee:
            Dave Thompson
            Reporter:
            Dave Thompson
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Due:
              Created:
              Updated:
              Resolved:

              Development