Hadoop Common
  1. Hadoop Common
  2. HADOOP-8695

TestPathData fails intermittently with JDK7

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.3, 3.0.0, 2.0.2-alpha
    • Fix Version/s: 0.23.3, 2.0.2-alpha
    • Component/s: test
    • Labels:
    • Environment:

      Description

      Failed tests: testWithDirStringAndConf(org.apache.hadoop.fs.shell.TestPathData): checking exist
      testToFile(org.apache.hadoop.fs.shell.TestPathData): expected:<file:/tmp> but was:</data/md0/hadoop-common/hadoop-common-project/hadoop-common/target/test/data/testPD/d1>

      testWithStringAndConfForBuggyPath (which is declared last and therefore runs last with JDK6) overwrites the static variable testDir with file:///tmp. With JDK7, test methods run in an undefined order, and the other tests will fail if run after this one.

      1. HADOOP-8695.patch
        3 kB
        Trevor Robinson
      2. HADOOP-8695-2.patch
        5 kB
        Trevor Robinson

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1170 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1170/)
        HADOOP-8695. TestPathData fails intermittently with JDK7 (Trevor Robinson via tgraves) (Revision 1374447)

        Result = FAILURE
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1374447
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestPathData.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1170 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1170/ ) HADOOP-8695 . TestPathData fails intermittently with JDK7 (Trevor Robinson via tgraves) (Revision 1374447) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1374447 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestPathData.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1138 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1138/)
        HADOOP-8695. TestPathData fails intermittently with JDK7 (Trevor Robinson via tgraves) (Revision 1374447)

        Result = FAILURE
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1374447
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestPathData.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1138 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1138/ ) HADOOP-8695 . TestPathData fails intermittently with JDK7 (Trevor Robinson via tgraves) (Revision 1374447) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1374447 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestPathData.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #347 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/347/)
        merge -r 1374448:1374449 from branch-2. FIXES: HADOOP-8695 (Revision 1374451)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1374451
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestPathData.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #347 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/347/ ) merge -r 1374448:1374449 from branch-2. FIXES: HADOOP-8695 (Revision 1374451) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1374451 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestPathData.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2629 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2629/)
        HADOOP-8695. TestPathData fails intermittently with JDK7 (Trevor Robinson via tgraves) (Revision 1374447)

        Result = FAILURE
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1374447
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestPathData.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2629 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2629/ ) HADOOP-8695 . TestPathData fails intermittently with JDK7 (Trevor Robinson via tgraves) (Revision 1374447) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1374447 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestPathData.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2600 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2600/)
        HADOOP-8695. TestPathData fails intermittently with JDK7 (Trevor Robinson via tgraves) (Revision 1374447)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1374447
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestPathData.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2600 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2600/ ) HADOOP-8695 . TestPathData fails intermittently with JDK7 (Trevor Robinson via tgraves) (Revision 1374447) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1374447 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestPathData.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2664 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2664/)
        HADOOP-8695. TestPathData fails intermittently with JDK7 (Trevor Robinson via tgraves) (Revision 1374447)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1374447
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestPathData.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2664 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2664/ ) HADOOP-8695 . TestPathData fails intermittently with JDK7 (Trevor Robinson via tgraves) (Revision 1374447) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1374447 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestPathData.java
        Hide
        Thomas Graves added a comment -

        +1 Thanks Trevor!

        Show
        Thomas Graves added a comment - +1 Thanks Trevor!
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12541390/HADOOP-8695-2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1324//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1324//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12541390/HADOOP-8695-2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1324//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1324//console This message is automatically generated.
        Hide
        Trevor Robinson added a comment -

        Alright, let's fix it harder. New patch uses @Before/After to create a separate FileSystem instance for each test.

        Show
        Trevor Robinson added a comment - Alright, let's fix it harder. New patch uses @Before/After to create a separate FileSystem instance for each test.
        Hide
        Thomas Graves added a comment -

        I still see intermittent test failures when running it multiple times. I think there are other assumptions with test order. For instance testRelativeGlobBack sets the working dir.

        Failed tests: testWithDirStringAndConf(org.apache.hadoop.fs.shell.TestPathData): checking exist

        Another run:

        Failed tests: testWithDirStringAndConf(org.apache.hadoop.fs.shell.TestPathData): checking exist
        testCwdContents(org.apache.hadoop.fs.shell.TestPathData): expected:<0:<[d1>, 1:<d]2>> but was:<0:<[f1>, 1:<f1.1>, 2:<f]2>>
        testToFile(org.apache.hadoop.fs.shell.TestPathData): expected:</home/tgraves/8695/hadoop-common-project/hadoop-common/target/test/data/testPD> but was:</home/tgraves/8695/hadoop-common-project/hadoop-common/target/test/data/testPD/d1>

        Tests in error:
        testUnqualifiedUriContents(org.apache.hadoop.fs.shell.TestPathData): `d1': No such file or directory
        testQualifiedUriContents(org.apache.hadoop.fs.shell.TestPathData): `file:/home/tgraves/8695/hadoop-common-project/hadoop-common/target/test/data/testPD/d1/d1': No such file or directory

        Show
        Thomas Graves added a comment - I still see intermittent test failures when running it multiple times. I think there are other assumptions with test order. For instance testRelativeGlobBack sets the working dir. Failed tests: testWithDirStringAndConf(org.apache.hadoop.fs.shell.TestPathData): checking exist Another run: Failed tests: testWithDirStringAndConf(org.apache.hadoop.fs.shell.TestPathData): checking exist testCwdContents(org.apache.hadoop.fs.shell.TestPathData): expected:<0:< [d1>, 1:<d] 2>> but was:<0:< [f1>, 1:<f1.1>, 2:<f] 2>> testToFile(org.apache.hadoop.fs.shell.TestPathData): expected:</home/tgraves/8695/hadoop-common-project/hadoop-common/target/test/data/testPD> but was:</home/tgraves/8695/hadoop-common-project/hadoop-common/target/test/data/testPD/d1> Tests in error: testUnqualifiedUriContents(org.apache.hadoop.fs.shell.TestPathData): `d1': No such file or directory testQualifiedUriContents(org.apache.hadoop.fs.shell.TestPathData): ` file:/home/tgraves/8695/hadoop-common-project/hadoop-common/target/test/data/testPD/d1/d1': No such file or directory
        Hide
        Trevor Robinson added a comment -

        Test failures are HADOOP-8699

        Show
        Trevor Robinson added a comment - Test failures are HADOOP-8699
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12540812/HADOOP-8695.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

        org.apache.hadoop.fs.TestS3_LocalFileContextURI
        org.apache.hadoop.fs.s3native.TestInMemoryNativeS3FileSystemContract
        org.apache.hadoop.fs.TestLocal_S3FileContextURI
        org.apache.hadoop.fs.s3.TestInMemoryS3FileSystemContract

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1292//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1292//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12540812/HADOOP-8695.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.fs.TestS3_LocalFileContextURI org.apache.hadoop.fs.s3native.TestInMemoryNativeS3FileSystemContract org.apache.hadoop.fs.TestLocal_S3FileContextURI org.apache.hadoop.fs.s3.TestInMemoryS3FileSystemContract +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1292//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1292//console This message is automatically generated.
        Hide
        Trevor Robinson added a comment -

        Removed static variable dirString and changed testWithStringAndConfForBuggyPath to not modify testDir.

        Show
        Trevor Robinson added a comment - Removed static variable dirString and changed testWithStringAndConfForBuggyPath to not modify testDir .

          People

          • Assignee:
            Trevor Robinson
            Reporter:
            Trevor Robinson
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development