Hadoop Common
  1. Hadoop Common
  2. HADOOP-8644

AuthenticatedURL should be able to use SSLFactory

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.2-alpha
    • Fix Version/s: 2.0.2-alpha
    • Component/s: security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This is required to enable the use of HTTPS with SPNEGO using Hadoop configured keystores. This is required by HADOOP-8581.

      1. HADOOP-8644.patch
        15 kB
        Alejandro Abdelnur
      2. HADOOP-8644.patch
        15 kB
        Alejandro Abdelnur

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1128 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1128/)
          HADOOP-8644. AuthenticatedURL should be able to use SSLFactory. (tucu) (Revision 1370045)

          Result = SUCCESS
          tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370045
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/AuthenticatedURL.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/Authenticator.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/ConnectionConfigurator.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/KerberosAuthenticator.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/PseudoAuthenticator.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/client/AuthenticatorTestCase.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/client/TestAuthenticatedURL.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/ssl/TestSSLFactory.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1128 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1128/ ) HADOOP-8644 . AuthenticatedURL should be able to use SSLFactory. (tucu) (Revision 1370045) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370045 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/AuthenticatedURL.java /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/Authenticator.java /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/ConnectionConfigurator.java /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/KerberosAuthenticator.java /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/PseudoAuthenticator.java /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/client/AuthenticatorTestCase.java /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/client/TestAuthenticatedURL.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/ssl/TestSSLFactory.java
          Hide
          Suresh Srinivas added a comment -

          @Alejandro, sounds good

          Show
          Suresh Srinivas added a comment - @Alejandro, sounds good
          Hide
          Alejandro Abdelnur added a comment -

          @suresh, my bad, committed the patch after addressing ATM's comments which where minor. Jenkins failed because it tried to apply the patch on a revision the patch has been already committed. Even if trivial, I'll wait next time to avoid this mis-failures and to ensure I'm not introducing any test-patch warning in the new revision.

          Show
          Alejandro Abdelnur added a comment - @suresh, my bad, committed the patch after addressing ATM's comments which where minor. Jenkins failed because it tried to apply the patch on a revision the patch has been already committed. Even if trivial, I'll wait next time to avoid this mis-failures and to ensure I'm not introducing any test-patch warning in the new revision.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2576 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2576/)
          HADOOP-8644. AuthenticatedURL should be able to use SSLFactory. (tucu) (Revision 1370045)

          Result = FAILURE
          tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370045
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/AuthenticatedURL.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/Authenticator.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/ConnectionConfigurator.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/KerberosAuthenticator.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/PseudoAuthenticator.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/client/AuthenticatorTestCase.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/client/TestAuthenticatedURL.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/ssl/TestSSLFactory.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2576 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2576/ ) HADOOP-8644 . AuthenticatedURL should be able to use SSLFactory. (tucu) (Revision 1370045) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370045 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/AuthenticatedURL.java /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/Authenticator.java /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/ConnectionConfigurator.java /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/KerberosAuthenticator.java /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/PseudoAuthenticator.java /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/client/AuthenticatorTestCase.java /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/client/TestAuthenticatedURL.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/ssl/TestSSLFactory.java
          Hide
          Suresh Srinivas added a comment -

          Alejandro, can you please wait for Jenkins to +1 before committing the patch. In this case I do not see +1 for your updated patch.

          Show
          Suresh Srinivas added a comment - Alejandro, can you please wait for Jenkins to +1 before committing the patch. In this case I do not see +1 for your updated patch.
          Hide
          Alejandro Abdelnur added a comment -

          Committed to trunk and branch-2.

          Show
          Alejandro Abdelnur added a comment - Committed to trunk and branch-2.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2557 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2557/)
          HADOOP-8644. AuthenticatedURL should be able to use SSLFactory. (tucu) (Revision 1370045)

          Result = SUCCESS
          tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370045
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/AuthenticatedURL.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/Authenticator.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/ConnectionConfigurator.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/KerberosAuthenticator.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/PseudoAuthenticator.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/client/AuthenticatorTestCase.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/client/TestAuthenticatedURL.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/ssl/TestSSLFactory.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2557 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2557/ ) HADOOP-8644 . AuthenticatedURL should be able to use SSLFactory. (tucu) (Revision 1370045) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370045 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/AuthenticatedURL.java /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/Authenticator.java /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/ConnectionConfigurator.java /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/KerberosAuthenticator.java /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/PseudoAuthenticator.java /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/client/AuthenticatorTestCase.java /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/client/TestAuthenticatedURL.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/ssl/TestSSLFactory.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2622 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2622/)
          HADOOP-8644. AuthenticatedURL should be able to use SSLFactory. (tucu) (Revision 1370045)

          Result = SUCCESS
          tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370045
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/AuthenticatedURL.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/Authenticator.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/ConnectionConfigurator.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/KerberosAuthenticator.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/PseudoAuthenticator.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/client/AuthenticatorTestCase.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/client/TestAuthenticatedURL.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/ssl/TestSSLFactory.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2622 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2622/ ) HADOOP-8644 . AuthenticatedURL should be able to use SSLFactory. (tucu) (Revision 1370045) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370045 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/AuthenticatedURL.java /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/Authenticator.java /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/ConnectionConfigurator.java /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/KerberosAuthenticator.java /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/PseudoAuthenticator.java /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/client/AuthenticatorTestCase.java /hadoop/common/trunk/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/client/TestAuthenticatedURL.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/ssl/TestSSLFactory.java
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12539359/HADOOP-8644.patch
          against trunk revision .

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1255//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12539359/HADOOP-8644.patch against trunk revision . -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1255//console This message is automatically generated.
          Hide
          Alejandro Abdelnur added a comment -

          new patch Addressing ATM's comments.

          Show
          Alejandro Abdelnur added a comment - new patch Addressing ATM's comments.
          Hide
          Daryn Sharp added a comment -

          +1 for me too

          Show
          Daryn Sharp added a comment - +1 for me too
          Hide
          Aaron T. Myers added a comment -

          Patch looks good to me. Two small nits:

          1. You can probably do away with the TestConnectorConfigurator class entirely, and just use a mock and verify().
          2. Please indent 4 spaces when continuing a line instead of 2, e.g.:
            +  public HttpURLConnection configure(HttpURLConnection conn)
            +    throws IOException {
            

            and:

            +      HttpsURLConnection sslConn =
            +        (HttpsURLConnection) new URL("https://foo").openConnection();
            

          +1 once these are addressed.

          Show
          Aaron T. Myers added a comment - Patch looks good to me. Two small nits: You can probably do away with the TestConnectorConfigurator class entirely, and just use a mock and verify(). Please indent 4 spaces when continuing a line instead of 2, e.g.: + public HttpURLConnection configure(HttpURLConnection conn) + throws IOException { and: + HttpsURLConnection sslConn = + (HttpsURLConnection) new URL( "https: //foo" ).openConnection(); +1 once these are addressed.
          Hide
          Alejandro Abdelnur added a comment -

          If you have a AuthenticatedURL instance that is being used to connect to both HTTP and HTTPS endpoints, you'll need to configure the connection with the SSLFactory only if it is HTTPS. This scenario does not currently happen in Hadoop, it is just a a safeguard for now. I don't see unintended consequences as it is a NOP if HTTP. Makes sense?

          Show
          Alejandro Abdelnur added a comment - If you have a AuthenticatedURL instance that is being used to connect to both HTTP and HTTPS endpoints, you'll need to configure the connection with the SSLFactory only if it is HTTPS. This scenario does not currently happen in Hadoop, it is just a a safeguard for now. I don't see unintended consequences as it is a NOP if HTTP. Makes sense?
          Hide
          Daryn Sharp added a comment -

          Thanks, that clarifies the intention, although I'm still confused why SSLFactory is involved in a non-ssl connection? If the scheme isn't https, shouldn't it not even be passed in order to avoid other possible unintended consequences?

          Show
          Daryn Sharp added a comment - Thanks, that clarifies the intention, although I'm still confused why SSLFactory is involved in a non-ssl connection? If the scheme isn't https, shouldn't it not even be passed in order to avoid other possible unintended consequences?
          Hide
          Alejandro Abdelnur added a comment -

          AuthenticatedURL can be used over clear HTTP, that is how it has been used until now, just to provide authentication. This change is to be able to use with HTTPS in order to add encryption. Configuring Hadoop to user Kerberos and to use encryption will still be 2 different knobs as I assume many folks don't want to pay the performance price of wire encryption. Hope this clarifies.

          Show
          Alejandro Abdelnur added a comment - AuthenticatedURL can be used over clear HTTP, that is how it has been used until now, just to provide authentication. This change is to be able to use with HTTPS in order to add encryption. Configuring Hadoop to user Kerberos and to use encryption will still be 2 different knobs as I assume many folks don't want to pay the performance price of wire encryption. Hope this clarifies.
          Hide
          Daryn Sharp added a comment -

          I'm not sure I fully grok the change, but I think it looks ok. One question, why does SSLFactory#configure need to check if the connection is an instance of HttpsURLConnection? Given that this is a ssl factory, when would it legitimately be invoked with a non-https connection?

          Show
          Daryn Sharp added a comment - I'm not sure I fully grok the change, but I think it looks ok. One question, why does SSLFactory#configure need to check if the connection is an instance of HttpsURLConnection ? Given that this is a ssl factory, when would it legitimately be invoked with a non-https connection?
          Hide
          Alejandro Abdelnur added a comment -

          Filed JIRA HDFS-3761. Other than that, are we good with this JIRA?

          Show
          Alejandro Abdelnur added a comment - Filed JIRA HDFS-3761 . Other than that, are we good with this JIRA?
          Hide
          Daryn Sharp added a comment -

          I suppose it can be a separate jira, but it needs to be a high prio too since the timeouts were added to address serious problems.

          Show
          Daryn Sharp added a comment - I suppose it can be a separate jira, but it needs to be a high prio too since the timeouts were added to address serious problems.
          Hide
          Alejandro Abdelnur added a comment -

          It makes sense, this should be done in all places where AuthenticatedURL is being used. But I think it should be done as part of a separate JIRA as this one is not introducing such regression. Makes sense?

          Show
          Alejandro Abdelnur added a comment - It makes sense, this should be done in all places where AuthenticatedURL is being used. But I think it should be done as part of a separate JIRA as this one is not introducing such regression. Makes sense?
          Hide
          Daryn Sharp added a comment -

          That particular class/method doesn't necessarily have to be used, but we need to carry over the setting of timeouts.

          Show
          Daryn Sharp added a comment - That particular class/method doesn't necessarily have to be used, but we need to carry over the setting of timeouts.
          Hide
          Alejandro Abdelnur added a comment -

          @Daryn, I don't see how that is possible as URLUtils it is not using AuthenticatedURL class.

          Show
          Alejandro Abdelnur added a comment - @Daryn, I don't see how that is possible as URLUtils it is not using AuthenticatedURL class.
          Hide
          Daryn Sharp added a comment -

          This appears to be regressing URLUtils.openConnection that sets connect and read timeouts?

          Show
          Daryn Sharp added a comment - This appears to be regressing URLUtils.openConnection that sets connect and read timeouts?
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12538964/HADOOP-8644.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1246//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1246//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12538964/HADOOP-8644.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1246//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1246//console This message is automatically generated.

            People

            • Assignee:
              Alejandro Abdelnur
              Reporter:
              Alejandro Abdelnur
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development