[HADOOP-8614] IOUtils#skipFully hangs forever on EOF - ASF JIRA

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.0.0-alpha
Fix Version/s: 0.23.3, 2.0.2-alpha
Component/s: None
Labels:
None

Target Version/s:

2.0.2-alpha
Hadoop Flags:

Reviewed

Description

IOUtils#skipFully contains this code:

  public static void skipFully(InputStream in, long len) throws IOException {
    while (len > 0) {
      long ret = in.skip(len);
      if (ret < 0) {
        throw new IOException( "Premature EOF from inputStream");
      }
      len -= ret;
    }
  }

The Java documentation is silent about what exactly skip is supposed to do in the event of EOF. However, I looked at both InputStream#skip and ByteArrayInputStream#skip, and they both simply return 0 on EOF (no exception). So it seems safe to assume that this is the standard Java way of doing things in an InputStream.

Currently IOUtils#skipFully will loop forever if you ask it to skip past EOF!

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending

Attachments

HADOOP-8614.001.patch

23/Jul/12 18:49

3 kB

Colin P. McCabe

Issue Links

blocks

HDFS-3707 TestFSInputChecker: improper use of skip

Closed

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Hadoop QA added a comment - 23/Jul/12 19:30

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12537591/HADOOP-8614.001.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 1 new or modified test files.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

org.apache.hadoop.ha.TestZKFailoverController

+1 contrib tests. The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1210//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1210//console

This message is automatically generated.

Show

Hadoop QA added a comment - 23/Jul/12 19:30 -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12537591/HADOOP-8614.001.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.ha.TestZKFailoverController +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1210//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1210//console This message is automatically generated.

Hide

Permalink

Eli Collins added a comment - 20/Aug/12 21:08

+1 looks good, test failure is unrelated.

Show

Eli Collins added a comment - 20/Aug/12 21:08 +1 looks good, test failure is unrelated.

Hide

Permalink

Hudson added a comment - 20/Aug/12 21:49

Integrated in Hadoop-Common-trunk-Commit #2607 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2607/)
~~HADOOP-8614~~. IOUtils#skipFully hangs forever on EOF. Contributed by Colin Patrick McCabe (Revision 1375216)

Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375216
Files :

/hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java

Show

Hudson added a comment - 20/Aug/12 21:49 Integrated in Hadoop-Common-trunk-Commit #2607 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2607/ ) HADOOP-8614 . IOUtils#skipFully hangs forever on EOF. Contributed by Colin Patrick McCabe (Revision 1375216) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375216 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java

Hide

Permalink

Hudson added a comment - 20/Aug/12 21:50

Integrated in Hadoop-Hdfs-trunk-Commit #2671 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2671/)
~~HADOOP-8614~~. IOUtils#skipFully hangs forever on EOF. Contributed by Colin Patrick McCabe (Revision 1375216)

Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375216
Files :

/hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java

Show

Hudson added a comment - 20/Aug/12 21:50 Integrated in Hadoop-Hdfs-trunk-Commit #2671 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2671/ ) HADOOP-8614 . IOUtils#skipFully hangs forever on EOF. Contributed by Colin Patrick McCabe (Revision 1375216) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375216 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java

Hide

Permalink

Hudson added a comment - 20/Aug/12 22:07

Integrated in Hadoop-Mapreduce-trunk-Commit #2636 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2636/)
~~HADOOP-8614~~. IOUtils#skipFully hangs forever on EOF. Contributed by Colin Patrick McCabe (Revision 1375216)

Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375216
Files :

/hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java

Show

Hudson added a comment - 20/Aug/12 22:07 Integrated in Hadoop-Mapreduce-trunk-Commit #2636 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2636/ ) HADOOP-8614 . IOUtils#skipFully hangs forever on EOF. Contributed by Colin Patrick McCabe (Revision 1375216) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375216 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java

Hide

Permalink

Hudson added a comment - 21/Aug/12 12:46

Integrated in Hadoop-Hdfs-trunk #1141 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1141/)
~~HADOOP-8614~~. IOUtils#skipFully hangs forever on EOF. Contributed by Colin Patrick McCabe (Revision 1375216)

Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375216
Files :

/hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java

Show

Hudson added a comment - 21/Aug/12 12:46 Integrated in Hadoop-Hdfs-trunk #1141 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1141/ ) HADOOP-8614 . IOUtils#skipFully hangs forever on EOF. Contributed by Colin Patrick McCabe (Revision 1375216) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375216 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java

Hide

Permalink

Hudson added a comment - 21/Aug/12 13:55

Integrated in Hadoop-Mapreduce-trunk #1173 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1173/)
~~HADOOP-8614~~. IOUtils#skipFully hangs forever on EOF. Contributed by Colin Patrick McCabe (Revision 1375216)

Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375216
Files :

/hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java

Show

Hudson added a comment - 21/Aug/12 13:55 Integrated in Hadoop-Mapreduce-trunk #1173 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1173/ ) HADOOP-8614 . IOUtils#skipFully hangs forever on EOF. Contributed by Colin Patrick McCabe (Revision 1375216) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375216 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java

Hide

Permalink

Robert Joseph Evans added a comment - 21/Aug/12 14:29

I pulled this into 0.23.3 too.

Show

Robert Joseph Evans added a comment - 21/Aug/12 14:29 I pulled this into 0.23.3 too.

Hide

Permalink

Hudson added a comment - 22/Aug/12 12:40

Integrated in Hadoop-Hdfs-0.23-Build #351 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/351/)
svn merge -c 1375216 FIXES: ~~HADOOP-8614~~. IOUtils#skipFully hangs forever on EOF. Contributed by Colin Patrick McCabe (Revision 1375572)

Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375572
Files :

/hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
/hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java
/hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java

Show

Hudson added a comment - 22/Aug/12 12:40 Integrated in Hadoop-Hdfs-0.23-Build #351 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/351/ ) svn merge -c 1375216 FIXES: HADOOP-8614 . IOUtils#skipFully hangs forever on EOF. Contributed by Colin Patrick McCabe (Revision 1375572) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375572 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java

People

Assignee:

Colin P. McCabe

Reporter:

Colin P. McCabe

Votes:

0 Vote for this issue

Watchers:

7 Start watching this issue

Dates

Created:

23/Jul/12 18:30

Updated:

11/Oct/12 17:45

Resolved:

29/Aug/12 21:15

Development

Agile

View on Board