Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-8614

IOUtils#skipFully hangs forever on EOF

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 0.23.3, 2.0.2-alpha
    • Component/s: None
    • Labels:
      None

      Description

      IOUtils#skipFully contains this code:

        public static void skipFully(InputStream in, long len) throws IOException {
          while (len > 0) {
            long ret = in.skip(len);
            if (ret < 0) {
              throw new IOException( "Premature EOF from inputStream");
            }
            len -= ret;
          }
        }
      

      The Java documentation is silent about what exactly skip is supposed to do in the event of EOF. However, I looked at both InputStream#skip and ByteArrayInputStream#skip, and they both simply return 0 on EOF (no exception). So it seems safe to assume that this is the standard Java way of doing things in an InputStream.

      Currently IOUtils#skipFully will loop forever if you ask it to skip past EOF!

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                cmccabe Colin P. McCabe
                Reporter:
                cmccabe Colin P. McCabe
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: