Hadoop Common
  1. Hadoop Common
  2. HADOOP-8613

AbstractDelegationTokenIdentifier#getUser() should set token auth type

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Critical Critical
        • Resolution: Fixed
        • Affects Version/s: 1.0.0, 0.23.0, 2.0.0-alpha, 3.0.0
        • Fix Version/s: 1.2.0, 0.23.3, 2.0.2-alpha
        • Component/s: None
        • Labels:
          None

          Description

          AbstractDelegationTokenIdentifier#getUser() returns the UGI associated with a token. The UGI's auth type will either be SIMPLE for non-proxy tokens, or PROXY (effective user) and SIMPLE (real user). Instead of SIMPLE, it needs to be TOKEN.

          1. Text File
            HADOOP-8613.branch-1.patch
            4 kB
            Daryn Sharp
          2. Text File
            HADOOP-8613.patch
            5 kB
            Daryn Sharp
          3. Text File
            HADOOP-8613-2.branch-1.patch
            5 kB
            Daryn Sharp
          4. Text File
            HADOOP-8613-2.patch
            5 kB
            Daryn Sharp

            Issue Links

            is required by

            Bug - A problem which impairs or prevents the functions of the product. HDFS-3553 Hftp proxy tokens are broken

            • Blocker - Blocks development and/or testing work, production could not run
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Daryn Sharp created issue -
              Daryn Sharp made changes -
              Field Original Value New Value
              Link This issue is required by HDFS-3553 [ HDFS-3553 ]
              Daryn Sharp made changes -
              Attachment HADOOP-8613.branch-1.patch [ 12537605 ]
              Attachment HADOOP-8613.patch [ 12537606 ]
              Daryn Sharp made changes -
              Status Open [ 1 ] Patch Available [ 10002 ]
              Hide
              Permalink
              Hadoop QA added a comment -

              +1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12537606/HADOOP-8613.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 1 new or modified test files.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              +1 javadoc. The javadoc tool did not generate any warning messages.

              +1 eclipse:eclipse. The patch built with eclipse:eclipse.

              +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

              +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

              +1 contrib tests. The patch passed contrib unit tests.

              Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1212//testReport/
              Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1212//console

              This message is automatically generated.

              Show
              Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12537606/HADOOP-8613.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1212//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1212//console This message is automatically generated.
              Hide
              Permalink
              Owen O'Malley added a comment -

              Don't you need to pull the code out of JspHelper.getUGI that also sets the authentication method to TOKEN?

              Show
              Owen O'Malley added a comment - Don't you need to pull the code out of JspHelper.getUGI that also sets the authentication method to TOKEN?
              Hide
              Permalink
              Daryn Sharp added a comment -

              I did that in the linked HDFS-3553 but I can pull it back into this patch too if you'd like.

              Show
              Daryn Sharp added a comment - I did that in the linked HDFS-3553 but I can pull it back into this patch too if you'd like.
              Daryn Sharp made changes -
              Attachment HADOOP-8613-2.patch [ 12537895 ]
              Daryn Sharp made changes -
              Attachment HADOOP-8613-2.branch-1.patch [ 12537900 ]
              Hide
              Permalink
              Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12537900/HADOOP-8613-2.branch-1.patch
              against trunk revision .

              -1 patch. The patch command could not apply the patch.

              Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1219//console

              This message is automatically generated.

              Show
              Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12537900/HADOOP-8613-2.branch-1.patch against trunk revision . -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1219//console This message is automatically generated.
              Hide
              Permalink
              Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12537895/HADOOP-8613-2.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 1 new or modified test files.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              +1 javadoc. The javadoc tool did not generate any warning messages.

              +1 eclipse:eclipse. The patch built with eclipse:eclipse.

              +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

              -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

              org.apache.hadoop.hdfs.TestDFSClientRetries

              +1 contrib tests. The patch passed contrib unit tests.

              Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1218//testReport/
              Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1218//console

              This message is automatically generated.

              Show
              Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12537895/HADOOP-8613-2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestDFSClientRetries +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1218//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1218//console This message is automatically generated.
              Hide
              Permalink
              Daryn Sharp added a comment -

              Test failure is unrelated.

              Show
              Daryn Sharp added a comment - Test failure is unrelated.
              Hide
              Permalink
              Owen O'Malley added a comment -

              +1

              Show
              Owen O'Malley added a comment - +1
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Hdfs-trunk-Commit #2592 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2592/)
              HADOOP-8613. AbstractDelegationTokenIdentifier#getUser() should set token auth type. (daryn) (Revision 1366440)

              Result = SUCCESS
              daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1366440
              Files :

              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenIdentifier.java
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/JspHelper.java
              Show
              Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2592 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2592/ ) HADOOP-8613 . AbstractDelegationTokenIdentifier#getUser() should set token auth type. (daryn) (Revision 1366440) Result = SUCCESS daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1366440 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenIdentifier.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/JspHelper.java
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Common-trunk-Commit #2528 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2528/)
              HADOOP-8613. AbstractDelegationTokenIdentifier#getUser() should set token auth type. (daryn) (Revision 1366440)

              Result = SUCCESS
              daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1366440
              Files :

              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenIdentifier.java
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/JspHelper.java
              Show
              Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2528 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2528/ ) HADOOP-8613 . AbstractDelegationTokenIdentifier#getUser() should set token auth type. (daryn) (Revision 1366440) Result = SUCCESS daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1366440 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenIdentifier.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/JspHelper.java
              Hide
              Permalink
              Daryn Sharp added a comment -

              Thanks Owen! I've committed it.

              Show
              Daryn Sharp added a comment - Thanks Owen! I've committed it.
              Daryn Sharp made changes -
              Status Patch Available [ 10002 ] Resolved [ 5 ]
              Fix Version/s 1.2.0 [ 12321659 ]
              Fix Version/s 0.23.3 [ 12320059 ]
              Fix Version/s 3.0.0 [ 12320357 ]
              Fix Version/s 2.2.0-alpha [ 12322473 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Mapreduce-trunk-Commit #2548 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2548/)
              HADOOP-8613. AbstractDelegationTokenIdentifier#getUser() should set token auth type. (daryn) (Revision 1366440)

              Result = FAILURE
              daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1366440
              Files :

              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenIdentifier.java
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/JspHelper.java
              Show
              Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2548 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2548/ ) HADOOP-8613 . AbstractDelegationTokenIdentifier#getUser() should set token auth type. (daryn) (Revision 1366440) Result = FAILURE daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1366440 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenIdentifier.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/JspHelper.java
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Hdfs-0.23-Build #327 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/327/)
              svn merge -c 1366440 FIXES: HADOOP-8613. AbstractDelegationTokenIdentifier#getUser() should set token auth type. (daryn) (Revision 1366462)

              Result = SUCCESS
              daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1366462
              Files :

              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenIdentifier.java
              • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java
              • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/JspHelper.java
              Show
              Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #327 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/327/ ) svn merge -c 1366440 FIXES: HADOOP-8613 . AbstractDelegationTokenIdentifier#getUser() should set token auth type. (daryn) (Revision 1366462) Result = SUCCESS daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1366462 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenIdentifier.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/JspHelper.java
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Hdfs-trunk #1118 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1118/)
              HADOOP-8613. AbstractDelegationTokenIdentifier#getUser() should set token auth type. (daryn) (Revision 1366440)

              Result = FAILURE
              daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1366440
              Files :

              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenIdentifier.java
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/JspHelper.java
              Show
              Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1118 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1118/ ) HADOOP-8613 . AbstractDelegationTokenIdentifier#getUser() should set token auth type. (daryn) (Revision 1366440) Result = FAILURE daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1366440 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenIdentifier.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/JspHelper.java
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Mapreduce-trunk #1150 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1150/)
              HADOOP-8613. AbstractDelegationTokenIdentifier#getUser() should set token auth type. (daryn) (Revision 1366440)

              Result = FAILURE
              daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1366440
              Files :

              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenIdentifier.java
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java
              • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/JspHelper.java
              Show
              Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1150 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1150/ ) HADOOP-8613 . AbstractDelegationTokenIdentifier#getUser() should set token auth type. (daryn) (Revision 1366440) Result = FAILURE daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1366440 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenIdentifier.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/JspHelper.java
              Arun C Murthy made changes -
              Fix Version/s 3.0.0 [ 12320357 ]
              Fix Version/s 1.2.0 [ 12321659 ]
              Arun C Murthy made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Hide
              Permalink
              Matt Foley added a comment -

              added 1.2.0 to fixVersion, per CHANGES.txt and above comments

              Show
              Matt Foley added a comment - added 1.2.0 to fixVersion, per CHANGES.txt and above comments
              Matt Foley made changes -
              Fix Version/s 1.2.0 [ 12321659 ]

                People

                • Assignee:
                  Daryn Sharp
                  Reporter:
                  Daryn Sharp
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  6 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development