Hadoop Common
  1. Hadoop Common
  2. HADOOP-8563

don't package hadoop-pipes examples/bin

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.0.2-alpha
    • Component/s: build
    • Labels:
      None
    • Target Version/s:

      Description

      Let's not package hadoop-pipes examples/bin

      1. HADOOP-8563.001.patch
        0.6 kB
        Colin Patrick McCabe

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2441 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2441/)
          HADOOP-8563. don't package hadoop-pipes examples/bin (Colin Patrick McCabe via tgraves) (Revision 1357811)

          Result = SUCCESS
          tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357811
          Files :

          • /hadoop/common/trunk/hadoop-assemblies/src/main/resources/assemblies/hadoop-tools.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2441 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2441/ ) HADOOP-8563 . don't package hadoop-pipes examples/bin (Colin Patrick McCabe via tgraves) (Revision 1357811) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357811 Files : /hadoop/common/trunk/hadoop-assemblies/src/main/resources/assemblies/hadoop-tools.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2508 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2508/)
          HADOOP-8563. don't package hadoop-pipes examples/bin (Colin Patrick McCabe via tgraves) (Revision 1357811)

          Result = SUCCESS
          tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357811
          Files :

          • /hadoop/common/trunk/hadoop-assemblies/src/main/resources/assemblies/hadoop-tools.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2508 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2508/ ) HADOOP-8563 . don't package hadoop-pipes examples/bin (Colin Patrick McCabe via tgraves) (Revision 1357811) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357811 Files : /hadoop/common/trunk/hadoop-assemblies/src/main/resources/assemblies/hadoop-tools.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1128 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1128/)
          HADOOP-8563. don't package hadoop-pipes examples/bin (Colin Patrick McCabe via tgraves) (Revision 1357811)

          Result = SUCCESS
          tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357811
          Files :

          • /hadoop/common/trunk/hadoop-assemblies/src/main/resources/assemblies/hadoop-tools.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1128 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1128/ ) HADOOP-8563 . don't package hadoop-pipes examples/bin (Colin Patrick McCabe via tgraves) (Revision 1357811) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357811 Files : /hadoop/common/trunk/hadoop-assemblies/src/main/resources/assemblies/hadoop-tools.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1095 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1095/)
          HADOOP-8563. don't package hadoop-pipes examples/bin (Colin Patrick McCabe via tgraves) (Revision 1357811)

          Result = FAILURE
          tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357811
          Files :

          • /hadoop/common/trunk/hadoop-assemblies/src/main/resources/assemblies/hadoop-tools.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1095 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1095/ ) HADOOP-8563 . don't package hadoop-pipes examples/bin (Colin Patrick McCabe via tgraves) (Revision 1357811) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357811 Files : /hadoop/common/trunk/hadoop-assemblies/src/main/resources/assemblies/hadoop-tools.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2443 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2443/)
          HADOOP-8563. don't package hadoop-pipes examples/bin (Colin Patrick McCabe via tgraves) (Revision 1357811)

          Result = FAILURE
          tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357811
          Files :

          • /hadoop/common/trunk/hadoop-assemblies/src/main/resources/assemblies/hadoop-tools.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2443 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2443/ ) HADOOP-8563 . don't package hadoop-pipes examples/bin (Colin Patrick McCabe via tgraves) (Revision 1357811) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357811 Files : /hadoop/common/trunk/hadoop-assemblies/src/main/resources/assemblies/hadoop-tools.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2494 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2494/)
          HADOOP-8563. don't package hadoop-pipes examples/bin (Colin Patrick McCabe via tgraves) (Revision 1357811)

          Result = SUCCESS
          tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357811
          Files :

          • /hadoop/common/trunk/hadoop-assemblies/src/main/resources/assemblies/hadoop-tools.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2494 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2494/ ) HADOOP-8563 . don't package hadoop-pipes examples/bin (Colin Patrick McCabe via tgraves) (Revision 1357811) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357811 Files : /hadoop/common/trunk/hadoop-assemblies/src/main/resources/assemblies/hadoop-tools.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2426 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2426/)
          HADOOP-8563. don't package hadoop-pipes examples/bin (Colin Patrick McCabe via tgraves) (Revision 1357811)

          Result = SUCCESS
          tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357811
          Files :

          • /hadoop/common/trunk/hadoop-assemblies/src/main/resources/assemblies/hadoop-tools.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2426 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2426/ ) HADOOP-8563 . don't package hadoop-pipes examples/bin (Colin Patrick McCabe via tgraves) (Revision 1357811) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357811 Files : /hadoop/common/trunk/hadoop-assemblies/src/main/resources/assemblies/hadoop-tools.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Thomas Graves added a comment -

          +1 lgtm.

          Show
          Thomas Graves added a comment - +1 lgtm.
          Hide
          Thomas Graves added a comment -

          Thanks Colin, taking a look now. Sorry again for coming in so late on 8547.

          Show
          Thomas Graves added a comment - Thanks Colin, taking a look now. Sorry again for coming in so late on 8547.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12535238/HADOOP-8563.001.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-assemblies.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1171//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1171//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12535238/HADOOP-8563.001.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-assemblies. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1171//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1171//console This message is automatically generated.
          Hide
          Colin Patrick McCabe added a comment -

          The reason for removing these from the packaged distribution is that they probably are primarily useful to developers, who will have the source files anyway, not just the stuff that's packaged.

          See HADOOP-8547 for more discussion about why we should remove them (although it would be nice if new discussion happened here)

          Show
          Colin Patrick McCabe added a comment - The reason for removing these from the packaged distribution is that they probably are primarily useful to developers, who will have the source files anyway, not just the stuff that's packaged. See HADOOP-8547 for more discussion about why we should remove them (although it would be nice if new discussion happened here)

            People

            • Assignee:
              Colin Patrick McCabe
              Reporter:
              Colin Patrick McCabe
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development