Hadoop Common
  1. Hadoop Common
  2. HADOOP-8495

Update Netty to avoid leaking file descriptors during shuffle

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.23.3, 2.0.0-alpha, 3.0.0
    • Fix Version/s: 0.23.3, 2.0.2-alpha
    • Component/s: build
    • Labels:
      None

      Description

      Netty 3.2.3.Final has a known bug where writes to a closed channel do not have their futures invoked. See Netty-374. This can lead to file descriptor leaks during shuffle as noted in MAPREDUCE-4298.

        Issue Links

          Activity

          Hide
          Jason Lowe added a comment -

          Patch to update the Netty dependency to 3.2.4.Final which has the fix for NETTY-374. Manually tested with the issue described in MAPREDUCE-4298 to verify file descriptors are no longer leaked when I/O errors occur on the channel.

          Show
          Jason Lowe added a comment - Patch to update the Netty dependency to 3.2.4.Final which has the fix for NETTY-374 . Manually tested with the issue described in MAPREDUCE-4298 to verify file descriptors are no longer leaked when I/O errors occur on the channel.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12531429/HADOOP-8495.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1100//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1100//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12531429/HADOOP-8495.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1100//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1100//console This message is automatically generated.
          Hide
          Thomas Graves added a comment -

          +1 lgtm.

          Show
          Thomas Graves added a comment - +1 lgtm.
          Hide
          Thomas Graves added a comment -

          Thanks Jason! I've committed this to trunk, branch-2, and branch-0.23.

          Show
          Thomas Graves added a comment - Thanks Jason! I've committed this to trunk, branch-2, and branch-0.23.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2436 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2436/)
          HADOOP-8495. Update Netty to avoid leaking file descriptors during shuffle (Jason Lowe via tgraves) (Revision 1351363)

          Result = SUCCESS
          tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1351363
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-project/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2436 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2436/ ) HADOOP-8495 . Update Netty to avoid leaking file descriptors during shuffle (Jason Lowe via tgraves) (Revision 1351363) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1351363 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-project/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2364 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2364/)
          HADOOP-8495. Update Netty to avoid leaking file descriptors during shuffle (Jason Lowe via tgraves) (Revision 1351363)

          Result = SUCCESS
          tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1351363
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-project/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2364 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2364/ ) HADOOP-8495 . Update Netty to avoid leaking file descriptors during shuffle (Jason Lowe via tgraves) (Revision 1351363) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1351363 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-project/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2384 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2384/)
          HADOOP-8495. Update Netty to avoid leaking file descriptors during shuffle (Jason Lowe via tgraves) (Revision 1351363)

          Result = FAILURE
          tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1351363
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-project/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2384 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2384/ ) HADOOP-8495 . Update Netty to avoid leaking file descriptors during shuffle (Jason Lowe via tgraves) (Revision 1351363) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1351363 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-project/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1081 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1081/)
          HADOOP-8495. Update Netty to avoid leaking file descriptors during shuffle (Jason Lowe via tgraves) (Revision 1351363)

          Result = FAILURE
          tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1351363
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-project/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1081 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1081/ ) HADOOP-8495 . Update Netty to avoid leaking file descriptors during shuffle (Jason Lowe via tgraves) (Revision 1351363) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1351363 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-project/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #291 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/291/)
          merge -r 1351363:1351364 from branch-2. FIXES: HADOOP-8495 (Revision 1351365)

          Result = SUCCESS
          tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1351365
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-project/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #291 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/291/ ) merge -r 1351363:1351364 from branch-2. FIXES: HADOOP-8495 (Revision 1351365) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1351365 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-project/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1114 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1114/)
          HADOOP-8495. Update Netty to avoid leaking file descriptors during shuffle (Jason Lowe via tgraves) (Revision 1351363)

          Result = FAILURE
          tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1351363
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-project/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1114 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1114/ ) HADOOP-8495 . Update Netty to avoid leaking file descriptors during shuffle (Jason Lowe via tgraves) (Revision 1351363) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1351363 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-project/pom.xml

            People

            • Assignee:
              Jason Lowe
              Reporter:
              Jason Lowe
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development