Hadoop Common
  1. Hadoop Common
  2. HADOOP-8488

test-patch.sh gives +1 even if the native build fails.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.2-alpha
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      It seems that Jenkins doesn't fail the build if the native part of the build doesn't succeed. This should be fixed!

      1. HADOOP-8488.001.patch
        0.8 kB
        Colin Patrick McCabe

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          19h 10m 1 Colin Patrick McCabe 07/Jun/12 19:25
          Patch Available Patch Available Resolved Resolved
          6h 21m 1 Eli Collins 08/Jun/12 01:46
          Resolved Resolved Closed Closed
          125d 16h 58m 1 Arun C Murthy 11/Oct/12 18:45
          Chris Nauroth made changes -
          Link This issue is related to HADOOP-8933 [ HADOOP-8933 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Arun C Murthy made changes -
          Fix Version/s 2.0.2-alpha [ 12322473 ]
          Fix Version/s 2.1.0-alpha [ 12321441 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1104 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1104/)
          HADOOP-8488. test-patch.sh gives +1 even if the native build fails. Contributed by Colin Patrick McCabe (Revision 1347846)

          Result = FAILURE
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347846
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1104 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1104/ ) HADOOP-8488 . test-patch.sh gives +1 even if the native build fails. Contributed by Colin Patrick McCabe (Revision 1347846) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347846 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1071 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1071/)
          HADOOP-8488. test-patch.sh gives +1 even if the native build fails. Contributed by Colin Patrick McCabe (Revision 1347846)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347846
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1071 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1071/ ) HADOOP-8488 . test-patch.sh gives +1 even if the native build fails. Contributed by Colin Patrick McCabe (Revision 1347846) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347846 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2407 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2407/)
          HADOOP-8488. test-patch.sh gives +1 even if the native build fails. Contributed by Colin Patrick McCabe (Revision 1347846)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347846
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2407 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2407/ ) HADOOP-8488 . test-patch.sh gives +1 even if the native build fails. Contributed by Colin Patrick McCabe (Revision 1347846) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347846 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2334 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2334/)
          HADOOP-8488. test-patch.sh gives +1 even if the native build fails. Contributed by Colin Patrick McCabe (Revision 1347846)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347846
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2334 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2334/ ) HADOOP-8488 . test-patch.sh gives +1 even if the native build fails. Contributed by Colin Patrick McCabe (Revision 1347846) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347846 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2353 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2353/)
          HADOOP-8488. test-patch.sh gives +1 even if the native build fails. Contributed by Colin Patrick McCabe (Revision 1347846)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347846
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2353 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2353/ ) HADOOP-8488 . test-patch.sh gives +1 even if the native build fails. Contributed by Colin Patrick McCabe (Revision 1347846) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347846 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Eli Collins made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Fix Version/s 2.0.1-alpha [ 12321441 ]
          Resolution Fixed [ 1 ]
          Hide
          Eli Collins added a comment -

          I've committed this and merged to branch-2. Thanks Colin.

          Show
          Eli Collins added a comment - I've committed this and merged to branch-2. Thanks Colin.
          Hide
          Eli Collins added a comment -

          +1 looks good

          Show
          Eli Collins added a comment - +1 looks good
          Colin Patrick McCabe made changes -
          Description It would be nice if Jenkins would compile with mvn compile -Pnative or a similar command line.

          Currently, we don't seem to build the native code at all when testing patches. Unfortunately, this allows patches that break the native parts of the build to go in without the usual testing.

          It's true that the Jenkins build would not catch all native code issues (it only compiles in one environment, and there may be #ifdefs). However, some testing is sure better than none. I believe with cmake the performance overhead of -Pnative should be very minimal.

          This would also allow us to run the junit tests which depend on native code, and the raw native unit tests in Jenkins.
          It seems that Jenkins doesn't fail the build if the native part of the build doesn't succeed. This should be fixed!
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12531282/HADOOP-8488.001.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1093//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1093//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12531282/HADOOP-8488.001.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1093//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1093//console This message is automatically generated.
          Colin Patrick McCabe made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Assignee Colin Patrick McCabe [ cmccabe ]
          Colin Patrick McCabe made changes -
          Attachment HADOOP-8488.001.patch [ 12531282 ]
          Colin Patrick McCabe made changes -
          Summary when Jenkins tests a patch, it should compile with -Pnative test-patch.sh gives +1 even if the native build fails.
          Issue Type Improvement [ 4 ] Bug [ 1 ]
          Hide
          Colin Patrick McCabe added a comment -

          Sorry if my comment was confusingly worded (too many negatives?). I meant "we use -fn to make sure we run all tests if possible"

          Show
          Colin Patrick McCabe added a comment - Sorry if my comment was confusingly worded (too many negatives?). I meant "we use -fn to make sure we run all tests if possible"
          Hide
          Colin Patrick McCabe added a comment -

          It looks like test-patch.sh is running maven with -fn (fail-never), because otherwise maven stops running as soon as the first test fails. This could lead to not getting a full list of test failures.

          I wonder if it would be possible to use -fae, (fail-at-end). The documentation says "Only fail the build afterwards; allow all non-impacted builds to continue."

          Manually grepping for failure strings seems very brittle-- I would like to avoid it if at all possible and let maven itself tell us what is wrong.

          Show
          Colin Patrick McCabe added a comment - It looks like test-patch.sh is running maven with -fn (fail-never), because otherwise maven stops running as soon as the first test fails. This could lead to not getting a full list of test failures. I wonder if it would be possible to use -fae, (fail-at-end). The documentation says "Only fail the build afterwards; allow all non-impacted builds to continue." Manually grepping for failure strings seems very brittle-- I would like to avoid it if at all possible and let maven itself tell us what is wrong.
          Colin Patrick McCabe made changes -
          Link This issue is related to HADOOP-8147 [ HADOOP-8147 ]
          Hide
          Eli Collins added a comment -

          I believe it does, see ./dev-support/test-patch.sh. Perhaps it's running and the errors are getting ignored.

          Show
          Eli Collins added a comment - I believe it does, see ./dev-support/test-patch.sh. Perhaps it's running and the errors are getting ignored.
          Colin Patrick McCabe made changes -
          Link This issue relates to HADOOP-8368 [ HADOOP-8368 ]
          Colin Patrick McCabe made changes -
          Field Original Value New Value
          Link This issue is duplicated by INFRA-4886 [ INFRA-4886 ]
          Colin Patrick McCabe created issue -

            People

            • Assignee:
              Colin Patrick McCabe
              Reporter:
              Colin Patrick McCabe
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development