Hadoop Common
  1. Hadoop Common
  2. HADOOP-8488

test-patch.sh gives +1 even if the native build fails.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.2-alpha
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      It seems that Jenkins doesn't fail the build if the native part of the build doesn't succeed. This should be fixed!

      1. HADOOP-8488.001.patch
        0.8 kB
        Colin Patrick McCabe

        Issue Links

          Activity

          Hide
          Eli Collins added a comment -

          I believe it does, see ./dev-support/test-patch.sh. Perhaps it's running and the errors are getting ignored.

          Show
          Eli Collins added a comment - I believe it does, see ./dev-support/test-patch.sh. Perhaps it's running and the errors are getting ignored.
          Hide
          Colin Patrick McCabe added a comment -

          It looks like test-patch.sh is running maven with -fn (fail-never), because otherwise maven stops running as soon as the first test fails. This could lead to not getting a full list of test failures.

          I wonder if it would be possible to use -fae, (fail-at-end). The documentation says "Only fail the build afterwards; allow all non-impacted builds to continue."

          Manually grepping for failure strings seems very brittle-- I would like to avoid it if at all possible and let maven itself tell us what is wrong.

          Show
          Colin Patrick McCabe added a comment - It looks like test-patch.sh is running maven with -fn (fail-never), because otherwise maven stops running as soon as the first test fails. This could lead to not getting a full list of test failures. I wonder if it would be possible to use -fae, (fail-at-end). The documentation says "Only fail the build afterwards; allow all non-impacted builds to continue." Manually grepping for failure strings seems very brittle-- I would like to avoid it if at all possible and let maven itself tell us what is wrong.
          Hide
          Colin Patrick McCabe added a comment -

          Sorry if my comment was confusingly worded (too many negatives?). I meant "we use -fn to make sure we run all tests if possible"

          Show
          Colin Patrick McCabe added a comment - Sorry if my comment was confusingly worded (too many negatives?). I meant "we use -fn to make sure we run all tests if possible"
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12531282/HADOOP-8488.001.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1093//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1093//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12531282/HADOOP-8488.001.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1093//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1093//console This message is automatically generated.
          Hide
          Eli Collins added a comment -

          +1 looks good

          Show
          Eli Collins added a comment - +1 looks good
          Hide
          Eli Collins added a comment -

          I've committed this and merged to branch-2. Thanks Colin.

          Show
          Eli Collins added a comment - I've committed this and merged to branch-2. Thanks Colin.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2353 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2353/)
          HADOOP-8488. test-patch.sh gives +1 even if the native build fails. Contributed by Colin Patrick McCabe (Revision 1347846)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347846
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2353 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2353/ ) HADOOP-8488 . test-patch.sh gives +1 even if the native build fails. Contributed by Colin Patrick McCabe (Revision 1347846) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347846 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2334 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2334/)
          HADOOP-8488. test-patch.sh gives +1 even if the native build fails. Contributed by Colin Patrick McCabe (Revision 1347846)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347846
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2334 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2334/ ) HADOOP-8488 . test-patch.sh gives +1 even if the native build fails. Contributed by Colin Patrick McCabe (Revision 1347846) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347846 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2407 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2407/)
          HADOOP-8488. test-patch.sh gives +1 even if the native build fails. Contributed by Colin Patrick McCabe (Revision 1347846)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347846
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2407 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2407/ ) HADOOP-8488 . test-patch.sh gives +1 even if the native build fails. Contributed by Colin Patrick McCabe (Revision 1347846) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347846 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1071 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1071/)
          HADOOP-8488. test-patch.sh gives +1 even if the native build fails. Contributed by Colin Patrick McCabe (Revision 1347846)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347846
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1071 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1071/ ) HADOOP-8488 . test-patch.sh gives +1 even if the native build fails. Contributed by Colin Patrick McCabe (Revision 1347846) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347846 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1104 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1104/)
          HADOOP-8488. test-patch.sh gives +1 even if the native build fails. Contributed by Colin Patrick McCabe (Revision 1347846)

          Result = FAILURE
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347846
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1104 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1104/ ) HADOOP-8488 . test-patch.sh gives +1 even if the native build fails. Contributed by Colin Patrick McCabe (Revision 1347846) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347846 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

            People

            • Assignee:
              Colin Patrick McCabe
              Reporter:
              Colin Patrick McCabe
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development