Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 0.23.3, 2.0.2-alpha
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      runAs is a binary in the hadoop-common project. It seems to allow you to run a hadoop daemon as another user. However, it requires setuid privileges in order to do this.

      • Do we still need this binary? Who is using it and are there better solutions out there? My understanding is that setuid binaries are something we generally try to avoid.
      • If we do need it, can we add some documentation about it somewhere?
      • Should this binary be in the src/test directory? It doesn't seem to be testing anything.

      Hopefully that covers everything...

      1. hadoop-8450.txt
        642 kB
        Eli Collins

        Issue Links

          Activity

          Hide
          Todd Lipcon added a comment -

          AFAIK this was part of Herriot, which I don't think runs anymore with trunk. Given it lacks an active maintainer and I'm not aware of anyone using it, I think we should remove src/test/system.

          Show
          Todd Lipcon added a comment - AFAIK this was part of Herriot, which I don't think runs anymore with trunk. Given it lacks an active maintainer and I'm not aware of anyone using it, I think we should remove src/test/system.
          Hide
          Eli Collins added a comment -

          Agree. Doesn't build or run on trunk or branch-2. Let's remove it.

          Show
          Eli Collins added a comment - Agree. Doesn't build or run on trunk or branch-2. Let's remove it.
          Hide
          Eli Collins added a comment -

          Patch attached (generated by svn remove of the various src/test/system directories).

          Show
          Eli Collins added a comment - Patch attached (generated by svn remove of the various src/test/system directories).
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12530663/hadoop-8450.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 111 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1073//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1073//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12530663/hadoop-8450.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 111 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1073//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1073//console This message is automatically generated.
          Hide
          Aaron T. Myers added a comment -

          +1. When you do the commit, please actually use `svn rm' so that the svn history looks good.

          Show
          Aaron T. Myers added a comment - +1. When you do the commit, please actually use `svn rm' so that the svn history looks good.
          Hide
          Eli Collins added a comment -

          I've committed this (via svn rm) on trunk and branch-2. Thanks for the review ATM.

          Show
          Eli Collins added a comment - I've committed this (via svn rm) on trunk and branch-2. Thanks for the review ATM.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2388 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2388/)
          HADOOP-8450. Remove src/test/system. Contributed by Eli Collins (Revision 1345794)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1345794
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/system
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/system
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/test/system
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/system
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2388 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2388/ ) HADOOP-8450 . Remove src/test/system. Contributed by Eli Collins (Revision 1345794) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1345794 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/system /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/system /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/test/system /hadoop/common/trunk/hadoop-mapreduce-project/src/test/system
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2316 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2316/)
          HADOOP-8450. Remove src/test/system. Contributed by Eli Collins (Revision 1345794)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1345794
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/system
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/system
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/test/system
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/system
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2316 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2316/ ) HADOOP-8450 . Remove src/test/system. Contributed by Eli Collins (Revision 1345794) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1345794 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/system /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/system /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/test/system /hadoop/common/trunk/hadoop-mapreduce-project/src/test/system
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2334 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2334/)
          HADOOP-8450. Remove src/test/system. Contributed by Eli Collins (Revision 1345794)

          Result = FAILURE
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1345794
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/system
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/system
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/test/system
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/system
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2334 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2334/ ) HADOOP-8450 . Remove src/test/system. Contributed by Eli Collins (Revision 1345794) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1345794 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/system /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/system /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/test/system /hadoop/common/trunk/hadoop-mapreduce-project/src/test/system
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1066 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1066/)
          HADOOP-8450. Remove src/test/system. Contributed by Eli Collins (Revision 1345794)

          Result = FAILURE
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1345794
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/system
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/system
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/test/system
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/system
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1066 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1066/ ) HADOOP-8450 . Remove src/test/system. Contributed by Eli Collins (Revision 1345794) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1345794 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/system /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/system /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/test/system /hadoop/common/trunk/hadoop-mapreduce-project/src/test/system
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1100 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1100/)
          HADOOP-8450. Remove src/test/system. Contributed by Eli Collins (Revision 1345794)

          Result = FAILURE
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1345794
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/system
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/system
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/test/system
          • /hadoop/common/trunk/hadoop-mapreduce-project/src/test/system
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1100 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1100/ ) HADOOP-8450 . Remove src/test/system. Contributed by Eli Collins (Revision 1345794) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1345794 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/system /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/system /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/gridmix/src/test/system /hadoop/common/trunk/hadoop-mapreduce-project/src/test/system
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #304 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/304/)
          svn merge -c 1345794 FIXES: HADOOP-8450. Remove src/test/system. (eli) (Revision 1356896)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356896
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/system
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/system
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/test/system
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/system
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #304 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/304/ ) svn merge -c 1345794 FIXES: HADOOP-8450 . Remove src/test/system. (eli) (Revision 1356896) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356896 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/system /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/system /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/gridmix/src/test/system /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/system

            People

            • Assignee:
              Eli Collins
              Reporter:
              Colin Patrick McCabe
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development