Hadoop Common
  1. Hadoop Common
  2. HADOOP-8430

Backport new FileSystem methods introduced by HADOOP-8014 to branch-1

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1.0
    • Component/s: None
    • Labels:
      None

      Description

      Per HADOOP-8422 let's backport the new FileSystem methods from HADOOP-8014 to branch-1 so users can transition over in Hadoop 1.x releases, which helps upstream projects like HBase work against federation (see HBASE-6067).

        Issue Links

          Activity

          Hide
          Eli Collins added a comment -

          Patch attached. test patch output coming.

          Show
          Eli Collins added a comment - Patch attached. test patch output coming.
          Hide
          Eli Collins added a comment -

          Forgot to mention, this patch both introduces the new methods and per HADOOP-8422 deprecates the ones that don't take a path to help people transition from Hadoop 1.x.

          Show
          Eli Collins added a comment - Forgot to mention, this patch both introduces the new methods and per HADOOP-8422 deprecates the ones that don't take a path to help people transition from Hadoop 1.x.
          Hide
          Eli Collins added a comment -
               [exec] 
               [exec] -1 overall.  
               [exec] 
               [exec]     +1 @author.  The patch does not contain any @author tags.
               [exec] 
               [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
               [exec]                         Please justify why no tests are needed for this patch.
               [exec] 
               [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
               [exec] 
               [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
               [exec] 
               [exec]     -1 findbugs.  The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings.
               [exec] 
               [exec] 
          

          Findbugs warnings are HADOOP-7847. The new method just calls the old one so no new test is necessary.

          Show
          Eli Collins added a comment - [exec] [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings. [exec] [exec] Findbugs warnings are HADOOP-7847 . The new method just calls the old one so no new test is necessary.
          Hide
          Daryn Sharp added a comment -

          Looks good, but you should include the path based version getServerDefaults too.

          Show
          Daryn Sharp added a comment - Looks good, but you should include the path based version getServerDefaults too.
          Hide
          Eli Collins added a comment -

          getServerDefaults doesn't exist in branch-1, was introduced in 21 via HADOOP-6235 and not backported so we're good there.

          Show
          Eli Collins added a comment - getServerDefaults doesn't exist in branch-1, was introduced in 21 via HADOOP-6235 and not backported so we're good there.
          Hide
          Daryn Sharp added a comment -

          In that case, +1!

          Show
          Daryn Sharp added a comment - In that case, +1!
          Hide
          Eli Collins added a comment -

          Thanks Daryn. I've committed this to branch-1 and merged to branch-1.1

          Show
          Eli Collins added a comment - Thanks Daryn. I've committed this to branch-1 and merged to branch-1.1
          Hide
          Matt Foley added a comment -

          Closed upon release of Hadoop-1.1.0.

          Show
          Matt Foley added a comment - Closed upon release of Hadoop-1.1.0.

            People

            • Assignee:
              Eli Collins
              Reporter:
              Eli Collins
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development