Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-8413

test-patch.sh gives out the wrong links for newPatchFindbugsWarnings

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: precommit
    • Labels:
      None

      Description

      For some reason, test-patch.sh seems to be printing out incorrect links these days to the findbugswarnings html files that it generates.

      You can still access the findbugs warnings HTML files, if you manually enter the right address into your web browser.

      However, the HTML it outputs looks like this:

      Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/2449//artifact/trunk/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
      

      Notice the two "trunk" path components in a row.

      1. HADOOP-8413.002.patch
        0.7 kB
        Colin P. McCabe

        Activity

        Hide
        cmccabe Colin P. McCabe added a comment -

        You can see this in action at HDFS-3049, where the links to findbugswarnings.html are always incorrect.

        Show
        cmccabe Colin P. McCabe added a comment - You can see this in action at HDFS-3049 , where the links to findbugswarnings.html are always incorrect.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12528184/HADOOP-8413.002.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1012//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1012//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12528184/HADOOP-8413.002.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 javadoc. The javadoc tool appears to have generated 2 warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1012//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1012//console This message is automatically generated.
        Hide
        revans2 Robert Joseph Evans added a comment -

        The changes look good to me +1. I put this into trunk

        Show
        revans2 Robert Joseph Evans added a comment - The changes look good to me +1. I put this into trunk
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2276 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2276/)
        HADOOP-8413. test-patch.sh gives out the wrong links for newPatchFindbugsWarnings (Colin Patrick McCabe via bobby) (Revision 1341113)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1341113
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2276 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2276/ ) HADOOP-8413 . test-patch.sh gives out the wrong links for newPatchFindbugsWarnings (Colin Patrick McCabe via bobby) (Revision 1341113) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1341113 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2349 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2349/)
        HADOOP-8413. test-patch.sh gives out the wrong links for newPatchFindbugsWarnings (Colin Patrick McCabe via bobby) (Revision 1341113)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1341113
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2349 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2349/ ) HADOOP-8413 . test-patch.sh gives out the wrong links for newPatchFindbugsWarnings (Colin Patrick McCabe via bobby) (Revision 1341113) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1341113 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2294 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2294/)
        HADOOP-8413. test-patch.sh gives out the wrong links for newPatchFindbugsWarnings (Colin Patrick McCabe via bobby) (Revision 1341113)

        Result = FAILURE
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1341113
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2294 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2294/ ) HADOOP-8413 . test-patch.sh gives out the wrong links for newPatchFindbugsWarnings (Colin Patrick McCabe via bobby) (Revision 1341113) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1341113 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1053 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1053/)
        HADOOP-8413. test-patch.sh gives out the wrong links for newPatchFindbugsWarnings (Colin Patrick McCabe via bobby) (Revision 1341113)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1341113
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1053 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1053/ ) HADOOP-8413 . test-patch.sh gives out the wrong links for newPatchFindbugsWarnings (Colin Patrick McCabe via bobby) (Revision 1341113) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1341113 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1087 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1087/)
        HADOOP-8413. test-patch.sh gives out the wrong links for newPatchFindbugsWarnings (Colin Patrick McCabe via bobby) (Revision 1341113)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1341113
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1087 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1087/ ) HADOOP-8413 . test-patch.sh gives out the wrong links for newPatchFindbugsWarnings (Colin Patrick McCabe via bobby) (Revision 1341113) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1341113 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

          People

          • Assignee:
            cmccabe Colin P. McCabe
            Reporter:
            cmccabe Colin P. McCabe
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development