Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.0.2-alpha
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Minor BlockLocation cleanup. Remove dead imports, cleanup some incorrect comment and write a better javadoc.

        Activity

        Hide
        Eli Collins added a comment -

        Patch attached.

        Show
        Eli Collins added a comment - Patch attached.
        Hide
        John George added a comment -

        +1 seems pretty straightforward.

        Show
        John George added a comment - +1 seems pretty straightforward.
        Hide
        Todd Lipcon added a comment -

        One typo:

        + private long offset; // Offset of the of the block in the file

        Show
        Todd Lipcon added a comment - One typo: + private long offset; // Offset of the of the block in the file
        Hide
        Eli Collins added a comment -

        Thanks guys, I'll update the patch with the following. Todd, you're +1?

        diff --git hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/f
        index 95149f4..cfe9ee8 100644
        --- hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Block
        +++ hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Block
        @@ -33,7 +33,7 @@ public class BlockLocation {
           private String[] topologyPaths; // Full path name in network topology
        -  private long offset;  // Offset of the of the block in the file
        +  private long offset;  // Offset of the block in the file
        
        Show
        Eli Collins added a comment - Thanks guys, I'll update the patch with the following. Todd, you're +1? diff --git hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/f index 95149f4..cfe9ee8 100644 --- hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Block +++ hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Block @@ -33,7 +33,7 @@ public class BlockLocation { private String [] topologyPaths; // Full path name in network topology - private long offset; // Offset of the of the block in the file + private long offset; // Offset of the block in the file
        Hide
        Eli Collins added a comment -

        I've committed this to trunk and merged to branch-2. Thanks John and Todd.

        Show
        Eli Collins added a comment - I've committed this to trunk and merged to branch-2. Thanks John and Todd.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2321 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2321/)
        HADOOP-8398. Cleanup BlockLocation. Contributed by Eli Collins (Revision 1338806)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1338806
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/BlockLocation.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/Node.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NodeBase.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2321 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2321/ ) HADOOP-8398 . Cleanup BlockLocation. Contributed by Eli Collins (Revision 1338806) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1338806 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/BlockLocation.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/Node.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NodeBase.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2247 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2247/)
        HADOOP-8398. Cleanup BlockLocation. Contributed by Eli Collins (Revision 1338806)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1338806
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/BlockLocation.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/Node.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NodeBase.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2247 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2247/ ) HADOOP-8398 . Cleanup BlockLocation. Contributed by Eli Collins (Revision 1338806) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1338806 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/BlockLocation.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/Node.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NodeBase.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1045 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1045/)
        HADOOP-8398. Cleanup BlockLocation. Contributed by Eli Collins (Revision 1338806)

        Result = FAILURE
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1338806
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/BlockLocation.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/Node.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NodeBase.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1045 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1045/ ) HADOOP-8398 . Cleanup BlockLocation. Contributed by Eli Collins (Revision 1338806) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1338806 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/BlockLocation.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/Node.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NodeBase.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1081 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1081/)
        HADOOP-8398. Cleanup BlockLocation. Contributed by Eli Collins (Revision 1338806)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1338806
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/BlockLocation.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/Node.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NodeBase.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1081 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1081/ ) HADOOP-8398 . Cleanup BlockLocation. Contributed by Eli Collins (Revision 1338806) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1338806 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/BlockLocation.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/Node.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NodeBase.java

          People

          • Assignee:
            Eli Collins
            Reporter:
            Eli Collins
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development