Hadoop Common
  1. Hadoop Common
  2. HADOOP-8375

test-patch should stop immediately once it has found compilation errors

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0
    • Component/s: build
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      It does not makes sense to run findbugs or javadoc check if the program does not compile. It was the behavior previously if I remember correctly.

      1. HADOOP-8375.txt
        0.9 kB
        Robert Joseph Evans
      2. HADOOP-8375.txt
        1.0 kB
        Robert Joseph Evans

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1076 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1076/)
        HADOOP-8375. test-patch should stop immediately once it has found compilation errors (bobby) (Revision 1336887)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336887
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1076 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1076/ ) HADOOP-8375 . test-patch should stop immediately once it has found compilation errors (bobby) (Revision 1336887) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336887 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1040 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1040/)
        HADOOP-8375. test-patch should stop immediately once it has found compilation errors (bobby) (Revision 1336887)

        Result = FAILURE
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336887
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1040 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1040/ ) HADOOP-8375 . test-patch should stop immediately once it has found compilation errors (bobby) (Revision 1336887) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336887 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2223 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2223/)
        HADOOP-8375. test-patch should stop immediately once it has found compilation errors (bobby) (Revision 1336887)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336887
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2223 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2223/ ) HADOOP-8375 . test-patch should stop immediately once it has found compilation errors (bobby) (Revision 1336887) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336887 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2298 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2298/)
        HADOOP-8375. test-patch should stop immediately once it has found compilation errors (bobby) (Revision 1336887)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336887
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2298 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2298/ ) HADOOP-8375 . test-patch should stop immediately once it has found compilation errors (bobby) (Revision 1336887) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336887 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2240 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2240/)
        HADOOP-8375. test-patch should stop immediately once it has found compilation errors (bobby) (Revision 1336887)

        Result = ABORTED
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336887
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2240 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2240/ ) HADOOP-8375 . test-patch should stop immediately once it has found compilation errors (bobby) (Revision 1336887) Result = ABORTED bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336887 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12526379/HADOOP-8375.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/979//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/979//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12526379/HADOOP-8375.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/979//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/979//console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 patch looks good. Thanks a lot!

        Show
        Tsz Wo Nicholas Sze added a comment - +1 patch looks good. Thanks a lot!
        Hide
        Robert Joseph Evans added a comment -

        Javadocs check after javac check.

        Show
        Robert Joseph Evans added a comment - Javadocs check after javac check.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        How about we also move the javadoc check after javac?

        @@ -903,7 +903,12 @@
         checkJavadocWarnings
         (( RESULT = RESULT + $? ))
         checkJavacWarnings
        -(( RESULT = RESULT + $? ))
        +JAVAC_RET=$?
        ...
        
        Show
        Tsz Wo Nicholas Sze added a comment - How about we also move the javadoc check after javac? @@ -903,7 +903,12 @@ checkJavadocWarnings (( RESULT = RESULT + $? )) checkJavacWarnings -(( RESULT = RESULT + $? )) +JAVAC_RET=$? ...
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12526217/HADOOP-8375.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/970//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/970//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12526217/HADOOP-8375.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/970//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/970//console This message is automatically generated.
        Hide
        Robert Joseph Evans added a comment -

        It is a bit ugly, and I can clean it up if need be, but it works.

        Show
        Robert Joseph Evans added a comment - It is a bit ugly, and I can clean it up if need be, but it works.

          People

          • Assignee:
            Robert Joseph Evans
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development