Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-8359

Clear up javadoc warnings in hadoop-common-project

Details

    • Task
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 2.0.0-alpha
    • 2.0.0-alpha
    • conf
    • None

    Description

      Javadocs added in HADOOP-8172 has introduced two new javadoc warnings. Should be easy to fix these (just missing #s for method refs).

      [WARNING] Javadoc Warnings
      [WARNING] /Users/harshchouraria/Work/code/apache/hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java:334: warning - Tag @link: missing '#': "addDeprecation(String key, String newKey)"
      [WARNING] /Users/harshchouraria/Work/code/apache/hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java:285: warning - Tag @link: missing '#': "addDeprecation(String key, String newKey,
      [WARNING] String customMessage)"
      

      Attachments

        1. HADOOP-8359-branch-2.patch
          1 kB
          Anupam Seth

        Activity

          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12525904/HADOOP-8359-branch-2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/953//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/953//console

          This message is automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525904/HADOOP-8359-branch-2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/953//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/953//console This message is automatically generated.
          szetszwo Tsz-wo Sze added a comment -

          +1 patch looks good.

          szetszwo Tsz-wo Sze added a comment - +1 patch looks good.
          szetszwo Tsz-wo Sze added a comment -

          I have committed this. Thanks, Anupam!

          szetszwo Tsz-wo Sze added a comment - I have committed this. Thanks, Anupam!
          hudson Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2275 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2275/)
          HADOOP-8359. Fix javadoc warnings in Configuration. Contributed by Anupam Seth (Revision 1335258)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335258
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2275 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2275/ ) HADOOP-8359 . Fix javadoc warnings in Configuration. Contributed by Anupam Seth (Revision 1335258) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335258 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          hudson Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2200 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2200/)
          HADOOP-8359. Fix javadoc warnings in Configuration. Contributed by Anupam Seth (Revision 1335258)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335258
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          hudson Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2200 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2200/ ) HADOOP-8359 . Fix javadoc warnings in Configuration. Contributed by Anupam Seth (Revision 1335258) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335258 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          hudson Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2217 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2217/)
          HADOOP-8359. Fix javadoc warnings in Configuration. Contributed by Anupam Seth (Revision 1335258)

          Result = ABORTED
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335258
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2217 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2217/ ) HADOOP-8359 . Fix javadoc warnings in Configuration. Contributed by Anupam Seth (Revision 1335258) Result = ABORTED szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335258 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          hudson Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1038 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1038/)
          HADOOP-8359. Fix javadoc warnings in Configuration. Contributed by Anupam Seth (Revision 1335258)

          Result = FAILURE
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335258
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1038 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1038/ ) HADOOP-8359 . Fix javadoc warnings in Configuration. Contributed by Anupam Seth (Revision 1335258) Result = FAILURE szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335258 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          hudson Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1073 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1073/)
          HADOOP-8359. Fix javadoc warnings in Configuration. Contributed by Anupam Seth (Revision 1335258)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335258
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1073 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1073/ ) HADOOP-8359 . Fix javadoc warnings in Configuration. Contributed by Anupam Seth (Revision 1335258) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335258 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          qwertymaniac Harsh J added a comment -

          Thanks Nicholas and Anupam!

          qwertymaniac Harsh J added a comment - Thanks Nicholas and Anupam!

          People

            anupamseth Anupam Seth
            qwertymaniac Harsh J
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: