[HADOOP-8270] hadoop-daemon.sh stop action should return 0 for an already stopped service

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.23.1
• Fix Version/s: 2.0.0-alpha
• Component/s: scripts
• Hadoop Flags: Incompatible change, Reviewed
• Release Note: The daemon stop action no longer returns failure when stopping an already stopped service.
• Assignee: Roman Shaposhnik
• Reporter: Roman Shaposhnik
• Created: 11/Apr/12 23:18
• Updated: 23/May/12 20:15
• Resolved: 12/Apr/12 00:00

Description

The following bit of code from hadoop-daemon.sh is not LSB compliant, since
according to http://refspecs.linuxbase.org/LSB_3.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html
a stop action on an already stopped service should return 0.

 (stop)

    if [ -f $pid ]; then
      if kill -0 `cat $pid` > /dev/null 2>&1; then
        echo stopping $command
        kill `cat $pid`
      else
        echo no $command to stop
        exit 1
      fi
    else
      echo no $command to stop
      exit 1
    fi
    ;;