Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-8257

Auto-HA: TestZKFailoverControllerStress occasionally fails with Mockito error

    Details

      Description

      Once in a while I've seen the following in TestZKFailoverControllerStress:

      Unfinished stubbing detected here: -> at org.apache.hadoop.ha.TestZKFailoverControllerStress.testRandomHealthAndDisconnects(TestZKFailoverControllerStress.java:118) E.g. thenReturn() may be missing....

      This is because we set up the mock answers after starting the ZKFCs. So if the ZKFC calls the mock object while it's in the middle of the setup, this exception occurs.

        Activity

        Hide
        tlipcon Todd Lipcon added a comment -

        This patch to the test should fix the issue.

        Show
        tlipcon Todd Lipcon added a comment - This patch to the test should fix the issue.
        Hide
        eli2 Eli Collins added a comment -

        +1 pending jenkins, good catch

        Show
        eli2 Eli Collins added a comment - +1 pending jenkins, good catch
        Hide
        tlipcon Todd Lipcon added a comment -

        Jenkins won't run on this since it's on a branch. I verified by changing the test runtime to 3 seconds and looping it. Without the patch, it failed with the mockito error after 3 or 4 minutes. I then looped with the patch for 15 minutes without a failure.

        Show
        tlipcon Todd Lipcon added a comment - Jenkins won't run on this since it's on a branch. I verified by changing the test runtime to 3 seconds and looping it. Without the patch, it failed with the mockito error after 3 or 4 minutes. I then looped with the patch for 15 minutes without a failure.

          People

          • Assignee:
            tlipcon Todd Lipcon
            Reporter:
            tlipcon Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development