Hadoop Common
  1. Hadoop Common
  2. HADOOP-8184

ProtoBuf RPC engine does not need it own reply packet - it can use the IPC layer reply packet.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.0.0-alpha
    • Component/s: ipc
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      This change will affect the output of errors for some Hadoop CLI commands. Specifically, the name of the exception class will no longer appear, and instead only the text of the exception message will appear.

      Issue Links

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        4m 33s 1 Sanjay Radia 19/Mar/12 17:41
        Patch Available Patch Available Resolved Resolved
        4d 49m 1 Tsz Wo Nicholas Sze 23/Mar/12 18:31
        Resolved Resolved Closed Closed
        61d 1h 44m 1 Arun C Murthy 23/May/12 21:15
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Aaron T. Myers made changes -
        Hadoop Flags Reviewed [ 10343 ] Incompatible change,Reviewed [ 10342,10343 ]
        Release Note This change will affect the output of errors for some Hadoop CLI commands. Specifically, the name of the exception class will no longer appear, and instead only the text of the exception message will appear.
        Affects Version/s 2.0.0 [ 12320352 ]
        Arun C Murthy made changes -
        Fix Version/s 2.0.0 [ 12320352 ]
        Fix Version/s 0.24.0 [ 12317652 ]
        Fix Version/s 0.23.3 [ 12320059 ]
        Hide
        Aaron T. Myers added a comment -

        It seems that there are much more examples that we did not revert.

        I haven't done a thorough survey of commits which have broken tests, so couldn't say for sure.

        Regardless, thanks for looking into it promptly! I agree there's no need to revert this patch.

        Show
        Aaron T. Myers added a comment - It seems that there are much more examples that we did not revert. I haven't done a thorough survey of commits which have broken tests, so couldn't say for sure. Regardless, thanks for looking into it promptly! I agree there's no need to revert this patch.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        > In my experience we've often done this (see HADOOP-8193 for example) ...

        It seems that there are much more examples that we did not revert. Do you agree?

        Show
        Tsz Wo Nicholas Sze added a comment - > In my experience we've often done this (see HADOOP-8193 for example) ... It seems that there are much more examples that we did not revert. Do you agree?
        Hide
        Aaron T. Myers added a comment -

        Sure, I will take a look.

        Thanks a lot!

        We usually do not revert patches because of unit test failures.

        In my experience we've often done this (see HADOOP-8193 for example) but if you'll look into it promptly then it seems fine not to.

        Show
        Aaron T. Myers added a comment - Sure, I will take a look. Thanks a lot! We usually do not revert patches because of unit test failures. In my experience we've often done this (see HADOOP-8193 for example) but if you'll look into it promptly then it seems fine not to.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Sure, I will take a look.

        > In the mean time, I suggest we revert these commits from trunk and branch-0.23 until these two tests can be fixed.

        We usually do not revert patches because of unit test failures.

        Show
        Tsz Wo Nicholas Sze added a comment - Sure, I will take a look. > In the mean time, I suggest we revert these commits from trunk and branch-0.23 until these two tests can be fixed. We usually do not revert patches because of unit test failures.
        Aaron T. Myers made changes -
        Link This issue breaks HDFS-3142 [ HDFS-3142 ]
        Aaron T. Myers made changes -
        Link This issue breaks HDFS-3143 [ HDFS-3143 ]
        Hide
        Aaron T. Myers added a comment -

        Hi Sanjay and Nicholas, this patch seems to have broken TestHDFSCLI and TestGetBlocks in HDFS, since it appears that the exception class name is no longer being sent when a remote error is encountered. Could you please look into this?

        In the mean time, I suggest we revert these commits from trunk and branch-0.23 until these two tests can be fixed.

        Show
        Aaron T. Myers added a comment - Hi Sanjay and Nicholas, this patch seems to have broken TestHDFSCLI and TestGetBlocks in HDFS, since it appears that the exception class name is no longer being sent when a remote error is encountered. Could you please look into this? In the mean time, I suggest we revert these commits from trunk and branch-0.23 until these two tests can be fixed.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1029 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1029/)
        HADOOP-8184. ProtoBuf RPC engine uses the IPC layer reply packet. Contributed by Sanjay Radia (Revision 1304542)

        Result = SUCCESS
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304542
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1029 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1029/ ) HADOOP-8184 . ProtoBuf RPC engine uses the IPC layer reply packet. Contributed by Sanjay Radia (Revision 1304542) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304542 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #235 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/235/)
        svn merge -c 1304542 from trunk for HADOOP-8184. (Revision 1304546)

        Result = FAILURE
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304546
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #235 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/235/ ) svn merge -c 1304542 from trunk for HADOOP-8184 . (Revision 1304546) Result = FAILURE szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304546 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #207 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/207/)
        svn merge -c 1304542 from trunk for HADOOP-8184. (Revision 1304546)

        Result = UNSTABLE
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304546
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #207 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/207/ ) svn merge -c 1304542 from trunk for HADOOP-8184 . (Revision 1304546) Result = UNSTABLE szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304546 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #994 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/994/)
        HADOOP-8184. ProtoBuf RPC engine uses the IPC layer reply packet. Contributed by Sanjay Radia (Revision 1304542)

        Result = FAILURE
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304542
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #994 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/994/ ) HADOOP-8184 . ProtoBuf RPC engine uses the IPC layer reply packet. Contributed by Sanjay Radia (Revision 1304542) Result = FAILURE szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304542 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #727 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/727/)
        svn merge -c 1304542 from trunk for HADOOP-8184. (Revision 1304546)

        Result = ABORTED
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304546
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #727 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/727/ ) svn merge -c 1304542 from trunk for HADOOP-8184 . (Revision 1304546) Result = ABORTED szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304546 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1929 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1929/)
        HADOOP-8184. ProtoBuf RPC engine uses the IPC layer reply packet. Contributed by Sanjay Radia (Revision 1304542)

        Result = ABORTED
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304542
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1929 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1929/ ) HADOOP-8184 . ProtoBuf RPC engine uses the IPC layer reply packet. Contributed by Sanjay Radia (Revision 1304542) Result = ABORTED szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304542 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #710 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/710/)
        svn merge -c 1304542 from trunk for HADOOP-8184. (Revision 1304546)

        Result = SUCCESS
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304546
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #710 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/710/ ) svn merge -c 1304542 from trunk for HADOOP-8184 . (Revision 1304546) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304546 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1994 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1994/)
        HADOOP-8184. ProtoBuf RPC engine uses the IPC layer reply packet. Contributed by Sanjay Radia (Revision 1304542)

        Result = SUCCESS
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304542
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1994 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1994/ ) HADOOP-8184 . ProtoBuf RPC engine uses the IPC layer reply packet. Contributed by Sanjay Radia (Revision 1304542) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304542 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1920 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1920/)
        HADOOP-8184. ProtoBuf RPC engine uses the IPC layer reply packet. Contributed by Sanjay Radia (Revision 1304542)

        Result = SUCCESS
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304542
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1920 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1920/ ) HADOOP-8184 . ProtoBuf RPC engine uses the IPC layer reply packet. Contributed by Sanjay Radia (Revision 1304542) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304542 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #719 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/719/)
        svn merge -c 1304542 from trunk for HADOOP-8184. (Revision 1304546)

        Result = SUCCESS
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304546
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #719 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/719/ ) svn merge -c 1304542 from trunk for HADOOP-8184 . (Revision 1304546) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304546 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
        Tsz Wo Nicholas Sze made changes -
        Component/s ipc [ 12310688 ]
        Tsz Wo Nicholas Sze made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 0.23.3 [ 12320059 ]
        Fix Version/s 0.24.0 [ 12317652 ]
        Resolution Fixed [ 1 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Thanks Suresh for the review.

        I have committed this. Thanks, Sanjay!

        Show
        Tsz Wo Nicholas Sze added a comment - Thanks Suresh for the review. I have committed this. Thanks, Sanjay!
        Hide
        Suresh Srinivas added a comment -

        Sanjay, thanks for cleaning this up. This needs to be ported to 0.23 as well to keep backward compatibility. +1 for the patch.

        Show
        Suresh Srinivas added a comment - Sanjay, thanks for cleaning this up. This needs to be ported to 0.23 as well to keep backward compatibility. +1 for the patch.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12518915/rpcFixPBHeader2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/729//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/729//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12518915/rpcFixPBHeader2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/729//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/729//console This message is automatically generated.
        Sanjay Radia made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Sanjay Radia made changes -
        Attachment rpcFixPBHeader2.patch [ 12518915 ]
        Sanjay Radia made changes -
        Field Original Value New Value
        Link This issue is part of HADOOP-7347 [ HADOOP-7347 ]
        Sanjay Radia created issue -

          People

          • Assignee:
            Sanjay Radia
            Reporter:
            Sanjay Radia
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development