Hadoop Common
  1. Hadoop Common
  2. HADOOP-8154

DNS#getIPs shouldn't silently return the local host IP for bogus interface names

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1.0, 2.0.0-alpha
    • Component/s: conf
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed

      Description

      DNS#getIPs silently returns the local host IP for bogus interface names. In this case let's throw an UnknownHostException. This is technically an incompatbile change. I suspect the current behavior was origininally introduced so the interface name "default" works w/o explicitly checking for it. It may also be used in cases where someone is using a shared config file and an option like "dfs.datanode.dns.interface" or "hbase.master.dns.interface" and eg interface "eth3" that some hosts don't have, though I think silently ignorning this is the wrong behavior (those hosts should be configured to use a different interface).

      1. hadoop-8154.txt
        10 kB
        Eli Collins
      2. hadoop-8154-b1.txt
        1 kB
        Eli Collins

        Activity

        Hide
        Eli Collins added a comment -

        Merged to branch-1.

        Show
        Eli Collins added a comment - Merged to branch-1.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1014 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1014/)
        HADOOP-8154. DNS#getIPs shouldn't silently return the local host IP for bogus interface names. Contributed by Eli Collins (Revision 1298696)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298696
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNS.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestDNS.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1014 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1014/ ) HADOOP-8154 . DNS#getIPs shouldn't silently return the local host IP for bogus interface names. Contributed by Eli Collins (Revision 1298696) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298696 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNS.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestDNS.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #220 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/220/)
        HADOOP-8154. svn merge -c 1298696 from trunk (Revision 1298697)

        Result = FAILURE
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298697
        Files :

        • /hadoop/common/branches/branch-0.23
        • /hadoop/common/branches/branch-0.23/hadoop-common-project
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNS.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestDNS.java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
        • /hadoop/common/branches/branch-0.23/hadoop-project
        • /hadoop/common/branches/branch-0.23/hadoop-project/src/site
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #220 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/220/ ) HADOOP-8154 . svn merge -c 1298696 from trunk (Revision 1298697) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298697 Files : /hadoop/common/branches/branch-0.23 /hadoop/common/branches/branch-0.23/hadoop-common-project /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNS.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestDNS.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++ /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job /hadoop/common/branches/branch-0.23/hadoop-project /hadoop/common/branches/branch-0.23/hadoop-project/src/site
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #979 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/979/)
        HADOOP-8154. DNS#getIPs shouldn't silently return the local host IP for bogus interface names. Contributed by Eli Collins (Revision 1298696)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298696
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNS.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestDNS.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #979 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/979/ ) HADOOP-8154 . DNS#getIPs shouldn't silently return the local host IP for bogus interface names. Contributed by Eli Collins (Revision 1298696) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298696 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNS.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestDNS.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #192 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/192/)
        HADOOP-8154. svn merge -c 1298696 from trunk (Revision 1298697)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298697
        Files :

        • /hadoop/common/branches/branch-0.23
        • /hadoop/common/branches/branch-0.23/hadoop-common-project
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNS.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestDNS.java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
        • /hadoop/common/branches/branch-0.23/hadoop-project
        • /hadoop/common/branches/branch-0.23/hadoop-project/src/site
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #192 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/192/ ) HADOOP-8154 . svn merge -c 1298696 from trunk (Revision 1298697) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298697 Files : /hadoop/common/branches/branch-0.23 /hadoop/common/branches/branch-0.23/hadoop-common-project /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNS.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestDNS.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++ /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job /hadoop/common/branches/branch-0.23/hadoop-project /hadoop/common/branches/branch-0.23/hadoop-project/src/site
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1863 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1863/)
        HADOOP-8154. DNS#getIPs shouldn't silently return the local host IP for bogus interface names. Contributed by Eli Collins (Revision 1298696)

        Result = ABORTED
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298696
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNS.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestDNS.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1863 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1863/ ) HADOOP-8154 . DNS#getIPs shouldn't silently return the local host IP for bogus interface names. Contributed by Eli Collins (Revision 1298696) Result = ABORTED eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298696 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNS.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestDNS.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #671 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/671/)
        HADOOP-8154. svn merge -c 1298696 from trunk (Revision 1298697)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298697
        Files :

        • /hadoop/common/branches/branch-0.23
        • /hadoop/common/branches/branch-0.23/hadoop-common-project
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNS.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestDNS.java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
        • /hadoop/common/branches/branch-0.23/hadoop-project
        • /hadoop/common/branches/branch-0.23/hadoop-project/src/site
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #671 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/671/ ) HADOOP-8154 . svn merge -c 1298696 from trunk (Revision 1298697) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298697 Files : /hadoop/common/branches/branch-0.23 /hadoop/common/branches/branch-0.23/hadoop-common-project /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNS.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestDNS.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++ /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job /hadoop/common/branches/branch-0.23/hadoop-project /hadoop/common/branches/branch-0.23/hadoop-project/src/site
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1854 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1854/)
        HADOOP-8154. DNS#getIPs shouldn't silently return the local host IP for bogus interface names. Contributed by Eli Collins (Revision 1298696)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298696
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNS.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestDNS.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1854 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1854/ ) HADOOP-8154 . DNS#getIPs shouldn't silently return the local host IP for bogus interface names. Contributed by Eli Collins (Revision 1298696) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298696 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNS.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestDNS.java
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12517675/hadoop-8154-b1.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/692//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12517675/hadoop-8154-b1.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/692//console This message is automatically generated.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #663 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/663/)
        HADOOP-8154. svn merge -c 1298696 from trunk (Revision 1298697)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298697
        Files :

        • /hadoop/common/branches/branch-0.23
        • /hadoop/common/branches/branch-0.23/hadoop-common-project
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNS.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestDNS.java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
        • /hadoop/common/branches/branch-0.23/hadoop-project
        • /hadoop/common/branches/branch-0.23/hadoop-project/src/site
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #663 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/663/ ) HADOOP-8154 . svn merge -c 1298696 from trunk (Revision 1298697) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298697 Files : /hadoop/common/branches/branch-0.23 /hadoop/common/branches/branch-0.23/hadoop-common-project /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNS.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestDNS.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++ /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job /hadoop/common/branches/branch-0.23/hadoop-project /hadoop/common/branches/branch-0.23/hadoop-project/src/site
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1929 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1929/)
        HADOOP-8154. DNS#getIPs shouldn't silently return the local host IP for bogus interface names. Contributed by Eli Collins (Revision 1298696)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298696
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNS.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestDNS.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1929 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1929/ ) HADOOP-8154 . DNS#getIPs shouldn't silently return the local host IP for bogus interface names. Contributed by Eli Collins (Revision 1298696) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298696 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNS.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestDNS.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #654 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/654/)
        HADOOP-8154. svn merge -c 1298696 from trunk (Revision 1298697)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298697
        Files :

        • /hadoop/common/branches/branch-0.23
        • /hadoop/common/branches/branch-0.23/hadoop-common-project
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNS.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestDNS.java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
        • /hadoop/common/branches/branch-0.23/hadoop-project
        • /hadoop/common/branches/branch-0.23/hadoop-project/src/site
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #654 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/654/ ) HADOOP-8154 . svn merge -c 1298696 from trunk (Revision 1298697) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298697 Files : /hadoop/common/branches/branch-0.23 /hadoop/common/branches/branch-0.23/hadoop-common-project /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNS.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestDNS.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++ /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job /hadoop/common/branches/branch-0.23/hadoop-project /hadoop/common/branches/branch-0.23/hadoop-project/src/site
        Hide
        Eli Collins added a comment -

        Thanks for the review Todd. I've committed this and merged to 23. Attached a minimal patch for branch-1.

        Show
        Eli Collins added a comment - Thanks for the review Todd. I've committed this and merged to 23. Attached a minimal patch for branch-1.
        Hide
        Eli Collins added a comment -

        Patch for branch-1 attached.

        Show
        Eli Collins added a comment - Patch for branch-1 attached.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12517597/hadoop-8154.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/691//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/691//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12517597/hadoop-8154.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/691//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/691//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        ok, +1 pending test results. Is this blocked by another change or can you mark it PA?

        Show
        Todd Lipcon added a comment - ok, +1 pending test results. Is this blocked by another change or can you mark it PA?
        Hide
        Eli Collins added a comment -

        Under what circumstances would the following code trigger?

        When enumerating local interfaces the JVM creates a dummy socket, if socket(2) fails it throws a SocketException, so not likely in practice. In HADOOP-8156 I've plumbed that up to the caller, if you don't mind I'll leave that case alone here since it's a separate code path.

        Show
        Eli Collins added a comment - Under what circumstances would the following code trigger? When enumerating local interfaces the JVM creates a dummy socket, if socket(2) fails it throws a SocketException, so not likely in practice. In HADOOP-8156 I've plumbed that up to the caller, if you don't mind I'll leave that case alone here since it's a separate code path.
        Hide
        Todd Lipcon added a comment -

        Under what circumstances would the following code trigger?

        +    } catch (SocketException e) {
        +      LOG.warn("I/O error finding interface " + strInterface +
        +          ": " + e.getMessage());
        

        Seems strange that we fallback to the default there, but throw an exception if we specify an invalid one.

        Show
        Todd Lipcon added a comment - Under what circumstances would the following code trigger? + } catch (SocketException e) { + LOG.warn( "I/O error finding interface " + strInterface + + ": " + e.getMessage()); Seems strange that we fallback to the default there, but throw an exception if we specify an invalid one.
        Hide
        Eli Collins added a comment -

        I suspect the current behavior was origininally introduced so the interface name "default" works w/o explicitly checking for it.

        Confirmed this by looking at the original change that introduced this (HADOOP-497).

        Show
        Eli Collins added a comment - I suspect the current behavior was origininally introduced so the interface name "default" works w/o explicitly checking for it. Confirmed this by looking at the original change that introduced this ( HADOOP-497 ).
        Hide
        Eli Collins added a comment -

        Patch attached

        • Updated javadocs to reflect the actual behavior
        • Add a warning when we use the cached hostname because we can't determine the hostname
        • Add testGetIPWithDefault to ensure the behavior for "default" is preserved
        • Update testIPsOfUnknownInterface
        • Updated testNullInterface to cover getDefaultIP
        • Convert TestDNS to junit4
        Show
        Eli Collins added a comment - Patch attached Updated javadocs to reflect the actual behavior Add a warning when we use the cached hostname because we can't determine the hostname Add testGetIPWithDefault to ensure the behavior for "default" is preserved Update testIPsOfUnknownInterface Updated testNullInterface to cover getDefaultIP Convert TestDNS to junit4

          People

          • Assignee:
            Eli Collins
            Reporter:
            Eli Collins
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development