Hadoop Common
  1. Hadoop Common
  2. HADOOP-8074

Small bug in hadoop error message for unknown commands

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.24.0
    • Fix Version/s: 0.23.2
    • Component/s: scripts
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".

      hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
      at: Unknown command
      
      1. HADOOP-8074.txt
        1.0 kB
        Colin Patrick McCabe

        Activity

        Hide
        Eli Collins added a comment -

        Agree. Let's knock out your (Daryn's) suggested improvements and at least file a jira for accepting commands without a leading dash as well.

        Show
        Eli Collins added a comment - Agree. Let's knock out your (Daryn's) suggested improvements and at least file a jira for accepting commands without a leading dash as well.
        Hide
        Daryn Sharp added a comment -

        Levenstein is a very cool idea for suggesting alternatives! Apache Common's StringUtils even has a method for it. It's a handful of lines to implement, so I can post a patch with it later today if you can please help me out with updating the hdfs tests since I've got more demanding priorities...

        Show
        Daryn Sharp added a comment - Levenstein is a very cool idea for suggesting alternatives! Apache Common's StringUtils even has a method for it. It's a handful of lines to implement, so I can post a patch with it later today if you can please help me out with updating the hdfs tests since I've got more demanding priorities...
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #992 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/992/)
        HADOOP-8074. Small bug in hadoop error message for unknown commands. Contributed by Colin Patrick McCabe (Revision 1244766)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244766
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #992 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/992/ ) HADOOP-8074 . Small bug in hadoop error message for unknown commands. Contributed by Colin Patrick McCabe (Revision 1244766) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244766 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #198 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/198/)
        HADOOP-8074. svn merge -c 1244766 from trunk (Revision 1244768)

        Result = FAILURE
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244768
        Files :

        • /hadoop/common/branches/branch-0.23
        • /hadoop/common/branches/branch-0.23/hadoop-common-project
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
        • /hadoop/common/branches/branch-0.23/hadoop-project
        • /hadoop/common/branches/branch-0.23/hadoop-project/src/site
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #198 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/198/ ) HADOOP-8074 . svn merge -c 1244766 from trunk (Revision 1244768) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244768 Files : /hadoop/common/branches/branch-0.23 /hadoop/common/branches/branch-0.23/hadoop-common-project /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++ /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job /hadoop/common/branches/branch-0.23/hadoop-project /hadoop/common/branches/branch-0.23/hadoop-project/src/site
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #957 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/957/)
        HADOOP-8074. Small bug in hadoop error message for unknown commands. Contributed by Colin Patrick McCabe (Revision 1244766)

        Result = FAILURE
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244766
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #957 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/957/ ) HADOOP-8074 . Small bug in hadoop error message for unknown commands. Contributed by Colin Patrick McCabe (Revision 1244766) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244766 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #170 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/170/)
        HADOOP-8074. svn merge -c 1244766 from trunk (Revision 1244768)

        Result = FAILURE
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244768
        Files :

        • /hadoop/common/branches/branch-0.23
        • /hadoop/common/branches/branch-0.23/hadoop-common-project
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
        • /hadoop/common/branches/branch-0.23/hadoop-project
        • /hadoop/common/branches/branch-0.23/hadoop-project/src/site
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #170 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/170/ ) HADOOP-8074 . svn merge -c 1244766 from trunk (Revision 1244768) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244768 Files : /hadoop/common/branches/branch-0.23 /hadoop/common/branches/branch-0.23/hadoop-common-project /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++ /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job /hadoop/common/branches/branch-0.23/hadoop-project /hadoop/common/branches/branch-0.23/hadoop-project/src/site
        Hide
        Colin Patrick McCabe added a comment -

        Hi Daryn,

        I like your idea of accepting the commands without a leading dash. It makes sense to me.

        Another improvement we could consider is enhancing FsShell to do a more general "did you mean" type search. You could point out the one or two commands with the shortest Levenstein distance from what the user entered.

        For now, this change catches the fairly common case where a first-time user types the command without a dash, and then is mystified when it doesn't work. I know that this can happen because I was that first-time user at one point!

        Colin

        Show
        Colin Patrick McCabe added a comment - Hi Daryn, I like your idea of accepting the commands without a leading dash. It makes sense to me. Another improvement we could consider is enhancing FsShell to do a more general "did you mean" type search. You could point out the one or two commands with the shortest Levenstein distance from what the user entered. For now, this change catches the fairly common case where a first-time user types the command without a dash, and then is mystified when it doesn't work. I know that this can happen because I was that first-time user at one point! Colin
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #560 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/560/)
        HADOOP-8074. svn merge -c 1244766 from trunk (Revision 1244768)

        Result = ABORTED
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244768
        Files :

        • /hadoop/common/branches/branch-0.23
        • /hadoop/common/branches/branch-0.23/hadoop-common-project
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
        • /hadoop/common/branches/branch-0.23/hadoop-project
        • /hadoop/common/branches/branch-0.23/hadoop-project/src/site
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #560 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/560/ ) HADOOP-8074 . svn merge -c 1244766 from trunk (Revision 1244768) Result = ABORTED eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244768 Files : /hadoop/common/branches/branch-0.23 /hadoop/common/branches/branch-0.23/hadoop-common-project /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++ /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job /hadoop/common/branches/branch-0.23/hadoop-project /hadoop/common/branches/branch-0.23/hadoop-project/src/site
        Hide
        Eli Collins added a comment -

        Hey Daryn,

        Sorry, missed your comment in the stream of comments! Mind filing a jira for your suggested improvement? I'd be happy to review / commit.

        Also, how about filing a jira for your idea of making the leading dash optional? It's currently not optional in FsShell (all hadoop commands must have form <cmd> <-cmd>) which is why I think the current change is reasonable.

        Thanks,
        Eli

        Show
        Eli Collins added a comment - Hey Daryn, Sorry, missed your comment in the stream of comments! Mind filing a jira for your suggested improvement? I'd be happy to review / commit. Also, how about filing a jira for your idea of making the leading dash optional? It's currently not optional in FsShell (all hadoop commands must have form <cmd> <-cmd>) which is why I think the current change is reasonable. Thanks, Eli
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1745 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1745/)
        HADOOP-8074. Small bug in hadoop error message for unknown commands. Contributed by Colin Patrick McCabe (Revision 1244766)

        Result = ABORTED
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244766
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1745 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1745/ ) HADOOP-8074 . Small bug in hadoop error message for unknown commands. Contributed by Colin Patrick McCabe (Revision 1244766) Result = ABORTED eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244766 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
        Hide
        Daryn Sharp added a comment -

        Or for user-friendliness, something like this. I was hoping someday to make the leading dash optional if I got around to adding interactive readline support.

        --- hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java	(revision 1242960)
        +++ hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java	(working copy)
        @@ -23,6 +23,7 @@
         import java.util.Arrays;
         import java.util.LinkedList;
         
        +import org.apache.commons.lang.StringUtils;
         import org.apache.commons.logging.Log;
         import org.apache.commons.logging.LogFactory;
         import org.apache.hadoop.classification.InterfaceAudience;
        @@ -251,11 +252,15 @@
                 if (instance == null) {
                   throw new UnknownCommandException();
                 }
        +        cmd = instance.getName();
                 exitCode = instance.run(Arrays.copyOfRange(argv, 1, argv.length));
               } catch (IllegalArgumentException e) {
                 displayError(cmd, e.getLocalizedMessage());
                 if (instance != null) {
                   printInstanceUsage(System.err, instance);
        +        } else {
        +          System.err.println("Available commands: " +
        +              StringUtils.join(commandFactory.getNames(), " "));
                 }
               } catch (Exception e) {
                 // instance.run catches IOE, so something is REALLY wrong if here
        @@ -269,7 +274,7 @@
           
           private void displayError(String cmd, String message) {
             for (String line : message.split("\n")) {
        -      System.err.println(cmd.substring(1) + ": " + line);
        +      System.err.println(cmd + ": " + line);
             }
           }
        
        Show
        Daryn Sharp added a comment - Or for user-friendliness, something like this. I was hoping someday to make the leading dash optional if I got around to adding interactive readline support. --- hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java (revision 1242960) +++ hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java (working copy) @@ -23,6 +23,7 @@ import java.util.Arrays; import java.util.LinkedList; + import org.apache.commons.lang.StringUtils; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.apache.hadoop.classification.InterfaceAudience; @@ -251,11 +252,15 @@ if (instance == null ) { throw new UnknownCommandException(); } + cmd = instance.getName(); exitCode = instance.run(Arrays.copyOfRange(argv, 1, argv.length)); } catch (IllegalArgumentException e) { displayError(cmd, e.getLocalizedMessage()); if (instance != null ) { printInstanceUsage( System .err, instance); + } else { + System .err.println( "Available commands: " + + StringUtils.join(commandFactory.getNames(), " " )); } } catch (Exception e) { // instance.run catches IOE, so something is REALLY wrong if here @@ -269,7 +274,7 @@ private void displayError( String cmd, String message) { for ( String line : message.split( "\n" )) { - System .err.println(cmd.substring(1) + ": " + line); + System .err.println(cmd + ": " + line); } }
        Hide
        Tom White added a comment -

        I think this should be reverted so Daryn's feedback can be addressed.

        Show
        Tom White added a comment - I think this should be reverted so Daryn's feedback can be addressed.
        Hide
        Daryn Sharp added a comment -

        I guess my request to review got overlooked. FsShell is not designed to enforce a leading dash, it's actually completely generic and it just happens that commands today start with a dash. The more correct patch would have been:

        
        --- hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java	(revision 1242960)
        +++ hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java	(working copy)
        @@ -251,6 +251,7 @@
                 if (instance == null) {
                   throw new UnknownCommandException();
                 }
        +        cmd = instance.getName();
                 exitCode = instance.run(Arrays.copyOfRange(argv, 1, argv.length));
               } catch (IllegalArgumentException e) {
                 displayError(cmd, e.getLocalizedMessage());
        @@ -269,7 +270,7 @@
           
           private void displayError(String cmd, String message) {
             for (String line : message.split("\n")) {
        -      System.err.println(cmd.substring(1) + ": " + line);
        +      System.err.println(cmd + ": " + line);
             }
           }
        
        Show
        Daryn Sharp added a comment - I guess my request to review got overlooked. FsShell is not designed to enforce a leading dash, it's actually completely generic and it just happens that commands today start with a dash. The more correct patch would have been: --- hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java (revision 1242960) +++ hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java (working copy) @@ -251,6 +251,7 @@ if (instance == null ) { throw new UnknownCommandException(); } + cmd = instance.getName(); exitCode = instance.run(Arrays.copyOfRange(argv, 1, argv.length)); } catch (IllegalArgumentException e) { displayError(cmd, e.getLocalizedMessage()); @@ -269,7 +270,7 @@ private void displayError( String cmd, String message) { for ( String line : message.split( "\n" )) { - System .err.println(cmd.substring(1) + ": " + line); + System .err.println(cmd + ": " + line); } }
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1807 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1807/)
        HADOOP-8074. Small bug in hadoop error message for unknown commands. Contributed by Colin Patrick McCabe (Revision 1244766)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244766
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1807 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1807/ ) HADOOP-8074 . Small bug in hadoop error message for unknown commands. Contributed by Colin Patrick McCabe (Revision 1244766) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244766 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1733 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1733/)
        HADOOP-8074. Small bug in hadoop error message for unknown commands. Contributed by Colin Patrick McCabe (Revision 1244766)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244766
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1733 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1733/ ) HADOOP-8074 . Small bug in hadoop error message for unknown commands. Contributed by Colin Patrick McCabe (Revision 1244766) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244766 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #557 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/557/)
        HADOOP-8074. svn merge -c 1244766 from trunk (Revision 1244768)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244768
        Files :

        • /hadoop/common/branches/branch-0.23
        • /hadoop/common/branches/branch-0.23/hadoop-common-project
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
        • /hadoop/common/branches/branch-0.23/hadoop-project
        • /hadoop/common/branches/branch-0.23/hadoop-project/src/site
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #557 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/557/ ) HADOOP-8074 . svn merge -c 1244766 from trunk (Revision 1244768) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244768 Files : /hadoop/common/branches/branch-0.23 /hadoop/common/branches/branch-0.23/hadoop-common-project /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++ /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job /hadoop/common/branches/branch-0.23/hadoop-project /hadoop/common/branches/branch-0.23/hadoop-project/src/site
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #544 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/544/)
        HADOOP-8074. svn merge -c 1244766 from trunk (Revision 1244768)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244768
        Files :

        • /hadoop/common/branches/branch-0.23
        • /hadoop/common/branches/branch-0.23/hadoop-common-project
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
        • /hadoop/common/branches/branch-0.23/hadoop-project
        • /hadoop/common/branches/branch-0.23/hadoop-project/src/site
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #544 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/544/ ) HADOOP-8074 . svn merge -c 1244766 from trunk (Revision 1244768) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244768 Files : /hadoop/common/branches/branch-0.23 /hadoop/common/branches/branch-0.23/hadoop-common-project /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++ /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job /hadoop/common/branches/branch-0.23/hadoop-project /hadoop/common/branches/branch-0.23/hadoop-project/src/site
        Hide
        Eli Collins added a comment -

        I've committed this and merged to branch. Thanks Colin!

        Show
        Eli Collins added a comment - I've committed this and merged to branch. Thanks Colin!
        Hide
        Eli Collins added a comment -

        -1 tests included.

        Waiting on HDFS-2038.

        Show
        Eli Collins added a comment - -1 tests included. Waiting on HDFS-2038 .
        Hide
        Daryn Sharp added a comment -

        Let me take a quick look at this...

        Show
        Daryn Sharp added a comment - Let me take a quick look at this...
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12514712/HADOOP-8074.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/603//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/603//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12514712/HADOOP-8074.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/603//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/603//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12514712/HADOOP-8074.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/602//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/602//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12514712/HADOOP-8074.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/602//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/602//console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        Forgot to mention, Colin tried to add a test but ran into HADOOP-7360 / HDFS-2038, I'll ping those jiras. We'll test the output of TestHDFSCLI w/ and w/o this change for sanity. Given that it only updates the error handling path it shouldn't have an impact.

        Show
        Eli Collins added a comment - Forgot to mention, Colin tried to add a test but ran into HADOOP-7360 / HDFS-2038 , I'll ping those jiras. We'll test the output of TestHDFSCLI w/ and w/o this change for sanity. Given that it only updates the error handling path it shouldn't have an impact.
        Hide
        Eli Collins added a comment -

        +1 looks good pending jenkins

        Show
        Eli Collins added a comment - +1 looks good pending jenkins
        Hide
        Colin Patrick McCabe added a comment -

        patch attached

        Try to help users who specified a command without the mandatory leading dash.

        Show
        Colin Patrick McCabe added a comment - patch attached Try to help users who specified a command without the mandatory leading dash.

          People

          • Assignee:
            Colin Patrick McCabe
            Reporter:
            Eli Collins
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development