Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.1, 0.24.0
    • Fix Version/s: 0.23.2
    • Component/s: util
    • Labels:
      None

      Description

      There is an existing Credentials#addAll which combines two Credentials, but it overwrites all existing Credentials. There should be a Credentials#mergeAll that will not overwrite. This will facility the cleanup of code in TokenCache denoted with:

      //TODO: Need to come up with a better place to put
      //this block of code to do with reading the file
      

      The token cache basically needs to merge the contents of a binary credentials file when it fails to find a token. Performing the merge within Credentials is cleaner, and will break the cross-component dependency whereby the TokenCache currently has to have intimate knowledge of how the FileSystem will key tokens in the cache.

        Attachments

        1. HADOOP-8048-2.patch
          5 kB
          Daryn Sharp
        2. HADOOP-8048.patch
          4 kB
          Daryn Sharp

          Issue Links

            Activity

              People

              • Assignee:
                daryn Daryn Sharp
                Reporter:
                daryn Daryn Sharp
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: