Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-8003

Make SplitCompressionInputStream an interface instead of an abstract class

    XMLWordPrintableJSON

    Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 1.0.0, 0.21.0, 0.22.0, 0.23.0
    • Fix Version/s: None
    • Component/s: io
    • Labels:
      None

      Description

      To be splittable, a codec must extend SplittableCompressionCodec which has a function returning a SplitCompressionInputStream.

      SplitCompressionInputStream is an abstract class which extends CompressionInputStream, the lowest level compression stream class.

      So, no codec that wants to be splittable can reuse any code from DecompressorStream or BlockDecompressorStream.

      You either have to duplicate that code, or not be splittable.

      SplitCompressionInputStream adds just a few very thin functions. Can we make this an interface rather than an abstract class to allow splittable decompression streams to extend DecompressorStream, BlockDecompressorStream, or whatever else we should scheme up in the future?

      To my knowledge, this would impact only the BZip2 codec. None of the other implement this form of splittability yet.

      LineRecordReader looks only at whether the codec is an instance of SplittableCompressionCodec, and then calls the appropriate version of createInputStream. This would not change, so the application code should not have to change, just BZip and SplitCompressionInputStream.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                tbroberg Tim Broberg
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: