Hadoop Common
  1. Hadoop Common
  2. HADOOP-7998

CheckFileSystem does not correctly honor setVerifyChecksum

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0, 0.24.0
    • Fix Version/s: 0.23.1
    • Component/s: fs
    • Labels:
      None

      Description

      Regardless of the verify checksum flag, ChecksumFileSystem#open will instantiate a ChecksumFSInputChecker instead of a normal stream.

      1. HADOOP-7998-2.patch
        6 kB
        Daryn Sharp
      2. HADOOP-7998.patch
        5 kB
        Daryn Sharp

        Issue Links

          Activity

          Hide
          Robert Joseph Evans added a comment -

          I like the patch. It seems fairly straight forward, but the test you added in seems a bit too whitebox for my taste. The test requires that the checksum validation be done the way it is currently done. That may be an OK assumption, but I would rather see the test not need to make that assumption, and instead validate that reading a file with an invalid checksum file will work with verify checksum disabled.

          Show
          Robert Joseph Evans added a comment - I like the patch. It seems fairly straight forward, but the test you added in seems a bit too whitebox for my taste. The test requires that the checksum validation be done the way it is currently done. That may be an OK assumption, but I would rather see the test not need to make that assumption, and instead validate that reading a file with an invalid checksum file will work with verify checksum disabled.
          Hide
          Daryn Sharp added a comment -

          tests are more comprehensive

          Show
          Daryn Sharp added a comment - tests are more comprehensive
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12512235/HADOOP-7998-2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated 7 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/542//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/542//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12512235/HADOOP-7998-2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 7 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/542//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/542//console This message is automatically generated.
          Hide
          Robert Joseph Evans added a comment -

          Your patch looks good +1. I looked at the javadoc warnings and they are

          [WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/KerberosAuthenticator.java:21: warning: sun.security.jgss.GSSUtil is Sun proprietary API and may be removed in a future release
          [WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/KerberosName.java:30: warning: sun.security.krb5.Config is Sun proprietary API and may be removed in a future release
          [WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/KerberosName.java:31: warning: sun.security.krb5.KrbException is Sun proprietary API and may be removed in a future release
          [WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/KerberosName.java:80: warning: sun.security.krb5.Config is Sun proprietary API and may be removed in a future release
          [WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java:28: warning: sun.security.krb5.Config is Sun proprietary API and may be removed in a future release
          [WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java:29: warning: sun.security.krb5.KrbException is Sun proprietary API and may be removed in a future release
          [WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:49: warning: sun.net.dns.ResolverConfiguration is Sun proprietary API and may be removed in a future release
          [WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:50: warning: sun.net.util.IPAddressUtil is Sun proprietary API and may be removed in a future release
          [WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:51: warning: sun.security.jgss.krb5.Krb5Util is Sun proprietary API and may be removed in a future release
          [WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:52: warning: sun.security.krb5.Credentials is Sun proprietary API and may be removed in a future release
          [WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:53: warning: sun.security.krb5.PrincipalName is Sun proprietary API and may be removed in a future release
          [WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/FastByteComparisons.java:25: warning: sun.misc.Unsafe is Sun proprietary API and may be removed in a future release
          [WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/FastByteComparisons.java:117: warning: sun.misc.Unsafe is Sun proprietary API and may be removed in a future release
          

          All of them look like acceptable usage, and the first 6 kerberos ones are already ignored so I will bump the javadoc warning number as part of the commit.

          Show
          Robert Joseph Evans added a comment - Your patch looks good +1. I looked at the javadoc warnings and they are [WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/KerberosAuthenticator.java:21: warning: sun.security.jgss.GSSUtil is Sun proprietary API and may be removed in a future release [WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/KerberosName.java:30: warning: sun.security.krb5.Config is Sun proprietary API and may be removed in a future release [WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/KerberosName.java:31: warning: sun.security.krb5.KrbException is Sun proprietary API and may be removed in a future release [WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/KerberosName.java:80: warning: sun.security.krb5.Config is Sun proprietary API and may be removed in a future release [WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java:28: warning: sun.security.krb5.Config is Sun proprietary API and may be removed in a future release [WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java:29: warning: sun.security.krb5.KrbException is Sun proprietary API and may be removed in a future release [WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:49: warning: sun.net.dns.ResolverConfiguration is Sun proprietary API and may be removed in a future release [WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:50: warning: sun.net.util.IPAddressUtil is Sun proprietary API and may be removed in a future release [WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:51: warning: sun.security.jgss.krb5.Krb5Util is Sun proprietary API and may be removed in a future release [WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:52: warning: sun.security.krb5.Credentials is Sun proprietary API and may be removed in a future release [WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:53: warning: sun.security.krb5.PrincipalName is Sun proprietary API and may be removed in a future release [WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/FastByteComparisons.java:25: warning: sun.misc.Unsafe is Sun proprietary API and may be removed in a future release [WARNING] /home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/FastByteComparisons.java:117: warning: sun.misc.Unsafe is Sun proprietary API and may be removed in a future release All of them look like acceptable usage, and the first 6 kerberos ones are already ignored so I will bump the javadoc warning number as part of the commit.
          Hide
          Robert Joseph Evans added a comment -

          I just committed this to trunk and 0.23. Thanks for your work on this.

          Show
          Robert Joseph Evans added a comment - I just committed this to trunk and 0.23. Thanks for your work on this.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1677 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1677/)
          HADOOP-7998 CheckFileSystem does not correctly honor setVerifyChecksum (Daryn Sharp via bobby)

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236911
          Files :

          • /hadoop/common/trunk/hadoop-common-project/dev-support/test-patch.properties
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1677 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1677/ ) HADOOP-7998 CheckFileSystem does not correctly honor setVerifyChecksum (Daryn Sharp via bobby) bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236911 Files : /hadoop/common/trunk/hadoop-common-project/dev-support/test-patch.properties /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-0.23-Commit #435 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/435/)
          merge HADOOP-7998

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236913
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project/dev-support/test-patch.properties
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #435 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/435/ ) merge HADOOP-7998 bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236913 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/dev-support/test-patch.properties /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1605 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1605/)
          HADOOP-7998 CheckFileSystem does not correctly honor setVerifyChecksum (Daryn Sharp via bobby)

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236911
          Files :

          • /hadoop/common/trunk/hadoop-common-project/dev-support/test-patch.properties
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1605 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1605/ ) HADOOP-7998 CheckFileSystem does not correctly honor setVerifyChecksum (Daryn Sharp via bobby) bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236911 Files : /hadoop/common/trunk/hadoop-common-project/dev-support/test-patch.properties /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Commit #426 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/426/)
          merge HADOOP-7998

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236913
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project/dev-support/test-patch.properties
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #426 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/426/ ) merge HADOOP-7998 bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236913 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/dev-support/test-patch.properties /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1621 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1621/)
          HADOOP-7998 CheckFileSystem does not correctly honor setVerifyChecksum (Daryn Sharp via bobby)

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236911
          Files :

          • /hadoop/common/trunk/hadoop-common-project/dev-support/test-patch.properties
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1621 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1621/ ) HADOOP-7998 CheckFileSystem does not correctly honor setVerifyChecksum (Daryn Sharp via bobby) bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236911 Files : /hadoop/common/trunk/hadoop-common-project/dev-support/test-patch.properties /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Commit #451 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/451/)
          merge HADOOP-7998

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236913
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project/dev-support/test-patch.properties
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #451 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/451/ ) merge HADOOP-7998 bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236913 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/dev-support/test-patch.properties /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #939 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/939/)
          HADOOP-7998 CheckFileSystem does not correctly honor setVerifyChecksum (Daryn Sharp via bobby)

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236911
          Files :

          • /hadoop/common/trunk/hadoop-common-project/dev-support/test-patch.properties
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #939 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/939/ ) HADOOP-7998 CheckFileSystem does not correctly honor setVerifyChecksum (Daryn Sharp via bobby) bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236911 Files : /hadoop/common/trunk/hadoop-common-project/dev-support/test-patch.properties /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Build #174 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/174/)
          merge HADOOP-7998

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236913
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project/dev-support/test-patch.properties
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #174 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/174/ ) merge HADOOP-7998 bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236913 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/dev-support/test-patch.properties /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #152 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/152/)
          merge HADOOP-7998

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236913
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project/dev-support/test-patch.properties
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #152 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/152/ ) merge HADOOP-7998 bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236913 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/dev-support/test-patch.properties /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #972 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/972/)
          HADOOP-7998 CheckFileSystem does not correctly honor setVerifyChecksum (Daryn Sharp via bobby)

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236911
          Files :

          • /hadoop/common/trunk/hadoop-common-project/dev-support/test-patch.properties
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #972 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/972/ ) HADOOP-7998 CheckFileSystem does not correctly honor setVerifyChecksum (Daryn Sharp via bobby) bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236911 Files : /hadoop/common/trunk/hadoop-common-project/dev-support/test-patch.properties /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
          Hide
          Todd Lipcon added a comment -

          This commit seems to have broken HDFS's TestFSInputChecker. See https://builds.apache.org/job/Hadoop-Hdfs-trunk/939/testReport/junit/org.apache.hadoop.hdfs/TestFSInputChecker/testFSInputChecker/

          Daryn, can you take a look?

          Show
          Todd Lipcon added a comment - This commit seems to have broken HDFS's TestFSInputChecker. See https://builds.apache.org/job/Hadoop-Hdfs-trunk/939/testReport/junit/org.apache.hadoop.hdfs/TestFSInputChecker/testFSInputChecker/ Daryn, can you take a look?
          Hide
          Uma Maheswara Rao G added a comment -

          Yes Todd, I already filed HADOOP-8006. We both working on it. thanks

          Show
          Uma Maheswara Rao G added a comment - Yes Todd, I already filed HADOOP-8006 . We both working on it. thanks

            People

            • Assignee:
              Daryn Sharp
              Reporter:
              Daryn Sharp
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development