Hadoop Common
  1. Hadoop Common
  2. HADOOP-7968

Errant println left in RPC.getHighestSupportedProtocol

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.24.0
    • Fix Version/s: 2.0.0-alpha
    • Component/s: ipc
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java: System.out.println("Size of protoMap for " + rpcKind + " =" + getProtocolImplMap(rpcKind).size());

      1. HADOOP-7968.txt
        0.9 kB
        Harsh J
      2. HADOOP-7968.txt
        0.9 kB
        Sho Shimauchi
      3. HADOOP-7968.txt
        0.9 kB
        Sho Shimauchi

        Activity

        Hide
        Sho Shimauchi added a comment -

        change println to LOG.debug

        Show
        Sho Shimauchi added a comment - change println to LOG.debug
        Hide
        Harsh J added a comment -

        Sho,

        Change is fine, but please wrap it in {{if (Log.isDebugEnabled())

        {…}

        }} condition.

        Thanks!

        Show
        Harsh J added a comment - Sho, Change is fine, but please wrap it in {{if (Log.isDebugEnabled()) {…} }} condition. Thanks!
        Hide
        Sho Shimauchi added a comment -

        thanks Harsh, I added.

        Show
        Sho Shimauchi added a comment - thanks Harsh, I added.
        Hide
        Harsh J added a comment -

        +1, committing. Thanks Sho!

        This is not needed (does not apply) on 0.23. Skipping that from target versions.

        Show
        Harsh J added a comment - +1, committing. Thanks Sho! This is not needed (does not apply) on 0.23. Skipping that from target versions.
        Hide
        Harsh J added a comment -

        Fixing the bad indentation. This is the committed patch.

        Show
        Harsh J added a comment - Fixing the bad indentation. This is the committed patch.
        Hide
        Harsh J added a comment -

        Committed, thanks again Sho!

        Show
        Harsh J added a comment - Committed, thanks again Sho!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1619 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1619/)
        HADOOP-7968. Errant println left in RPC.getHighestSupportedProtocol (Sho Shimauchi via harsh)

        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1231732
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1619 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1619/ ) HADOOP-7968 . Errant println left in RPC.getHighestSupportedProtocol (Sho Shimauchi via harsh) harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1231732 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1546 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1546/)
        HADOOP-7968. Errant println left in RPC.getHighestSupportedProtocol (Sho Shimauchi via harsh)

        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1231732
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1546 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1546/ ) HADOOP-7968 . Errant println left in RPC.getHighestSupportedProtocol (Sho Shimauchi via harsh) harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1231732 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1564 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1564/)
        HADOOP-7968. Errant println left in RPC.getHighestSupportedProtocol (Sho Shimauchi via harsh)

        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1231732
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1564 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1564/ ) HADOOP-7968 . Errant println left in RPC.getHighestSupportedProtocol (Sho Shimauchi via harsh) harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1231732 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #927 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/927/)
        HADOOP-7968. Errant println left in RPC.getHighestSupportedProtocol (Sho Shimauchi via harsh)

        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1231732
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #927 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/927/ ) HADOOP-7968 . Errant println left in RPC.getHighestSupportedProtocol (Sho Shimauchi via harsh) harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1231732 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #960 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/960/)
        HADOOP-7968. Errant println left in RPC.getHighestSupportedProtocol (Sho Shimauchi via harsh)

        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1231732
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #960 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/960/ ) HADOOP-7968 . Errant println left in RPC.getHighestSupportedProtocol (Sho Shimauchi via harsh) harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1231732 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have merged this to 0.23.

        Show
        Tsz Wo Nicholas Sze added a comment - I have merged this to 0.23.

          People

          • Assignee:
            Sho Shimauchi
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development