Hadoop Common
  1. Hadoop Common
  2. HADOOP-7957

Classes deriving GetGroupsBase should be able to override proxy creation.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-alpha
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      GetGroups in Hdfs needs to override getUgmProtocol because, due to PB implementations, it will return a translator instance instead of a proxy.

      1. HADOOP-7957.trunk.patch
        0.9 kB
        Jitendra Nath Pandey

        Issue Links

          Activity

          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12509492/HADOOP-7957.trunk.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 javadoc. The javadoc tool appears to have generated 5 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/498//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/498//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12509492/HADOOP-7957.trunk.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 5 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/498//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/498//console This message is automatically generated.
          Hide
          Aaron T. Myers added a comment -

          +1, the patch looks good to me. I'm confident the javadoc warning is unrelated, and this change shouldn't require tests.

          Show
          Aaron T. Myers added a comment - +1, the patch looks good to me. I'm confident the javadoc warning is unrelated, and this change shouldn't require tests.
          Hide
          Jitendra Nath Pandey added a comment -

          Committed.

          Show
          Jitendra Nath Pandey added a comment - Committed.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1504 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1504/)
          HADOOP-7957. Classes deriving GetGroupsBase should be able to override proxy creation.

          jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227861
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/GetGroupsBase.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1504 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1504/ ) HADOOP-7957 . Classes deriving GetGroupsBase should be able to override proxy creation. jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227861 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/GetGroupsBase.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1577 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1577/)
          HADOOP-7957. Classes deriving GetGroupsBase should be able to override proxy creation.

          jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227861
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/GetGroupsBase.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1577 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1577/ ) HADOOP-7957 . Classes deriving GetGroupsBase should be able to override proxy creation. jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227861 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/GetGroupsBase.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1524 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1524/)
          HADOOP-7957. Classes deriving GetGroupsBase should be able to override proxy creation.

          jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227861
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/GetGroupsBase.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1524 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1524/ ) HADOOP-7957 . Classes deriving GetGroupsBase should be able to override proxy creation. jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227861 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/GetGroupsBase.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #917 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/917/)
          HADOOP-7957. Classes deriving GetGroupsBase should be able to override proxy creation.

          jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227861
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/GetGroupsBase.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #917 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/917/ ) HADOOP-7957 . Classes deriving GetGroupsBase should be able to override proxy creation. jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227861 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/GetGroupsBase.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #950 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/950/)
          HADOOP-7957. Classes deriving GetGroupsBase should be able to override proxy creation.

          jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227861
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/GetGroupsBase.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #950 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/950/ ) HADOOP-7957 . Classes deriving GetGroupsBase should be able to override proxy creation. jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227861 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/GetGroupsBase.java
          Hide
          Eli Collins added a comment -

          This should get merged to 23 right?

          Show
          Eli Collins added a comment - This should get merged to 23 right?
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have merged this to 0.23.

          Show
          Tsz Wo Nicholas Sze added a comment - I have merged this to 0.23.

            People

            • Assignee:
              Jitendra Nath Pandey
              Reporter:
              Jitendra Nath Pandey
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development