[HADOOP-7949] Updated maxIdleTime default in the code to match core-default.xml

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.0.0, 0.21.0, 0.22.0, 0.23.0
• Fix Version/s: 0.23.1
• Component/s: ipc
• Hadoop Flags: Reviewed
• Assignee: Eli Collins
• Reporter: Eli Collins
• Created: 04/Jan/12 04:34
• Updated: 05/Mar/12 02:48
• Resolved: 05/Jan/12 01:49

Description

HADOOP-2909 intended to set the server max idle time for a connection to twice the client value. ("The server-side max idle time should be greater than the client-side max idle time, for example, twice of the client-side max idle time.") This way when a server times out a connection it's due a crashed client and not an inactive client so we don't close client connections with outstanding requests (by setting 2x the client value on the server side the client should time out the connection first).

Looks like there was a typo in the patch and it set the default value to 1/5th the client value, instead of the intended 2x.

hadoop2 (pre-HADOOP-4687)$ git reset --hard 6fa4597e
hadoop2 (pre-HADOOP-4687)$ grep -r ipc.client.connection.maxidletime . 
./src/core/org/apache/hadoop/ipc/Client.java:      conf.getInt("ipc.client.connection.maxidletime", 10000); //10s
./src/core/org/apache/hadoop/ipc/Server.java:    this.maxIdleTime = 2*conf.getInt("ipc.client.connection.maxidletime", 1000);

Issue Links

• relates to: HADOOP-2909 Improve IPC idle connection management
• relates to: HADOOP-7956 Remove duplicate definition of default config values