Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-7930

Kerberos relogin interval in UserGroupInformation should be configurable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently the check done in the hasSufficientTimeElapsed() method is hardcoded to 10 mins wait.

      The wait time should be driven by configuration and its default value, for clients should be 1 min.

      1. HADOOP-7930.patch
        7 kB
        Robert Kanter
      2. HADOOP-7930.patch
        8 kB
        Robert Kanter
      3. HADOOP-7930.patch
        8 kB
        Robert Kanter
      4. HADOOP-7930.branch-2.01.patch
        8 kB
        Xiao Chen

        Activity

        Hide
        rkanter Robert Kanter added a comment -

        I added a property called hadoop.kerberos.min.time.before.relogin that is used to specify the relogin interval.

        Show
        rkanter Robert Kanter added a comment - I added a property called hadoop.kerberos.min.time.before.relogin that is used to specify the relogin interval.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12545238/HADOOP-7930.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1466//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/1466//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1466//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12545238/HADOOP-7930.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1466//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/1466//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1466//console This message is automatically generated.
        Hide
        rkanter Robert Kanter added a comment -

        The findbugs warning says "Method org.apache.hadoop.conf.Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop". I looked at the Configuration class, and while the findbugs warning is correct about the code there, the patch doesn't even modify the Configuration class at all, so its wrong about the patch introducing it.

        Show
        rkanter Robert Kanter added a comment - The findbugs warning says "Method org.apache.hadoop.conf.Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop". I looked at the Configuration class, and while the findbugs warning is correct about the code there, the patch doesn't even modify the Configuration class at all, so its wrong about the patch introducing it.
        Hide
        qwertymaniac Harsh J added a comment -

        Robert - You're right that it is unrelated. That was addressed via HADOOP-8821.

        Show
        qwertymaniac Harsh J added a comment - Robert - You're right that it is unrelated. That was addressed via HADOOP-8821 .
        Hide
        qwertymaniac Harsh J added a comment -

        Some comments:

        • Use the CommonConfigurationKeysPublic class to constant-ize the config strings and its defaults. See the file to get an example. Use these constants in the code - instead of hardcoding the config string and the default this way:
        +    try {
        +        kerberosMinTimeBeforeRelogin = 1000L * conf.getLong(
        +                "hadoop.kerberos.min.time.before.relogin", 60);
        
        Show
        qwertymaniac Harsh J added a comment - Some comments: Use the CommonConfigurationKeysPublic class to constant-ize the config strings and its defaults. See the file to get an example. Use these constants in the code - instead of hardcoding the config string and the default this way: + try { + kerberosMinTimeBeforeRelogin = 1000L * conf.getLong( + "hadoop.kerberos.min.time.before.relogin" , 60);
        Hide
        rkanter Robert Kanter added a comment -

        Constantized the config string and default in the new version of the patch

        Show
        rkanter Robert Kanter added a comment - Constantized the config string and default in the new version of the patch
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12546319/HADOOP-7930.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

        org.apache.hadoop.ha.TestZKFailoverController

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1506//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1506//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12546319/HADOOP-7930.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.ha.TestZKFailoverController +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1506//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1506//console This message is automatically generated.
        Hide
        qwertymaniac Harsh J added a comment -

        Thanks Robert. This looks good and am +1. However, if I may suggest, perhaps it is better to name this property hadoop.kerberos.min.seconds.before.relogin, since it expects seconds anyway?

        If not let me know and I'll commit this as it is, as the description anyway is carrying the required units.

        Show
        qwertymaniac Harsh J added a comment - Thanks Robert. This looks good and am +1. However, if I may suggest, perhaps it is better to name this property hadoop.kerberos.min.seconds.before.relogin , since it expects seconds anyway? If not let me know and I'll commit this as it is, as the description anyway is carrying the required units.
        Hide
        rkanter Robert Kanter added a comment -

        That's a good idea; its more clear this way.

        Show
        rkanter Robert Kanter added a comment - That's a good idea; its more clear this way.
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12546354/HADOOP-7930.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1508//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1508//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12546354/HADOOP-7930.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1508//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1508//console This message is automatically generated.
        Hide
        qwertymaniac Harsh J added a comment -

        Thanks Robert! The change looks good, and I've committed this to trunk.

        Show
        qwertymaniac Harsh J added a comment - Thanks Robert! The change looks good, and I've committed this to trunk.
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2829 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2829/)
        HADOOP-7930. Kerberos relogin interval in UserGroupInformation should be configurable. Contributed by Robert Kanter. (harsh) (Revision 1389783)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389783
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2829 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2829/ ) HADOOP-7930 . Kerberos relogin interval in UserGroupInformation should be configurable. Contributed by Robert Kanter. (harsh) (Revision 1389783) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389783 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/core-default.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2766 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2766/)
        HADOOP-7930. Kerberos relogin interval in UserGroupInformation should be configurable. Contributed by Robert Kanter. (harsh) (Revision 1389783)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389783
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2766 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2766/ ) HADOOP-7930 . Kerberos relogin interval in UserGroupInformation should be configurable. Contributed by Robert Kanter. (harsh) (Revision 1389783) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389783 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/core-default.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2788 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2788/)
        HADOOP-7930. Kerberos relogin interval in UserGroupInformation should be configurable. Contributed by Robert Kanter. (harsh) (Revision 1389783)

        Result = FAILURE
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389783
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2788 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2788/ ) HADOOP-7930 . Kerberos relogin interval in UserGroupInformation should be configurable. Contributed by Robert Kanter. (harsh) (Revision 1389783) Result = FAILURE harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389783 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/core-default.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1176 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1176/)
        HADOOP-7930. Kerberos relogin interval in UserGroupInformation should be configurable. Contributed by Robert Kanter. (harsh) (Revision 1389783)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389783
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1176 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1176/ ) HADOOP-7930 . Kerberos relogin interval in UserGroupInformation should be configurable. Contributed by Robert Kanter. (harsh) (Revision 1389783) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389783 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/core-default.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1207 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1207/)
        HADOOP-7930. Kerberos relogin interval in UserGroupInformation should be configurable. Contributed by Robert Kanter. (harsh) (Revision 1389783)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389783
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1207 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1207/ ) HADOOP-7930 . Kerberos relogin interval in UserGroupInformation should be configurable. Contributed by Robert Kanter. (harsh) (Revision 1389783) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389783 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/core-default.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java
        Hide
        sureshms Suresh Srinivas added a comment -

        Harsh J Should this be committed to branch-2 and branch-2.1.0-beta?

        Show
        sureshms Suresh Srinivas added a comment - Harsh J Should this be committed to branch-2 and branch-2.1.0-beta?
        Hide
        atm Aaron T. Myers added a comment -

        That makes sense to me. Harsh J - you agree?

        Show
        atm Aaron T. Myers added a comment - That makes sense to me. Harsh J - you agree?
        Hide
        qwertymaniac Harsh J added a comment -

        Yes that should be fine - lemme know if you'd like me to get the backport done.

        Show
        qwertymaniac Harsh J added a comment - Yes that should be fine - lemme know if you'd like me to get the backport done.
        Hide
        xiaochen Xiao Chen added a comment -

        Sorry to reopen this. Seeing the 3 comments above, I decided to backport this to branch-2 and branch-2.8 (seems we missed branch-2.1.0-beta ) This will make the backport of HADOOP-13590 easier.

        Show
        xiaochen Xiao Chen added a comment - Sorry to reopen this. Seeing the 3 comments above, I decided to backport this to branch-2 and branch-2.8 (seems we missed branch-2.1.0-beta ) This will make the backport of HADOOP-13590 easier.
        Hide
        xiaochen Xiao Chen added a comment -

        Attaching a branch-2 patch. Please take a look. Thanks!

        Conflicts:
        hadoop-common-project/hadoop-common/CHANGES.txt
        hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
        hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
        hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java

        Show
        xiaochen Xiao Chen added a comment - Attaching a branch-2 patch. Please take a look. Thanks! Conflicts: hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 45s branch-2 passed
        +1 compile 6m 10s branch-2 passed with JDK v1.8.0_111
        +1 compile 7m 12s branch-2 passed with JDK v1.7.0_111
        +1 checkstyle 0m 29s branch-2 passed
        +1 mvnsite 1m 2s branch-2 passed
        +1 mvneclipse 0m 16s branch-2 passed
        +1 findbugs 1m 45s branch-2 passed
        +1 javadoc 0m 52s branch-2 passed with JDK v1.8.0_111
        +1 javadoc 0m 59s branch-2 passed with JDK v1.7.0_111
        +1 mvninstall 0m 43s the patch passed
        +1 compile 6m 47s the patch passed with JDK v1.8.0_111
        +1 javac 6m 47s the patch passed
        +1 compile 7m 13s the patch passed with JDK v1.7.0_111
        +1 javac 7m 13s the patch passed
        -0 checkstyle 0m 29s hadoop-common-project/hadoop-common: The patch generated 10 new + 250 unchanged - 2 fixed = 260 total (was 252)
        +1 mvnsite 1m 0s the patch passed
        +1 mvneclipse 0m 20s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 2m 1s the patch passed
        +1 javadoc 0m 47s the patch passed with JDK v1.8.0_111
        +1 javadoc 1m 2s the patch passed with JDK v1.7.0_111
        +1 unit 7m 56s hadoop-common in the patch passed with JDK v1.7.0_111.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        64m 48s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue HADOOP-7930
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836989/HADOOP-7930.branch-2.01.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux 74567884db4b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / 9ede5cc
        Default Java 1.7.0_111
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10984/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10984/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10984/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 45s branch-2 passed +1 compile 6m 10s branch-2 passed with JDK v1.8.0_111 +1 compile 7m 12s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 0m 29s branch-2 passed +1 mvnsite 1m 2s branch-2 passed +1 mvneclipse 0m 16s branch-2 passed +1 findbugs 1m 45s branch-2 passed +1 javadoc 0m 52s branch-2 passed with JDK v1.8.0_111 +1 javadoc 0m 59s branch-2 passed with JDK v1.7.0_111 +1 mvninstall 0m 43s the patch passed +1 compile 6m 47s the patch passed with JDK v1.8.0_111 +1 javac 6m 47s the patch passed +1 compile 7m 13s the patch passed with JDK v1.7.0_111 +1 javac 7m 13s the patch passed -0 checkstyle 0m 29s hadoop-common-project/hadoop-common: The patch generated 10 new + 250 unchanged - 2 fixed = 260 total (was 252) +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 20s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 2m 1s the patch passed +1 javadoc 0m 47s the patch passed with JDK v1.8.0_111 +1 javadoc 1m 2s the patch passed with JDK v1.7.0_111 +1 unit 7m 56s hadoop-common in the patch passed with JDK v1.7.0_111. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 64m 48s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HADOOP-7930 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836989/HADOOP-7930.branch-2.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 74567884db4b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 9ede5cc Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10984/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10984/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10984/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xiaochen Xiao Chen added a comment -

        Checkstyles are all direct backports. So I think we're good to check it in, to make future backports clean.

        Show
        xiaochen Xiao Chen added a comment - Checkstyles are all direct backports. So I think we're good to check it in, to make future backports clean.
        Hide
        rkanter Robert Kanter added a comment -

        +1 on the backport

        Show
        rkanter Robert Kanter added a comment - +1 on the backport
        Hide
        rkanter Robert Kanter added a comment -

        Thanks Xiao Chen for rebasing the patch. Committed to branch-2 and branch-2.8!

        Show
        rkanter Robert Kanter added a comment - Thanks Xiao Chen for rebasing the patch. Committed to branch-2 and branch-2.8!
        Hide
        xiaochen Xiao Chen added a comment -

        Thanks a lot Robert Kanter for the review and commit!

        Show
        xiaochen Xiao Chen added a comment - Thanks a lot Robert Kanter for the review and commit!

          People

          • Assignee:
            rkanter Robert Kanter
            Reporter:
            tucu00 Alejandro Abdelnur
          • Votes:
            1 Vote for this issue
            Watchers:
            11 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development