Hadoop Common
  1. Hadoop Common
  2. HADOOP-7912

test-patch should run eclipse:eclipse to verify that it does not break again

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.1, 0.24.0
    • Fix Version/s: 0.23.1
    • Component/s: build
    • Labels:
      None

      Description

      Recently the eclipse:eclipse build was broken. If we are going to document this on the wiki and have many developers use it we should verify that it always works.

      1. HADOOP-7912.txt
        1 kB
        Robert Joseph Evans
      2. HADOOP-7912.txt
        1 kB
        Robert Joseph Evans

        Activity

        Robert Joseph Evans created issue -
        Hide
        Robert Joseph Evans added a comment -

        Added in a very simple test to -1 patches that break eclipse:eclipse generation.

        Show
        Robert Joseph Evans added a comment - Added in a very simple test to -1 patches that break eclipse:eclipse generation.
        Robert Joseph Evans made changes -
        Field Original Value New Value
        Attachment HADOOP-7912.txt [ 12507029 ]
        Robert Joseph Evans made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Target Version/s 0.23.1, 0.24.0 [ 12318884, 12317652 ] 0.24.0, 0.23.1 [ 12317652, 12318884 ]
        Hide
        Tom White added a comment -

        Apart from a typo ("checkEclpiseGeneration") this looks good. What testing did you do?

        Show
        Tom White added a comment - Apart from a typo ("checkEclpiseGeneration") this looks good. What testing did you do?
        Hide
        Robert Joseph Evans added a comment -

        Thanks for finding that.

        I ran test patch on a small patch that did nothing and verified that it failed (Because HDFS-2649 was not in yet) I then ran it on HDFS-2649 and verified that it passed. I am uploading a fixed patch now.

        Show
        Robert Joseph Evans added a comment - Thanks for finding that. I ran test patch on a small patch that did nothing and verified that it failed (Because HDFS-2649 was not in yet) I then ran it on HDFS-2649 and verified that it passed. I am uploading a fixed patch now.
        Robert Joseph Evans made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Target Version/s 0.23.1, 0.24.0 [ 12318884, 12317652 ] 0.24.0, 0.23.1 [ 12317652, 12318884 ]
        Robert Joseph Evans made changes -
        Attachment HADOOP-7912.txt [ 12507038 ]
        Robert Joseph Evans made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Target Version/s 0.23.1, 0.24.0 [ 12318884, 12317652 ] 0.24.0, 0.23.1 [ 12317652, 12318884 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12507038/HADOOP-7912.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/466//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12507038/HADOOP-7912.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/466//console This message is automatically generated.
        Hide
        Tom White added a comment -

        +1

        I've just committed this. Thanks, Robert!

        Show
        Tom White added a comment - +1 I've just committed this. Thanks, Robert!
        Tom White made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Target Version/s 0.23.1, 0.24.0 [ 12318884, 12317652 ] 0.24.0, 0.23.1 [ 12317652, 12318884 ]
        Fix Version/s 0.24.0 [ 12317652 ]
        Fix Version/s 0.23.1 [ 12318884 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1476 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1476/)
        HADOOP-7912. test-patch should run eclipse:eclipse to verify that it does not break again. Contributed by Robert Joseph Evans

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213432
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1476 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1476/ ) HADOOP-7912 . test-patch should run eclipse:eclipse to verify that it does not break again. Contributed by Robert Joseph Evans tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213432 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1402 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1402/)
        HADOOP-7912. test-patch should run eclipse:eclipse to verify that it does not break again. Contributed by Robert Joseph Evans

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213432
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1402 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1402/ ) HADOOP-7912 . test-patch should run eclipse:eclipse to verify that it does not break again. Contributed by Robert Joseph Evans tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213432 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #272 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/272/)
        Merge -r 1213431:1213432 from trunk to branch-0.23. Fixes: HADOOP-7912

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213434
        Files :

        • /hadoop/common/branches/branch-0.23/dev-support/test-patch.sh
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #272 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/272/ ) Merge -r 1213431:1213432 from trunk to branch-0.23. Fixes: HADOOP-7912 tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213434 Files : /hadoop/common/branches/branch-0.23/dev-support/test-patch.sh /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #262 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/262/)
        Merge -r 1213431:1213432 from trunk to branch-0.23. Fixes: HADOOP-7912

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213434
        Files :

        • /hadoop/common/branches/branch-0.23/dev-support/test-patch.sh
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #262 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/262/ ) Merge -r 1213431:1213432 from trunk to branch-0.23. Fixes: HADOOP-7912 tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213434 Files : /hadoop/common/branches/branch-0.23/dev-support/test-patch.sh /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1424 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1424/)
        HADOOP-7912. test-patch should run eclipse:eclipse to verify that it does not break again. Contributed by Robert Joseph Evans

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213432
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1424 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1424/ ) HADOOP-7912 . test-patch should run eclipse:eclipse to verify that it does not break again. Contributed by Robert Joseph Evans tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213432 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #282 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/282/)
        Merge -r 1213431:1213432 from trunk to branch-0.23. Fixes: HADOOP-7912

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213434
        Files :

        • /hadoop/common/branches/branch-0.23/dev-support/test-patch.sh
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #282 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/282/ ) Merge -r 1213431:1213432 from trunk to branch-0.23. Fixes: HADOOP-7912 tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213434 Files : /hadoop/common/branches/branch-0.23/dev-support/test-patch.sh /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #106 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/106/)
        Merge -r 1213431:1213432 from trunk to branch-0.23. Fixes: HADOOP-7912

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213434
        Files :

        • /hadoop/common/branches/branch-0.23/dev-support/test-patch.sh
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #106 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/106/ ) Merge -r 1213431:1213432 from trunk to branch-0.23. Fixes: HADOOP-7912 tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213434 Files : /hadoop/common/branches/branch-0.23/dev-support/test-patch.sh /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #124 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/124/)
        Merge -r 1213431:1213432 from trunk to branch-0.23. Fixes: HADOOP-7912

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213434
        Files :

        • /hadoop/common/branches/branch-0.23/dev-support/test-patch.sh
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #124 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/124/ ) Merge -r 1213431:1213432 from trunk to branch-0.23. Fixes: HADOOP-7912 tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213434 Files : /hadoop/common/branches/branch-0.23/dev-support/test-patch.sh /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #893 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/893/)
        HADOOP-7912. test-patch should run eclipse:eclipse to verify that it does not break again. Contributed by Robert Joseph Evans

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213432
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #893 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/893/ ) HADOOP-7912 . test-patch should run eclipse:eclipse to verify that it does not break again. Contributed by Robert Joseph Evans tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213432 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #926 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/926/)
        HADOOP-7912. test-patch should run eclipse:eclipse to verify that it does not break again. Contributed by Robert Joseph Evans

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213432
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #926 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/926/ ) HADOOP-7912 . test-patch should run eclipse:eclipse to verify that it does not break again. Contributed by Robert Joseph Evans tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213432 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Allen Wittenauer made changes -
        Fix Version/s 0.24.0 [ 12317652 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Patch Available Patch Available Open Open
        44m 48s 1 Robert Joseph Evans 12/Dec/11 19:26
        Open Open Patch Available Patch Available
        3h 27m 2 Robert Joseph Evans 12/Dec/11 19:26
        Patch Available Patch Available Resolved Resolved
        1h 23m 1 Tom White 12/Dec/11 20:50
        Resolved Resolved Closed Closed
        83d 5h 59m 1 Arun C Murthy 05/Mar/12 02:49

          People

          • Assignee:
            Robert Joseph Evans
            Reporter:
            Robert Joseph Evans
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development