Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-7879

DistributedFileSystem#createNonRecursive should also incrementWriteOps statistics.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.1.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This method:

       public FSDataOutputStream createNonRecursive(Path f, FsPermission permission,
            boolean overwrite,
            int bufferSize, short replication, long blockSize, 
            Progressable progress) throws IOException {
          return new FSDataOutputStream
              (dfs.create(getPathName(f), permission, 
                          overwrite, false, replication, blockSize, progress, bufferSize), 
               statistics);
        }
      

      Needs a statistics.incrementWriteOps(1);

      1. hadoop-7870.patch
        0.7 kB
        Jonathan Hsieh

        Activity

        Hide
        jmhsieh Jonathan Hsieh added a comment -

        trivial patch.

        Show
        jmhsieh Jonathan Hsieh added a comment - trivial patch.
        Hide
        jmhsieh Jonathan Hsieh added a comment -

        trivial patch.

        Show
        jmhsieh Jonathan Hsieh added a comment - trivial patch.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12505953/hadoop-7870.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/428//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12505953/hadoop-7870.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/428//console This message is automatically generated.
        Hide
        tlipcon Todd Lipcon added a comment -

        +1, I'll commit this to branch-1.0 momentarily.

        Show
        tlipcon Todd Lipcon added a comment - +1, I'll commit this to branch-1.0 momentarily.
        Hide
        tlipcon Todd Lipcon added a comment -

        Committed to branch-1 (not branch-1.0 as I said above. still getting used to these new names)

        Show
        tlipcon Todd Lipcon added a comment - Committed to branch-1 ( not branch-1.0 as I said above. still getting used to these new names)
        Hide
        mattf Matt Foley added a comment -

        Closed upon release of Hadoop-1.1.0.

        Show
        mattf Matt Foley added a comment - Closed upon release of Hadoop-1.1.0.

          People

          • Assignee:
            jmhsieh Jonathan Hsieh
            Reporter:
            jmhsieh Jonathan Hsieh
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development