Hadoop Common
  1. Hadoop Common
  2. HADOOP-7878

Regression HADOOP-7777 switch changes break HDFS tests when the isSingleSwitch() predicate is used

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.23.0, 0.24.0
    • Fix Version/s: 0.23.1
    • Component/s: util
    • Labels:

      Description

      This doesn't show up until you apply the HDFS-2492 patch, but the attempt to make the StaticMapping topology clever by deciding if it is single rack or multi rack based on its rack->node mapping breaks the HDFS TestBlocksWithNotEnoughRacks test. Why? Because the racks go in after the switch topology is cached by the BlockManager, which assumes the system is always single-switch.

      Fix: default to assuming multi-switch; remove the intelligence, add a setter for anyone who really wants to simulate single-switch racks.

      Test: verify that a newly created simple mapping is multi switch

      1. HADOOP-7878.patch
        3 kB
        Steve Loughran
      2. HADOOP-7878.patch
        3 kB
        Steve Loughran

        Issue Links

          Activity

          Steve Loughran created issue -
          Steve Loughran made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          Steve Loughran made changes -
          Attachment HADOOP-7878.patch [ 12505897 ]
          Steve Loughran made changes -
          Link This issue relates to HADOOP-7777 [ HADOOP-7777 ]
          Steve Loughran made changes -
          Target Version/s 0.24.0, 0.23.0 [ 12317652, 12315569 ] 0.23.0, 0.24.0 [ 12315569, 12317652 ]
          Priority Major [ 3 ] Minor [ 4 ]
          Steve Loughran made changes -
          Status In Progress [ 3 ] Patch Available [ 10002 ]
          Target Version/s 0.24.0, 0.23.0 [ 12317652, 12315569 ] 0.23.0, 0.24.0 [ 12315569, 12317652 ]
          Steve Loughran made changes -
          Link This issue blocks HDFS-2492 [ HDFS-2492 ]
          Steve Loughran made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Target Version/s 0.24.0, 0.23.0 [ 12317652, 12315569 ] 0.23.0, 0.24.0 [ 12315569, 12317652 ]
          Steve Loughran made changes -
          Attachment HADOOP-7878.patch [ 12506853 ]
          Steve Loughran made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Target Version/s 0.24.0, 0.23.0 [ 12317652, 12315569 ] 0.23.0, 0.24.0 [ 12315569, 12317652 ]
          Steve Loughran made changes -
          Summary Regression HADOOP-7777 switch changes too clever for the StaticMapping Regression HADOOP-7777 switch changes break HDFS tests when the isSingleSwitch() predicate is used
          Target Version/s 0.24.0, 0.23.0 [ 12317652, 12315569 ] 0.24.0, 0.23.1 [ 12317652, 12318884 ]
          Steve Loughran made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Target Version/s 0.23.1, 0.24.0 [ 12318884, 12317652 ] 0.24.0, 0.23.1 [ 12317652, 12318884 ]
          Fix Version/s 0.24.0 [ 12317652 ]
          Fix Version/s 0.23.1 [ 12318884 ]
          Resolution Fixed [ 1 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Link This issue blocks HDFS-2492 [ HDFS-2492 ]
          Gavin made changes -
          Link This issue is depended upon by HDFS-2492 [ HDFS-2492 ]
          Allen Wittenauer made changes -
          Fix Version/s 0.24.0 [ 12317652 ]

            People

            • Assignee:
              Steve Loughran
              Reporter:
              Steve Loughran
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 0.5h
                0.5h
                Remaining:
                Remaining Estimate - 0.5h
                0.5h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development