Hadoop Common
  1. Hadoop Common
  2. HADOOP-7876

Allow access to BlockKey/DelegationKey encoded key for RPC over protobuf

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-alpha
    • Component/s: ipc
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In order to support RPC over protobuf, the BlockKey needs to provide access to encoded key. The byte[] encoded key will be transported over protobuf as byte[], instead of SecretKey.

      1. HADOOP-7876.txt
        1 kB
        Suresh Srinivas
      2. HADOOP-7876.txt
        1 kB
        Suresh Srinivas
      3. HADOOP-7876.txt
        1 kB
        Suresh Srinivas
      4. HADOOP-7876.txt
        1 kB
        Suresh Srinivas

        Issue Links

          Activity

          Suresh Srinivas created issue -
          Hide
          Suresh Srinivas added a comment -

          Attached patch provides access to encoded key from DelegationKey.

          Show
          Suresh Srinivas added a comment - Attached patch provides access to encoded key from DelegationKey.
          Suresh Srinivas made changes -
          Field Original Value New Value
          Attachment HADOOP-7876.txt [ 12505742 ]
          Suresh Srinivas made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Suresh Srinivas made changes -
          Link This issue blocks HDFS-2618 [ HDFS-2618 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12505742/HADOOP-7876.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 javadoc. The javadoc tool appears to have generated 15 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/423//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/423//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12505742/HADOOP-7876.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 15 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/423//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/423//console This message is automatically generated.
          Hide
          Suresh Srinivas added a comment -

          Fixed getEncodeKey to getEncodedKey

          Show
          Suresh Srinivas added a comment - Fixed getEncodeKey to getEncodedKey
          Suresh Srinivas made changes -
          Attachment HADOOP-7876.txt [ 12505745 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12505745/HADOOP-7876.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 javadoc. The javadoc tool appears to have generated 15 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/424//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/424//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12505745/HADOOP-7876.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 15 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/424//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/424//console This message is automatically generated.
          Hide
          Jitendra Nath Pandey added a comment -
          1. Please change the existing constructor to use the new constructor.
          2. Javadoc for public methods.
          Show
          Jitendra Nath Pandey added a comment - Please change the existing constructor to use the new constructor. Javadoc for public methods.
          Hide
          Suresh Srinivas added a comment -

          Updated patch.

          Show
          Suresh Srinivas added a comment - Updated patch.
          Suresh Srinivas made changes -
          Attachment HADOOP-7876.txt [ 12505838 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12505838/HADOOP-7876.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/425//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12505838/HADOOP-7876.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/425//console This message is automatically generated.
          Hide
          Suresh Srinivas added a comment -

          Updated patch.

          Show
          Suresh Srinivas added a comment - Updated patch.
          Suresh Srinivas made changes -
          Attachment HADOOP-7876.txt [ 12505841 ]
          Hide
          Jitendra Nath Pandey added a comment -

          +1

          Show
          Jitendra Nath Pandey added a comment - +1
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12505841/HADOOP-7876.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 javadoc. The javadoc tool appears to have generated 15 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/426//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/426//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12505841/HADOOP-7876.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 15 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/426//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/426//console This message is automatically generated.
          Hide
          Suresh Srinivas added a comment -

          Javadoc warning is unrelated. Test not added because, the patch adds just accessor. Committed the patch.

          Show
          Suresh Srinivas added a comment - Javadoc warning is unrelated. Test not added because, the patch adds just accessor. Committed the patch.
          Suresh Srinivas made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1438 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1438/)
          HADOOP-7876. Provided access to encoded key in DelegationKey for use in protobuf based RPCs. Contributed by Suresh Srinivas.

          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210320
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/DelegationKey.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1438 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1438/ ) HADOOP-7876 . Provided access to encoded key in DelegationKey for use in protobuf based RPCs. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210320 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/DelegationKey.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1364 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1364/)
          HADOOP-7876. Provided access to encoded key in DelegationKey for use in protobuf based RPCs. Contributed by Suresh Srinivas.

          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210320
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/DelegationKey.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1364 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1364/ ) HADOOP-7876 . Provided access to encoded key in DelegationKey for use in protobuf based RPCs. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210320 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/DelegationKey.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1389 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1389/)
          HADOOP-7876. Provided access to encoded key in DelegationKey for use in protobuf based RPCs. Contributed by Suresh Srinivas.

          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210320
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/DelegationKey.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1389 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1389/ ) HADOOP-7876 . Provided access to encoded key in DelegationKey for use in protobuf based RPCs. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210320 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/DelegationKey.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #885 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/885/)
          HADOOP-7876. Provided access to encoded key in DelegationKey for use in protobuf based RPCs. Contributed by Suresh Srinivas.

          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210320
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/DelegationKey.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #885 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/885/ ) HADOOP-7876 . Provided access to encoded key in DelegationKey for use in protobuf based RPCs. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210320 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/DelegationKey.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #918 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/918/)
          HADOOP-7876. Provided access to encoded key in DelegationKey for use in protobuf based RPCs. Contributed by Suresh Srinivas.

          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210320
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/DelegationKey.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #918 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/918/ ) HADOOP-7876 . Provided access to encoded key in DelegationKey for use in protobuf based RPCs. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210320 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/DelegationKey.java
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have merged this to 0.23.

          Show
          Tsz Wo Nicholas Sze added a comment - I have merged this to 0.23.
          Tsz Wo Nicholas Sze made changes -
          Fix Version/s 0.23.3 [ 12320059 ]
          Arun C Murthy made changes -
          Fix Version/s 2.0.0 [ 12320352 ]
          Fix Version/s 0.24.0 [ 12317652 ]
          Fix Version/s 0.23.3 [ 12320059 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Link This issue blocks HDFS-2618 [ HDFS-2618 ]
          Gavin made changes -
          Link This issue is depended upon by HDFS-2618 [ HDFS-2618 ]
          liangzhuxun made changes -
          Summary Allow access to BlockKey/DelegationKey endoded key for RPC over protobuf Allow access to BlockKey/DelegationKey encoded key for RPC over protobuf
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          11m 5s 1 Suresh Srinivas 01/Dec/11 09:15
          Patch Available Patch Available Resolved Resolved
          3d 18h 25m 1 Suresh Srinivas 05/Dec/11 03:41
          Resolved Resolved Closed Closed
          170d 16h 34m 1 Arun C Murthy 23/May/12 21:15

            People

            • Assignee:
              Suresh Srinivas
              Reporter:
              Suresh Srinivas
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development