Hadoop Common
  1. Hadoop Common
  2. HADOOP-7875

Add helper class to unwrap RemoteException from ServiceException thrown on protobuf based RPC

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-alpha
    • Component/s: ipc
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. HADOOP-7875.txt
      2 kB
      Suresh Srinivas
    2. HADOOP-7875.txt
      2 kB
      Suresh Srinivas

      Issue Links

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12505739/HADOOP-7875.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javadoc. The javadoc tool appears to have generated 15 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/422//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/422//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12505739/HADOOP-7875.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 15 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/422//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/422//console This message is automatically generated.
        Hide
        Jitendra Nath Pandey added a comment -

        In javadoc: @return IOException on error to get RemoteException
        It returns IOException in any case.

        +1 otherwise.

        Show
        Jitendra Nath Pandey added a comment - In javadoc: @return IOException on error to get RemoteException It returns IOException in any case. +1 otherwise.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12506077/HADOOP-7875.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javadoc. The javadoc tool appears to have generated 9 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/433//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/433//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12506077/HADOOP-7875.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 9 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/433//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/433//console This message is automatically generated.
        Hide
        Suresh Srinivas added a comment -

        javadoc warnings are unrelated.

        Show
        Suresh Srinivas added a comment - javadoc warnings are unrelated.
        Hide
        Suresh Srinivas added a comment -

        I committed the patch. The patch is fairly simple, hence it has not tests. This will also be tested as part of protobuf RPCs.

        Show
        Suresh Srinivas added a comment - I committed the patch. The patch is fairly simple, hence it has not tests. This will also be tested as part of protobuf RPCs.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1437 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1437/)
        HADOOP-7875. Add helper class to unwrap protobuf ServiceException. Contributed by Suresh Srinivas.

        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210319
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufHelper.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1437 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1437/ ) HADOOP-7875 . Add helper class to unwrap protobuf ServiceException. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210319 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufHelper.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1363 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1363/)
        HADOOP-7875. Add helper class to unwrap protobuf ServiceException. Contributed by Suresh Srinivas.

        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210319
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufHelper.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1363 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1363/ ) HADOOP-7875 . Add helper class to unwrap protobuf ServiceException. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210319 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufHelper.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1388 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1388/)
        HADOOP-7875. Add helper class to unwrap protobuf ServiceException. Contributed by Suresh Srinivas.

        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210319
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufHelper.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1388 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1388/ ) HADOOP-7875 . Add helper class to unwrap protobuf ServiceException. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210319 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufHelper.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #885 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/885/)
        HADOOP-7875. Add helper class to unwrap protobuf ServiceException. Contributed by Suresh Srinivas.

        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210319
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufHelper.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #885 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/885/ ) HADOOP-7875 . Add helper class to unwrap protobuf ServiceException. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210319 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufHelper.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #918 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/918/)
        HADOOP-7875. Add helper class to unwrap protobuf ServiceException. Contributed by Suresh Srinivas.

        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210319
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufHelper.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #918 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/918/ ) HADOOP-7875 . Add helper class to unwrap protobuf ServiceException. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210319 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufHelper.java
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have merged this to 0.23.

        Show
        Tsz Wo Nicholas Sze added a comment - I have merged this to 0.23.

          People

          • Assignee:
            Suresh Srinivas
            Reporter:
            Suresh Srinivas
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development