Hadoop Common
  1. Hadoop Common
  2. HADOOP-7833

Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-alpha
    • Component/s: ipc
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      findbugs reports the following medium priority warnings for some inner class in the generated class ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:

      • SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable class
      • SE_BAD_FIELD: Non-transient non-serializable instance field in serializable class
      • UCF_USELESS_CONTROL_FLOW: Useless control flow

      This can be fixed by adding the following findbugs exclude filter:

      + <Match>
      + <!-- protobuf generated code -->
      + <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
      + </Match>

      which will exclude all inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos

      1. HADOOP-7833.patch
        0.6 kB
        John Lee
      2. HADOOP-7833.patch
        0.6 kB
        John Lee

        Activity

        John Lee created issue -
        John Lee made changes -
        Field Original Value New Value
        Attachment HADOOP-7833.patch [ 12504144 ]
        John Lee made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        John Lee made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        John Lee made changes -
        Attachment HADOOP-7833.patch [ 12504275 ]
        John Lee made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Suresh Srinivas made changes -
        Hadoop Flags Reviewed [ 10343 ]
        Assignee John Lee [ jlee@mindset-media.com ]
        Fix Version/s 0.24.0 [ 12317652 ]
        Target Version/s 0.24.0 [ 12317652 ]
        Priority Blocker [ 1 ] Major [ 3 ]
        Suresh Srinivas made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Tsz Wo Nicholas Sze made changes -
        Fix Version/s 0.23.3 [ 12320059 ]
        Component/s ipc [ 12310688 ]
        Arun C Murthy made changes -
        Fix Version/s 2.0.0 [ 12320352 ]
        Fix Version/s 0.24.0 [ 12317652 ]
        Fix Version/s 0.23.3 [ 12320059 ]
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            John Lee
            Reporter:
            John Lee
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development