Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-7833

Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-alpha
    • Component/s: ipc
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      findbugs reports the following medium priority warnings for some inner class in the generated class ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:

      • SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable class
      • SE_BAD_FIELD: Non-transient non-serializable instance field in serializable class
      • UCF_USELESS_CONTROL_FLOW: Useless control flow

      This can be fixed by adding the following findbugs exclude filter:

      + <Match>
      + <!-- protobuf generated code -->
      + <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
      + </Match>

      which will exclude all inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos

        Attachments

        1. HADOOP-7833.patch
          0.6 kB
          John Lee
        2. HADOOP-7833.patch
          0.6 kB
          John Lee

          Activity

            People

            • Assignee:
              jlee@mindset-media.com John Lee
              Reporter:
              jlee@mindset-media.com John Lee
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: