Hadoop Common
  1. Hadoop Common
  2. HADOOP-7816

Allow HADOOP_HOME deprecated warning suppression based on config specified in hadoop-env.sh

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.20.205.0
    • Fix Version/s: 1.0.0
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed
    • Tags:
      HADOOP_HOME_WARN_SUPPRESS

      Description

      Move suppression check for "Warning: $HADOOP_HOME is deprecated" to after sourcing of hadoop-env.sh so that people can set HADOOP_HOME_WARN_SUPPRESS inside the config.

        Issue Links

          Activity

          Hide
          Dave Thompson added a comment -

          The attached patch changes the order of the warning check to occur after the sourcing of hadoop-env.sh so that the warning suppression setting can occur in hadoop-env.sh

          Show
          Dave Thompson added a comment - The attached patch changes the order of the warning check to occur after the sourcing of hadoop-env.sh so that the warning suppression setting can occur in hadoop-env.sh
          Hide
          Dave Thompson added a comment -

          The submitted patch changes the order of the warning suppression check (HADOOP_HOME_WARN_SUPPRESS) to occur after the sourcing of hadoop-env.sh so that the warning suppression setting can occur in hadoop-env.sh.

          This is related to HADOOP-7398

          Show
          Dave Thompson added a comment - The submitted patch changes the order of the warning suppression check (HADOOP_HOME_WARN_SUPPRESS) to occur after the sourcing of hadoop-env.sh so that the warning suppression setting can occur in hadoop-env.sh. This is related to HADOOP-7398
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12503406/rel-0.20.205.0-rc1_hadoop7816.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/373//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12503406/rel-0.20.205.0-rc1_hadoop7816.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/373//console This message is automatically generated.
          Hide
          Dave Thompson added a comment -

          Regarding HadoopQA comments:

          1) No tests included/changed. The patch merely changes the order of a small code segment in bin/hadoop. Testing was done by running a hadoop fs -ls, with HADOOP_HOME_WARN_SUPPRESS turned on and turned off.

          2) Regarding patch, this patch was done against the tagged version rel-0.20.205.0-rc1. Failure to patch against trunk is not unexpected.

          Show
          Dave Thompson added a comment - Regarding HadoopQA comments: 1) No tests included/changed. The patch merely changes the order of a small code segment in bin/hadoop. Testing was done by running a hadoop fs -ls, with HADOOP_HOME_WARN_SUPPRESS turned on and turned off. 2) Regarding patch, this patch was done against the tagged version rel-0.20.205.0-rc1. Failure to patch against trunk is not unexpected.
          Hide
          Suresh Srinivas added a comment -

          +1 for the change.

          Show
          Suresh Srinivas added a comment - +1 for the change.
          Hide
          Suresh Srinivas added a comment -

          Dave, is this relevant to trunk? If so could you please attach a trunk patch?

          Show
          Suresh Srinivas added a comment - Dave, is this relevant to trunk? If so could you please attach a trunk patch?
          Hide
          Suresh Srinivas added a comment -

          I committed the patch and marking the jira as resolved. Dave, please reopen this bug to attach trunk patch, if trunk requires this change as well.

          Show
          Suresh Srinivas added a comment - I committed the patch and marking the jira as resolved. Dave, please reopen this bug to attach trunk patch, if trunk requires this change as well.
          Hide
          Dave Thompson added a comment -

          Thanks Suresh. It appears that HADOOP-7398 hasn't been applied to trunk, nor does it seem to need to. As such this issue shouldn't be necessary for trunk as well.

          Show
          Dave Thompson added a comment - Thanks Suresh. It appears that HADOOP-7398 hasn't been applied to trunk, nor does it seem to need to. As such this issue shouldn't be necessary for trunk as well.
          Hide
          Matt Foley added a comment -

          Corrected the Target and Fixed fields.

          Show
          Matt Foley added a comment - Corrected the Target and Fixed fields.
          Hide
          Matt Foley added a comment -

          Closed upon release of version 1.0.0.

          Show
          Matt Foley added a comment - Closed upon release of version 1.0.0.

            People

            • Assignee:
              Dave Thompson
              Reporter:
              Dave Thompson
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Due:
                Created:
                Updated:
                Resolved:

                Development