Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-7813

test-patch +1 patches that introduce javadoc and findbugs warnings in some cases

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.1, 0.24.0
    • Fix Version/s: 0.23.1
    • Component/s: build, test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      test-patch.sh uses string comparisons of numbers to decide whether to +1 for javadoc and findbugs warnings.

      decisions are made using the following construct

      [[ $A > $B ]]

      Brackets put the script into conditional expression mode

      Operator definition for conditional expression mode
      string1 > string2
      True if string1 sorts after string2 lexicographically in the current locale.

      Examples
      $ sh -c 'if [[ 99 > 100 ]]; then echo true; fi'
      true

      $ sh -c 'if [[ -99 > -10 ]]; then echo true; fi'
      true

      Arithmetic operations in conditional expressions are defined below
      arg1 OP arg2
      OP is one of -eq, -ne, -lt, -le, -gt, or -ge. These arithmetic binary operators return true if arg1 is equal to, not equal to, less than, less than or equal to, greater than, or greater than or equal to arg2, respectively. Arg1 and arg2 may be positive or negative integers.

      Alternatively arithmetic evaluation mode can be entered using double parenthesis "(( .. ))"

        Attachments

        1. HADOOP-7813.patch
          1 kB
          Jonathan Eagles

          Activity

            People

            • Assignee:
              jeagles Jonathan Eagles
              Reporter:
              jeagles Jonathan Eagles
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: