Hadoop Common
  1. Hadoop Common
  2. HADOOP-7813

test-patch +1 patches that introduce javadoc and findbugs warnings in some cases

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.1, 0.24.0
    • Fix Version/s: 0.23.1, 0.24.0
    • Component/s: build, test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      test-patch.sh uses string comparisons of numbers to decide whether to +1 for javadoc and findbugs warnings.

      decisions are made using the following construct

      [[ $A > $B ]]

      Brackets put the script into conditional expression mode

      Operator definition for conditional expression mode
      string1 > string2
      True if string1 sorts after string2 lexicographically in the current locale.

      Examples
      $ sh -c 'if [[ 99 > 100 ]]; then echo true; fi'
      true

      $ sh -c 'if [[ -99 > -10 ]]; then echo true; fi'
      true

      Arithmetic operations in conditional expressions are defined below
      arg1 OP arg2
      OP is one of -eq, -ne, -lt, -le, -gt, or -ge. These arithmetic binary operators return true if arg1 is equal to, not equal to, less than, less than or equal to, greater than, or greater than or equal to arg2, respectively. Arg1 and arg2 may be positive or negative integers.

      Alternatively arithmetic evaluation mode can be entered using double parenthesis "(( .. ))"

      1. HADOOP-7813.patch
        1 kB
        Jonathan Eagles

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #983 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/983/)
        HADOOP-7813. Added to CHANGES.txt

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241714
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #983 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/983/ ) HADOOP-7813 . Added to CHANGES.txt acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241714 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #185 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/185/)
        HADOOP-7813. Added to CHANGES.txt

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241715
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #185 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/185/ ) HADOOP-7813 . Added to CHANGES.txt acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241715 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #163 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/163/)
        HADOOP-7813. Added to CHANGES.txt

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241715
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #163 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/163/ ) HADOOP-7813 . Added to CHANGES.txt acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241715 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #950 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/950/)
        HADOOP-7813. Added to CHANGES.txt

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241714
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #950 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/950/ ) HADOOP-7813 . Added to CHANGES.txt acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241714 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #520 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/520/)
        HADOOP-7813. Added to CHANGES.txt

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241715
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #520 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/520/ ) HADOOP-7813 . Added to CHANGES.txt acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241715 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1699 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1699/)
        HADOOP-7813. Added to CHANGES.txt

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241714
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1699 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1699/ ) HADOOP-7813 . Added to CHANGES.txt acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241714 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #503 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/503/)
        HADOOP-7813. Added to CHANGES.txt

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241715
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #503 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/503/ ) HADOOP-7813 . Added to CHANGES.txt acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241715 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1687 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1687/)
        HADOOP-7813. Added to CHANGES.txt

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241714
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1687 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1687/ ) HADOOP-7813 . Added to CHANGES.txt acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241714 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #514 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/514/)
        HADOOP-7813. Added to CHANGES.txt

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241715
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #514 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/514/ ) HADOOP-7813 . Added to CHANGES.txt acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241715 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1760 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1760/)
        HADOOP-7813. Added to CHANGES.txt

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241714
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1760 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1760/ ) HADOOP-7813 . Added to CHANGES.txt acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241714 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #895 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/895/)
        HADOOP-7813. Fix test-patch to use proper numerical comparison when checking javadoc and findbugs warning counts. Contributed by Jonathan Eagles.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201056
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #895 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/895/ ) HADOOP-7813 . Fix test-patch to use proper numerical comparison when checking javadoc and findbugs warning counts. Contributed by Jonathan Eagles. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201056 Files : /hadoop/common/trunk/dev-support/test-patch.sh
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #91 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/91/)
        HADOOP-7813. Fix test-patch to use proper numerical comparison when checking javadoc and findbugs warning counts. Contributed by Jonathan Eagles.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201055
        Files :

        • /hadoop/common/branches/branch-0.23/dev-support/test-patch.sh
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #91 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/91/ ) HADOOP-7813 . Fix test-patch to use proper numerical comparison when checking javadoc and findbugs warning counts. Contributed by Jonathan Eagles. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201055 Files : /hadoop/common/branches/branch-0.23/dev-support/test-patch.sh
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #861 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/861/)
        HADOOP-7813. Fix test-patch to use proper numerical comparison when checking javadoc and findbugs warning counts. Contributed by Jonathan Eagles.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201056
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #861 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/861/ ) HADOOP-7813 . Fix test-patch to use proper numerical comparison when checking javadoc and findbugs warning counts. Contributed by Jonathan Eagles. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201056 Files : /hadoop/common/trunk/dev-support/test-patch.sh
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #74 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/74/)
        HADOOP-7813. Fix test-patch to use proper numerical comparison when checking javadoc and findbugs warning counts. Contributed by Jonathan Eagles.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201055
        Files :

        • /hadoop/common/branches/branch-0.23/dev-support/test-patch.sh
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #74 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/74/ ) HADOOP-7813 . Fix test-patch to use proper numerical comparison when checking javadoc and findbugs warning counts. Contributed by Jonathan Eagles. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201055 Files : /hadoop/common/branches/branch-0.23/dev-support/test-patch.sh
        Hide
        Jonathan Eagles added a comment -

        Thanks, Todd.

        This is one of those checks that it is so easy to miss. I only caught this by accident when I got test-patch result like "-1 findbugs you have introduce -4 javadoc warnings"

        Show
        Jonathan Eagles added a comment - Thanks, Todd. This is one of those checks that it is so easy to miss. I only caught this by accident when I got test-patch result like "-1 findbugs you have introduce -4 javadoc warnings"
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #178 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/178/)
        HADOOP-7813. Fix test-patch to use proper numerical comparison when checking javadoc and findbugs warning counts. Contributed by Jonathan Eagles.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201055
        Files :

        • /hadoop/common/branches/branch-0.23/dev-support/test-patch.sh
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #178 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/178/ ) HADOOP-7813 . Fix test-patch to use proper numerical comparison when checking javadoc and findbugs warning counts. Contributed by Jonathan Eagles. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201055 Files : /hadoop/common/branches/branch-0.23/dev-support/test-patch.sh
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1289 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1289/)
        HADOOP-7813. Fix test-patch to use proper numerical comparison when checking javadoc and findbugs warning counts. Contributed by Jonathan Eagles.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201056
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1289 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1289/ ) HADOOP-7813 . Fix test-patch to use proper numerical comparison when checking javadoc and findbugs warning counts. Contributed by Jonathan Eagles. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201056 Files : /hadoop/common/trunk/dev-support/test-patch.sh
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1341 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1341/)
        HADOOP-7813. Fix test-patch to use proper numerical comparison when checking javadoc and findbugs warning counts. Contributed by Jonathan Eagles.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201056
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1341 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1341/ ) HADOOP-7813 . Fix test-patch to use proper numerical comparison when checking javadoc and findbugs warning counts. Contributed by Jonathan Eagles. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201056 Files : /hadoop/common/trunk/dev-support/test-patch.sh
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1267 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1267/)
        HADOOP-7813. Fix test-patch to use proper numerical comparison when checking javadoc and findbugs warning counts. Contributed by Jonathan Eagles.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201056
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1267 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1267/ ) HADOOP-7813 . Fix test-patch to use proper numerical comparison when checking javadoc and findbugs warning counts. Contributed by Jonathan Eagles. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201056 Files : /hadoop/common/trunk/dev-support/test-patch.sh
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #167 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/167/)
        HADOOP-7813. Fix test-patch to use proper numerical comparison when checking javadoc and findbugs warning counts. Contributed by Jonathan Eagles.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201055
        Files :

        • /hadoop/common/branches/branch-0.23/dev-support/test-patch.sh
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #167 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/167/ ) HADOOP-7813 . Fix test-patch to use proper numerical comparison when checking javadoc and findbugs warning counts. Contributed by Jonathan Eagles. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201055 Files : /hadoop/common/branches/branch-0.23/dev-support/test-patch.sh
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #166 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/166/)
        HADOOP-7813. Fix test-patch to use proper numerical comparison when checking javadoc and findbugs warning counts. Contributed by Jonathan Eagles.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201055
        Files :

        • /hadoop/common/branches/branch-0.23/dev-support/test-patch.sh
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #166 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/166/ ) HADOOP-7813 . Fix test-patch to use proper numerical comparison when checking javadoc and findbugs warning counts. Contributed by Jonathan Eagles. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201055 Files : /hadoop/common/branches/branch-0.23/dev-support/test-patch.sh
        Hide
        Todd Lipcon added a comment -

        Fixed in trunk and branch-23 for 0.23.1. Thanks Jonathan!

        Show
        Todd Lipcon added a comment - Fixed in trunk and branch-23 for 0.23.1. Thanks Jonathan!
        Hide
        Todd Lipcon added a comment -

        doh, good catch! +1

        Show
        Todd Lipcon added a comment - doh, good catch! +1
        Hide
        Jonathan Eagles added a comment -

        manual tests of running the new test-patch show new features to be working.

        Show
        Jonathan Eagles added a comment - manual tests of running the new test-patch show new features to be working.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12503250/HADOOP-7813.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/372//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12503250/HADOOP-7813.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/372//console This message is automatically generated.

          People

          • Assignee:
            Jonathan Eagles
            Reporter:
            Jonathan Eagles
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development