Hadoop Common
  1. Hadoop Common
  2. HADOOP-7813

test-patch +1 patches that introduce javadoc and findbugs warnings in some cases

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.1, 0.24.0
    • Fix Version/s: 0.23.1
    • Component/s: build, test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      test-patch.sh uses string comparisons of numbers to decide whether to +1 for javadoc and findbugs warnings.

      decisions are made using the following construct

      [[ $A > $B ]]

      Brackets put the script into conditional expression mode

      Operator definition for conditional expression mode
      string1 > string2
      True if string1 sorts after string2 lexicographically in the current locale.

      Examples
      $ sh -c 'if [[ 99 > 100 ]]; then echo true; fi'
      true

      $ sh -c 'if [[ -99 > -10 ]]; then echo true; fi'
      true

      Arithmetic operations in conditional expressions are defined below
      arg1 OP arg2
      OP is one of -eq, -ne, -lt, -le, -gt, or -ge. These arithmetic binary operators return true if arg1 is equal to, not equal to, less than, less than or equal to, greater than, or greater than or equal to arg2, respectively. Arg1 and arg2 may be positive or negative integers.

      Alternatively arithmetic evaluation mode can be entered using double parenthesis "(( .. ))"

      1. HADOOP-7813.patch
        1 kB
        Jonathan Eagles

        Activity

        Jonathan Eagles created issue -
        Jonathan Eagles made changes -
        Field Original Value New Value
        Attachment HADOOP-7813.patch [ 12503250 ]
        Jonathan Eagles made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Jonathan Eagles made changes -
        Summary test-patch +1 patches that introduce javadoc and findbugs warnings in somecases test-patch +1 patches that introduce javadoc and findbugs warnings in some cases
        Todd Lipcon made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 0.24.0 [ 12317652 ]
        Fix Version/s 0.23.1 [ 12318884 ]
        Resolution Fixed [ 1 ]
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Allen Wittenauer made changes -
        Fix Version/s 0.24.0 [ 12317652 ]

          People

          • Assignee:
            Jonathan Eagles
            Reporter:
            Jonathan Eagles
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development