Hadoop Common
  1. Hadoop Common
  2. HADOOP-7798

Release artifacts need to be signed for Nexus

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: build
    • Labels:
      None

      Description

      When I uploaded hadoop-0.23.0-rc1 artifacts to Nexus it complains that artifacts aren't signed. Hence I won't be able push the release jars after the vote.

      1. mvn-gpg.patch
        3 kB
        Arun C Murthy
      2. mvn-gpg.patch
        3 kB
        Arun C Murthy
      3. HADOOP-7798.patch
        30 kB
        Doug Cutting

        Activity

        Arun C Murthy created issue -
        Hide
        Doug Cutting added a comment -

        In Avro I'm able to push the candidate jars to Nexus with:

        mvn -P dist,sign deploy -DskipTests=true -Dgpg.passphrase=XXX -Davro.version=X.Y.Z

        where the 'sign' profile is:

            <profile>
              <id>sign</id>
              <build>
                <plugins>
                  <plugin>
                    <groupId>org.apache.maven.plugins</groupId>
                    <artifactId>maven-gpg-plugin</artifactId>
                    <executions>
                      <execution>
                        <id>sign-artifacts</id>
                        <phase>verify</phase>
                        <goals>
        	          <goal>sign</goal>
                        </goals>
                      </execution>
                    </executions>
                  </plugin>
                </plugins>
              </build>
            </profile>
        
        Show
        Doug Cutting added a comment - In Avro I'm able to push the candidate jars to Nexus with: mvn -P dist,sign deploy -DskipTests=true -Dgpg.passphrase=XXX -Davro.version=X.Y.Z where the 'sign' profile is: <profile> <id>sign</id> <build> <plugins> <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-gpg-plugin</artifactId> <executions> <execution> <id>sign-artifacts</id> <phase>verify</phase> <goals> <goal>sign</goal> </goals> </execution> </executions> </plugin> </plugins> </build> </profile>
        Hide
        Arun C Murthy added a comment -

        Thanks Doug, do you mind providing it as a patch?

        Show
        Arun C Murthy added a comment - Thanks Doug, do you mind providing it as a patch?
        Hide
        Doug Cutting added a comment -

        Here's a patch for the 0.23 branch that works for me. Just adding the profiles isn't enough. It seems you can't stage stuff named *-SNAPSHOT either. Also, the Maven versions plugin doesn't seem to like it when the version is repeated in the child, but you need to name the parent's version.

        With this, 'mvn -P dist,sign deploy -DskipTests -Dgpg.passphrase=XXX' works for me, staging a release at https://repository.apache.org/ that I can close, including source and documentation jars, everything signed, etc.

        After this, to change the version, you can edit the version in the top-level pom.xml then use 'mvn versions:update-child-modules' to propagate that to all of the children. There are a few other files that unfortunately contain the version too...

        Show
        Doug Cutting added a comment - Here's a patch for the 0.23 branch that works for me. Just adding the profiles isn't enough. It seems you can't stage stuff named *-SNAPSHOT either. Also, the Maven versions plugin doesn't seem to like it when the version is repeated in the child, but you need to name the parent's version. With this, 'mvn -P dist,sign deploy -DskipTests -Dgpg.passphrase=XXX' works for me, staging a release at https://repository.apache.org/ that I can close, including source and documentation jars, everything signed, etc. After this, to change the version, you can edit the version in the top-level pom.xml then use 'mvn versions:update-child-modules' to propagate that to all of the children. There are a few other files that unfortunately contain the version too...
        Doug Cutting made changes -
        Field Original Value New Value
        Attachment HADOOP-7798.patch [ 12502061 ]
        Hide
        Giridharan Kesavan added a comment -

        I think we can use the version plugin at the top level to change the version number

        mvn versions:set -DnewVersion=0.23.0
        

        this would update the version from 0.23.0-snapshot to 0.23.0

        Show
        Giridharan Kesavan added a comment - I think we can use the version plugin at the top level to change the version number mvn versions:set -DnewVersion=0.23.0 this would update the version from 0.23.0-snapshot to 0.23.0
        Hide
        Arun C Murthy added a comment -

        Since we use 'mvn versions:set' at top-level, I'm guessing we only need part of Doug's patch for the gpg plugin right?

        Show
        Arun C Murthy added a comment - Since we use 'mvn versions:set' at top-level, I'm guessing we only need part of Doug's patch for the gpg plugin right?
        Hide
        Arun C Murthy added a comment -

        Just the gpg plugin part of Doug's patch.

        Tested this with a push of rc1 and seems to work fine.

        Show
        Arun C Murthy added a comment - Just the gpg plugin part of Doug's patch. Tested this with a push of rc1 and seems to work fine.
        Arun C Murthy made changes -
        Attachment mvn-gpg.patch [ 12502101 ]
        Arun C Murthy made changes -
        Assignee Doug Cutting [ cutting ]
        Hide
        Arun C Murthy added a comment -

        Fixed avro refs.

        Show
        Arun C Murthy added a comment - Fixed avro refs.
        Arun C Murthy made changes -
        Attachment mvn-gpg.patch [ 12502104 ]
        Hide
        Bruno Mahé added a comment -

        +1 to latest mvn-gpg.patch

        Show
        Bruno Mahé added a comment - +1 to latest mvn-gpg.patch
        Hide
        Arun C Murthy added a comment -

        I just committed this. Thanks Doug!

        Also thanks to Giri and Bruno.

        Show
        Arun C Murthy added a comment - I just committed this. Thanks Doug! Also thanks to Giri and Bruno.
        Arun C Murthy made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #140 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/140/)
        HADOOP-7798. Fixed jira number in CHANGES.txt.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196967
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #140 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/140/ ) HADOOP-7798 . Fixed jira number in CHANGES.txt. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196967 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #141 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/141/)
        HADOOP-7798. Fixed jira number in CHANGES.txt.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196967
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #141 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/141/ ) HADOOP-7798 . Fixed jira number in CHANGES.txt. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196967 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1239 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1239/)
        HADOOP-7798. Fixed jira number in CHANGES.txt.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196966
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1239 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1239/ ) HADOOP-7798 . Fixed jira number in CHANGES.txt. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196966 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1314 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1314/)
        HADOOP-7798. Fixed jira number in CHANGES.txt.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196966
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1314 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1314/ ) HADOOP-7798 . Fixed jira number in CHANGES.txt. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196966 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1262 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1262/)
        HADOOP-7798. Fixed jira number in CHANGES.txt.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196966
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1262 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1262/ ) HADOOP-7798 . Fixed jira number in CHANGES.txt. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196966 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #153 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/153/)
        HADOOP-7798. Fixed jira number in CHANGES.txt.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196967
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #153 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/153/ ) HADOOP-7798 . Fixed jira number in CHANGES.txt. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196967 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #65 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/65/)
        HADOOP-7798. Fixed jira number in CHANGES.txt.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196967
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #65 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/65/ ) HADOOP-7798 . Fixed jira number in CHANGES.txt. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196967 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #852 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/852/)
        HADOOP-7798. Fixed jira number in CHANGES.txt.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196966
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #852 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/852/ ) HADOOP-7798 . Fixed jira number in CHANGES.txt. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196966 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #79 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/79/)
        HADOOP-7798. Fixed jira number in CHANGES.txt.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196967
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #79 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/79/ ) HADOOP-7798 . Fixed jira number in CHANGES.txt. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196967 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #886 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/886/)
        HADOOP-7798. Fixed jira number in CHANGES.txt.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196966
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #886 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/886/ ) HADOOP-7798 . Fixed jira number in CHANGES.txt. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196966 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        12h 20m 1 Arun C Murthy 03/Nov/11 06:32
        Resolved Resolved Closed Closed
        11d 18h 18m 1 Arun C Murthy 15/Nov/11 00:50

          People

          • Assignee:
            Doug Cutting
            Reporter:
            Arun C Murthy
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development