Hadoop Common
  1. Hadoop Common
  2. HADOOP-7786

Remove HDFS-specific configuration keys defined in FsConfig

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.1
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None

      Description

      HADOOP-4952 added a couple HDFS-specific configuration values to common (the block size and the replication factor) that conflict with the HDFS values (eg have the wrong defaults, wrong key name), are not used by common or hdfs and should be removed. After removing these I noticed the rest of FsConfig is only used once outside a test, and isn't tagged as a public API, I think we can remove it entirely.

      1. hadoop-7786-2.patch
        3 kB
        Eli Collins
      2. hadoop-7786-1.patch
        7 kB
        Eli Collins
      3. HDFS-1900.txt
        39 kB
        Abel Perez

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #885 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/885/)
          Remove FsConfig as intended in HADOOP-7786.
          HADOOP-7786. Remove HDFS-specific config keys defined in FsConfig. Contributed by Eli Collins

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196143
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsConfig.java

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196129
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/cluster_setup.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellReturnCode.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #885 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/885/ ) Remove FsConfig as intended in HADOOP-7786 . HADOOP-7786 . Remove HDFS-specific config keys defined in FsConfig. Contributed by Eli Collins eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196143 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsConfig.java eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196129 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/cluster_setup.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellReturnCode.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Build #78 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/78/)
          HADOOP-7786. svn merge -c 1196129 from trunk

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196136
          Files :

          • /hadoop/common/branches/branch-0.23
          • /hadoop/common/branches/branch-0.23/hadoop-common-project
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/cluster_setup.xml
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsConfig.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellReturnCode.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/.gitignore
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/streaming
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/FileBench.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/TestSequenceFileMergeProgress.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/security/authorize/TestServiceLevelAuthorization.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/test/MapredTestDriver.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #78 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/78/ ) HADOOP-7786 . svn merge -c 1196129 from trunk eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196136 Files : /hadoop/common/branches/branch-0.23 /hadoop/common/branches/branch-0.23/hadoop-common-project /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/cluster_setup.xml /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsConfig.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellReturnCode.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/.gitignore /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++ /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/streaming /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/FileBench.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/TestSequenceFileMergeProgress.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/security/authorize/TestServiceLevelAuthorization.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/test/MapredTestDriver.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #851 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/851/)
          Remove FsConfig as intended in HADOOP-7786.
          HADOOP-7786. Remove HDFS-specific config keys defined in FsConfig. Contributed by Eli Collins

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196143
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsConfig.java

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196129
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/cluster_setup.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellReturnCode.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #851 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/851/ ) Remove FsConfig as intended in HADOOP-7786 . HADOOP-7786 . Remove HDFS-specific config keys defined in FsConfig. Contributed by Eli Collins eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196143 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsConfig.java eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196129 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/cluster_setup.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellReturnCode.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #64 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/64/)
          HADOOP-7786. svn merge -c 1196129 from trunk

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196136
          Files :

          • /hadoop/common/branches/branch-0.23
          • /hadoop/common/branches/branch-0.23/hadoop-common-project
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/cluster_setup.xml
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsConfig.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellReturnCode.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/.gitignore
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/streaming
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/FileBench.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/TestSequenceFileMergeProgress.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/security/authorize/TestServiceLevelAuthorization.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/test/MapredTestDriver.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #64 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/64/ ) HADOOP-7786 . svn merge -c 1196129 from trunk eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196136 Files : /hadoop/common/branches/branch-0.23 /hadoop/common/branches/branch-0.23/hadoop-common-project /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/cluster_setup.xml /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsConfig.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellReturnCode.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/.gitignore /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++ /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/streaming /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/FileBench.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/TestSequenceFileMergeProgress.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/security/authorize/TestServiceLevelAuthorization.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/test/MapredTestDriver.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-22-branch #92 (See https://builds.apache.org/job/Hadoop-Common-22-branch/92/)
          HADOOP-7786. svn merge -c 1196129 from trunk

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196148
          Files :

          • /hadoop/common/branches/branch-0.22/common/CHANGES.txt
          • /hadoop/common/branches/branch-0.22/common/src/docs/src/documentation/content/xdocs/cluster_setup.xml
          • /hadoop/common/branches/branch-0.22/common/src/java/org/apache/hadoop/fs/FileContext.java
          • /hadoop/common/branches/branch-0.22/common/src/java/org/apache/hadoop/fs/FsConfig.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-22-branch #92 (See https://builds.apache.org/job/Hadoop-Common-22-branch/92/ ) HADOOP-7786 . svn merge -c 1196129 from trunk eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196148 Files : /hadoop/common/branches/branch-0.22/common/CHANGES.txt /hadoop/common/branches/branch-0.22/common/src/docs/src/documentation/content/xdocs/cluster_setup.xml /hadoop/common/branches/branch-0.22/common/src/java/org/apache/hadoop/fs/FileContext.java /hadoop/common/branches/branch-0.22/common/src/java/org/apache/hadoop/fs/FsConfig.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Commit #140 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/140/)
          HADOOP-7786. svn merge -c 1196129 from trunk

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196136
          Files :

          • /hadoop/common/branches/branch-0.23
          • /hadoop/common/branches/branch-0.23/hadoop-common-project
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/cluster_setup.xml
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsConfig.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellReturnCode.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/.gitignore
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/streaming
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/FileBench.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/TestSequenceFileMergeProgress.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/security/authorize/TestServiceLevelAuthorization.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/test/MapredTestDriver.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #140 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/140/ ) HADOOP-7786 . svn merge -c 1196129 from trunk eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196136 Files : /hadoop/common/branches/branch-0.23 /hadoop/common/branches/branch-0.23/hadoop-common-project /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/cluster_setup.xml /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsConfig.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellReturnCode.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/.gitignore /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++ /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/streaming /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/FileBench.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/TestSequenceFileMergeProgress.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/security/authorize/TestServiceLevelAuthorization.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/test/MapredTestDriver.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1250 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1250/)
          Remove FsConfig as intended in HADOOP-7786.
          HADOOP-7786. Remove HDFS-specific config keys defined in FsConfig. Contributed by Eli Collins

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196143
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsConfig.java

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196129
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/cluster_setup.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellReturnCode.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1250 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1250/ ) Remove FsConfig as intended in HADOOP-7786 . HADOOP-7786 . Remove HDFS-specific config keys defined in FsConfig. Contributed by Eli Collins eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196143 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsConfig.java eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196129 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/cluster_setup.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellReturnCode.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1227 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1227/)
          Remove FsConfig as intended in HADOOP-7786.

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196143
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsConfig.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1227 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1227/ ) Remove FsConfig as intended in HADOOP-7786 . eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196143 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsConfig.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-0.23-Commit #130 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/130/)
          HADOOP-7786. svn merge -c 1196129 from trunk

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196136
          Files :

          • /hadoop/common/branches/branch-0.23
          • /hadoop/common/branches/branch-0.23/hadoop-common-project
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/cluster_setup.xml
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsConfig.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellReturnCode.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/.gitignore
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/streaming
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/FileBench.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/TestSequenceFileMergeProgress.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/security/authorize/TestServiceLevelAuthorization.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/test/MapredTestDriver.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
          Show
          Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #130 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/130/ ) HADOOP-7786 . svn merge -c 1196129 from trunk eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196136 Files : /hadoop/common/branches/branch-0.23 /hadoop/common/branches/branch-0.23/hadoop-common-project /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/cluster_setup.xml /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsConfig.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellReturnCode.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/.gitignore /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++ /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/streaming /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/FileBench.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/TestSequenceFileMergeProgress.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/security/authorize/TestServiceLevelAuthorization.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/test/MapredTestDriver.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1302 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1302/)
          Remove FsConfig as intended in HADOOP-7786.

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196143
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsConfig.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1302 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1302/ ) Remove FsConfig as intended in HADOOP-7786 . eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196143 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsConfig.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Commit #131 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/131/)
          HADOOP-7786. svn merge -c 1196129 from trunk

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196136
          Files :

          • /hadoop/common/branches/branch-0.23
          • /hadoop/common/branches/branch-0.23/hadoop-common-project
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/cluster_setup.xml
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsConfig.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellReturnCode.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/.gitignore
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/streaming
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/FileBench.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/TestSequenceFileMergeProgress.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/security/authorize/TestServiceLevelAuthorization.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/test/MapredTestDriver.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #131 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/131/ ) HADOOP-7786 . svn merge -c 1196129 from trunk eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196136 Files : /hadoop/common/branches/branch-0.23 /hadoop/common/branches/branch-0.23/hadoop-common-project /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/cluster_setup.xml /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsConfig.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellReturnCode.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/.gitignore /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++ /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/streaming /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/FileBench.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/TestSequenceFileMergeProgress.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/security/authorize/TestServiceLevelAuthorization.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/test/MapredTestDriver.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1301 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1301/)
          HADOOP-7786. Remove HDFS-specific config keys defined in FsConfig. Contributed by Eli Collins

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196129
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/cluster_setup.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellReturnCode.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1301 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1301/ ) HADOOP-7786 . Remove HDFS-specific config keys defined in FsConfig. Contributed by Eli Collins eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196129 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/cluster_setup.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellReturnCode.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1225 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1225/)
          HADOOP-7786. Remove HDFS-specific config keys defined in FsConfig. Contributed by Eli Collins

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196129
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/cluster_setup.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellReturnCode.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1225 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1225/ ) HADOOP-7786 . Remove HDFS-specific config keys defined in FsConfig. Contributed by Eli Collins eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196129 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/cluster_setup.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellReturnCode.java
          Hide
          Eli Collins added a comment -

          Thanks Konst. Fixed this and committed to trunk, 22 and 23.

          Show
          Eli Collins added a comment - Thanks Konst. Fixed this and committed to trunk, 22 and 23.
          Hide
          Konstantin Shvachko added a comment -

          Eli, the patch looks great.
          One thing:
          Instead of aConf.get(FS_DEFAULT_NAME_KEY)
          It should be aConf.get(FS_DEFAULT_NAME_KEY, FS_DEFAULT_NAME_DEFAULT)

          +1 other than that.

          Findbugs come from protobuf packages untouched here. Don't understand why jenkins reported them as new.

          Show
          Konstantin Shvachko added a comment - Eli, the patch looks great. One thing: Instead of aConf.get(FS_DEFAULT_NAME_KEY) It should be aConf.get(FS_DEFAULT_NAME_KEY, FS_DEFAULT_NAME_DEFAULT) +1 other than that. Findbugs come from protobuf packages untouched here. Don't understand why jenkins reported them as new.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12501710/hadoop-7786-1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/347//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/347//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/347//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12501710/hadoop-7786-1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/347//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/347//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/347//console This message is automatically generated.
          Hide
          Eli Collins added a comment -

          Patch attached.

          Show
          Eli Collins added a comment - Patch attached.
          Hide
          Eli Collins added a comment -

          I agree with Konst, we should remove the overlap between FsConfig and DFSCOnfig.

          Show
          Eli Collins added a comment - I agree with Konst, we should remove the overlap between FsConfig and DFSCOnfig.
          Hide
          Konstantin Shvachko added a comment -

          I think "dfs.block.size" introduced in HADOOP-4952 was just a mistake. I think the intention was to have it "dfs.blocksize", same as in HDFS. I see a bunch of other file system keys in FsConfig, that duplicate their HDFS counterparts, but the naming is consistent across them. So I assume that extra dot between block and size was a typo.
          Having said that I think it is not a good idea to duplicate key definitions. The reason is exactly the typos or inconsistent renaming of those properties or the default values. E.g. in common
          FsConfig.FS_DEFAULT_BLOCK_SIZE = 32 MB
          while in HDFS
          DFSConfigKeys.DFS_BLOCK_SIZE_DEFAULT = 64 MB
          This is really messy.

          The only method from FsConfig that is used in the code is getDefaultFsURI(). I propose to remove everything else from FsConfig in order to avoid confusion.
          The rational behind this is that FsConfig should only contain keys that are specified in core-site.xml. The keys that belolng to hdf-site.xml shoud be described in DFSConfigKeys.
          It also looks that Tom's documentation change HDFS-671 describes keys consistently with this assumption.

          Show
          Konstantin Shvachko added a comment - I think "dfs.block.size" introduced in HADOOP-4952 was just a mistake. I think the intention was to have it "dfs.blocksize", same as in HDFS. I see a bunch of other file system keys in FsConfig, that duplicate their HDFS counterparts, but the naming is consistent across them. So I assume that extra dot between block and size was a typo. Having said that I think it is not a good idea to duplicate key definitions. The reason is exactly the typos or inconsistent renaming of those properties or the default values. E.g. in common FsConfig.FS_DEFAULT_BLOCK_SIZE = 32 MB while in HDFS DFSConfigKeys.DFS_BLOCK_SIZE_DEFAULT = 64 MB This is really messy. The only method from FsConfig that is used in the code is getDefaultFsURI() . I propose to remove everything else from FsConfig in order to avoid confusion. The rational behind this is that FsConfig should only contain keys that are specified in core-site.xml. The keys that belolng to hdf-site.xml shoud be described in DFSConfigKeys . It also looks that Tom's documentation change HDFS-671 describes keys consistently with this assumption.
          Hide
          Abel Perez added a comment -

          Hey Guys, your absolutely right, I was using forest 0.9. I ran the test-patch with forest 0.8 and that seemed to resolved the issue. However looks like I'm getting the same error as the QA Bot:

          [exec] Looks like this is a cross-subproject patch. Not supported!
          [exec] PATCH APPLICATION FAILED

          Any idea how to get around this?

          Show
          Abel Perez added a comment - Hey Guys, your absolutely right, I was using forest 0.9. I ran the test-patch with forest 0.8 and that seemed to resolved the issue. However looks like I'm getting the same error as the QA Bot: [exec] Looks like this is a cross-subproject patch. Not supported! [exec] PATCH APPLICATION FAILED Any idea how to get around this?
          Hide
          Aaron T. Myers added a comment -

          That's definitely Forrest 0.9. See: HADOOP-7394

          Show
          Aaron T. Myers added a comment - That's definitely Forrest 0.9. See: HADOOP-7394
          Hide
          Todd Lipcon added a comment -

          Are you using forrest 0.8 or 0.9? I think I've seen this problem using forrest 0.9 which is fairly new and apparently has some kind of problem with our build environment.

          Show
          Todd Lipcon added a comment - Are you using forrest 0.8 or 0.9? I think I've seen this problem using forrest 0.9 which is fairly new and apparently has some kind of problem with our build environment.
          Hide
          Abel Perez added a comment -

          Hey Eli, thanks for the function. Not sure if my environment is properly setup, I tried running test-patch and got the following error:

          [exec] Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/fop/messaging/MessageHandler
          [exec] at org.apache.cocoon.serialization.FOPSerializer.configure(FOPSerializer.java:122)
          [exec] at org.apache.avalon.framework.container.ContainerUtil.configure(ContainerUtil.java:201)
          [exec] at org.apache.avalon.excalibur.component.DefaultComponentFactory.newInstance(DefaultComponentFactory.java:289)
          [exec] at org.apache.avalon.excalibur.pool.InstrumentedResourceLimitingPool.newPoolable(InstrumentedResourceLimitingPool.java:655)
          [exec] at org.apache.avalon.excalibur.pool.InstrumentedResourceLimitingPool.get(InstrumentedResourceLimitingPool.java:371)
          [exec] at org.apache.avalon.excalibur.component.PoolableComponentHandler.doGet(PoolableComponentHandler.java:198)
          [exec] at org.apache.avalon.excalibur.component.ComponentHandler.get(ComponentHandler.java:381)
          [exec] at org.apache.avalon.excalibur.component.ExcaliburComponentSelector.select(ExcaliburComponentSelector.java:215)
          [exec] at org.apache.cocoon.components.ExtendedComponentSelector.select(ExtendedComponentSelector.java:268)
          [exec] at org.apache.cocoon.components.pipeline.AbstractProcessingPipeline.setSerializer(AbstractProcessingPipeline.java:311)
          [exec] at org.apache.cocoon.components.pipeline.impl.AbstractCachingProcessingPipeline.setSerializer(AbstractCachingProcessingPipeline.java:171)
          [exec] at org.apache.cocoon.components.treeprocessor.sitemap.SerializeNode.invoke(SerializeNode.java:120)
          [exec] at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:69)
          [exec] at org.apache.cocoon.components.treeprocessor.sitemap.SelectNode.invoke(SelectNode.java:103)
          [exec] at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:47)
          [exec] at org.apache.cocoon.components.treeprocessor.sitemap.PreparableMatchNode.invoke(PreparableMatchNode.java:131)
          [exec] at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:69)
          [exec] at org.apache.cocoon.components.treeprocessor.sitemap.PipelineNode.invoke(PipelineNode.java:143)
          [exec] at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:69)
          [exec] at org.apache.cocoon.components.treeprocessor.sitemap.PipelinesNode.invoke(PipelinesNode.java:93)
          [exec] at org.apache.cocoon.components.treeprocessor.ConcreteTreeProcessor.process(ConcreteTreeProcessor.java:235)
          [exec] at org.apache.cocoon.components.treeprocessor.ConcreteTreeProcessor.process(ConcreteTreeProcessor.java:177)
          [exec] at org.apache.cocoon.components.treeprocessor.TreeProcessor.process(TreeProcessor.java:254)
          [exec] at org.apache.cocoon.components.treeprocessor.sitemap.MountNode.invoke(MountNode.java:118)
          [exec] at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:69)
          [exec] at org.apache.cocoon.components.treeprocessor.sitemap.SelectNode.invoke(SelectNode.java:98)
          [exec] at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:69)
          [exec] at org.apache.cocoon.components.treeprocessor.sitemap.PipelineNode.invoke(PipelineNode.java:143)
          [exec] at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:69)
          [exec] at org.apache.cocoon.components.treeprocessor.sitemap.PipelinesNode.invoke(PipelinesNode.java:93)
          [exec] at org.apache.cocoon.components.treeprocessor.ConcreteTreeProcessor.process(ConcreteTreeProcessor.java:235)
          [exec] at org.apache.cocoon.components.treeprocessor.ConcreteTreeProcessor.process(ConcreteTreeProcessor.java:177)
          [exec] at org.apache.cocoon.components.treeprocessor.TreeProcessor.process(TreeProcessor.java:254)
          [exec] at org.apache.cocoon.Cocoon.process(Cocoon.java:699)
          [exec] at org.apache.cocoon.bean.CocoonWrapper.getPage(CocoonWrapper.java:514)
          [exec] at org.apache.cocoon.bean.CocoonBean.processTarget(CocoonBean.java:499)
          [exec] at org.apache.cocoon.bean.CocoonBean.process(CocoonBean.java:356)
          [exec] at org.apache.cocoon.Main.main(Main.java:321)
          [exec] Caused by: java.lang.ClassNotFoundException: org.apache.fop.messaging.MessageHandler
          [exec] at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
          [exec] at java.security.AccessController.doPrivileged(Native Method)
          [exec] at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
          [exec] at java.lang.ClassLoader.loadClass(ClassLoader.java:307)
          [exec] at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
          [exec] at java.lang.ClassLoader.loadClass(ClassLoader.java:248)
          [exec] ... 38 more
          [exec] * [8/24] [0/0] 0.838s 0b linkmap.pdf

          Show
          Abel Perez added a comment - Hey Eli, thanks for the function. Not sure if my environment is properly setup, I tried running test-patch and got the following error: [exec] Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/fop/messaging/MessageHandler [exec] at org.apache.cocoon.serialization.FOPSerializer.configure(FOPSerializer.java:122) [exec] at org.apache.avalon.framework.container.ContainerUtil.configure(ContainerUtil.java:201) [exec] at org.apache.avalon.excalibur.component.DefaultComponentFactory.newInstance(DefaultComponentFactory.java:289) [exec] at org.apache.avalon.excalibur.pool.InstrumentedResourceLimitingPool.newPoolable(InstrumentedResourceLimitingPool.java:655) [exec] at org.apache.avalon.excalibur.pool.InstrumentedResourceLimitingPool.get(InstrumentedResourceLimitingPool.java:371) [exec] at org.apache.avalon.excalibur.component.PoolableComponentHandler.doGet(PoolableComponentHandler.java:198) [exec] at org.apache.avalon.excalibur.component.ComponentHandler.get(ComponentHandler.java:381) [exec] at org.apache.avalon.excalibur.component.ExcaliburComponentSelector.select(ExcaliburComponentSelector.java:215) [exec] at org.apache.cocoon.components.ExtendedComponentSelector.select(ExtendedComponentSelector.java:268) [exec] at org.apache.cocoon.components.pipeline.AbstractProcessingPipeline.setSerializer(AbstractProcessingPipeline.java:311) [exec] at org.apache.cocoon.components.pipeline.impl.AbstractCachingProcessingPipeline.setSerializer(AbstractCachingProcessingPipeline.java:171) [exec] at org.apache.cocoon.components.treeprocessor.sitemap.SerializeNode.invoke(SerializeNode.java:120) [exec] at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:69) [exec] at org.apache.cocoon.components.treeprocessor.sitemap.SelectNode.invoke(SelectNode.java:103) [exec] at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:47) [exec] at org.apache.cocoon.components.treeprocessor.sitemap.PreparableMatchNode.invoke(PreparableMatchNode.java:131) [exec] at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:69) [exec] at org.apache.cocoon.components.treeprocessor.sitemap.PipelineNode.invoke(PipelineNode.java:143) [exec] at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:69) [exec] at org.apache.cocoon.components.treeprocessor.sitemap.PipelinesNode.invoke(PipelinesNode.java:93) [exec] at org.apache.cocoon.components.treeprocessor.ConcreteTreeProcessor.process(ConcreteTreeProcessor.java:235) [exec] at org.apache.cocoon.components.treeprocessor.ConcreteTreeProcessor.process(ConcreteTreeProcessor.java:177) [exec] at org.apache.cocoon.components.treeprocessor.TreeProcessor.process(TreeProcessor.java:254) [exec] at org.apache.cocoon.components.treeprocessor.sitemap.MountNode.invoke(MountNode.java:118) [exec] at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:69) [exec] at org.apache.cocoon.components.treeprocessor.sitemap.SelectNode.invoke(SelectNode.java:98) [exec] at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:69) [exec] at org.apache.cocoon.components.treeprocessor.sitemap.PipelineNode.invoke(PipelineNode.java:143) [exec] at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:69) [exec] at org.apache.cocoon.components.treeprocessor.sitemap.PipelinesNode.invoke(PipelinesNode.java:93) [exec] at org.apache.cocoon.components.treeprocessor.ConcreteTreeProcessor.process(ConcreteTreeProcessor.java:235) [exec] at org.apache.cocoon.components.treeprocessor.ConcreteTreeProcessor.process(ConcreteTreeProcessor.java:177) [exec] at org.apache.cocoon.components.treeprocessor.TreeProcessor.process(TreeProcessor.java:254) [exec] at org.apache.cocoon.Cocoon.process(Cocoon.java:699) [exec] at org.apache.cocoon.bean.CocoonWrapper.getPage(CocoonWrapper.java:514) [exec] at org.apache.cocoon.bean.CocoonBean.processTarget(CocoonBean.java:499) [exec] at org.apache.cocoon.bean.CocoonBean.process(CocoonBean.java:356) [exec] at org.apache.cocoon.Main.main(Main.java:321) [exec] Caused by: java.lang.ClassNotFoundException: org.apache.fop.messaging.MessageHandler [exec] at java.net.URLClassLoader$1.run(URLClassLoader.java:202) [exec] at java.security.AccessController.doPrivileged(Native Method) [exec] at java.net.URLClassLoader.findClass(URLClassLoader.java:190) [exec] at java.lang.ClassLoader.loadClass(ClassLoader.java:307) [exec] at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301) [exec] at java.lang.ClassLoader.loadClass(ClassLoader.java:248) [exec] ... 38 more [exec] * [8/24] [0/0] 0.838s 0b linkmap.pdf
          Hide
          Eli Collins added a comment - - edited

          Hey Abel, I use the following bash function:

          function ant-test-patch() {
           ant -Dpatch.file=$1 \
             -Dforrest.home=$FORREST_HOME \
             -Dfindbugs.home=$FINDBUGS_HOME \
             -Djava5.home=$JAVA5_HOME \
             test-patch
          }
          

          and apache-forrest-0.8 and findbugs-1.3.9. More at https://github.com/elicollins/hadoop-dev/blob/master/bin/hadoop-alias.sh

          Show
          Eli Collins added a comment - - edited Hey Abel, I use the following bash function: function ant-test-patch() { ant -Dpatch.file=$1 \ -Dforrest.home=$FORREST_HOME \ -Dfindbugs.home=$FINDBUGS_HOME \ -Djava5.home=$JAVA5_HOME \ test-patch } and apache-forrest-0.8 and findbugs-1.3.9. More at https://github.com/elicollins/hadoop-dev/blob/master/bin/hadoop-alias.sh
          Hide
          Abel Perez added a comment -

          Hey Aaron,

          I'm trying to run the Ant test-patch task but I'm not sure what args I should be passing the task. Can you provide me with a sample command for the sh script or Ant task?

          thanks,

          • Abel
          Show
          Abel Perez added a comment - Hey Aaron, I'm trying to run the Ant test-patch task but I'm not sure what args I should be passing the task. Can you provide me with a sample command for the sh script or Ant task? thanks, Abel
          Hide
          Aaron T. Myers added a comment -

          I've filed HADOOP-7416 to address this limitation of test-patch.

          Show
          Aaron T. Myers added a comment - I've filed HADOOP-7416 to address this limitation of test-patch.
          Hide
          Aaron T. Myers added a comment -

          Thanks a lot for checking on that, Abel. That seems fine to change.

          The patch application failed with the following error "Looks like this is a cross-subproject patch. Not supported!"

          This happened because this change affects both the Common and HDFS subprojects. Unfortunately, the QA bot can't presently handle this, so you'll need to run test-patch yourself and paste the output here as a comment.

          Sorry about that. :/

          Show
          Aaron T. Myers added a comment - Thanks a lot for checking on that, Abel. That seems fine to change. The patch application failed with the following error "Looks like this is a cross-subproject patch. Not supported!" This happened because this change affects both the Common and HDFS subprojects. Unfortunately, the QA bot can't presently handle this, so you'll need to run test-patch yourself and paste the output here as a comment. Sorry about that. :/
          Hide
          Abel Perez added a comment -

          Note: FsConfig.FS_BLOCK_SIZE_KEY is only being used in the Test TestBlockPlacementPolicyRaid in the Mapreduce project. I ran that test all is good

          Show
          Abel Perez added a comment - Note: FsConfig.FS_BLOCK_SIZE_KEY is only being used in the Test TestBlockPlacementPolicyRaid in the Mapreduce project. I ran that test all is good
          Hide
          Abel Perez added a comment -

          Hey Aaron, FsConfig.FS_BLOCK_SIZE_KEY is not being used in the Common project.

          Show
          Abel Perez added a comment - Hey Aaron, FsConfig.FS_BLOCK_SIZE_KEY is not being used in the Common project.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12483516/HDFS-1900.txt
          against trunk revision 1138645.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 120 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/821//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12483516/HDFS-1900.txt against trunk revision 1138645. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 120 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/821//console This message is automatically generated.
          Hide
          Aaron T. Myers added a comment -

          Hey Abel, thanks a lot for the patch. It looks pretty good to me, but lets see what the QA bot has to say.

          One question - since, this patch changes the value of FsConfig.FS_BLOCK_SIZE_KEY, did you check if that is referenced anywhere in the Common project? If so, where? And did you try running the common unit tests with this patch as well? Since this is an HDFS JIRA, the QA bot will only run the HDFS tests, not the common ones.

          Show
          Aaron T. Myers added a comment - Hey Abel, thanks a lot for the patch. It looks pretty good to me, but lets see what the QA bot has to say. One question - since, this patch changes the value of FsConfig.FS_BLOCK_SIZE_KEY , did you check if that is referenced anywhere in the Common project? If so, where? And did you try running the common unit tests with this patch as well? Since this is an HDFS JIRA, the QA bot will only run the HDFS tests, not the common ones.
          Hide
          Abel Perez added a comment -

          No test included because this is basically a config key value change.

          Show
          Abel Perez added a comment - No test included because this is basically a config key value change.

            People

            • Assignee:
              Eli Collins
              Reporter:
              Eli Collins
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development