-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12500945/hdfs-2487.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed the unit tests build
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/323//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/323//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/323//console
This message is automatically generated.
dfsadmin command be added to change NN HA states based on adding a client that communicates using HAServiceProtocol. Any other things you are planning to do as a part of this jira?