Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • HA Branch (HDFS-1623)
    • HA Branch (HDFS-1623)
    • ha, util
    • None

    Description

      We'll need to have some way of controlling the HA nodes while they're live, probably by adding some more commands to dfsadmin.

      Attachments

        1. hadoop-7774.txt
          11 kB
          Todd Lipcon
        2. hdfs-2487.txt
          11 kB
          Todd Lipcon

        Activity

          dfsadmin command be added to change NN HA states based on adding a client that communicates using HAServiceProtocol. Any other things you are planning to do as a part of this jira?

          sureshms Suresh Srinivas added a comment - dfsadmin command be added to change NN HA states based on adding a client that communicates using HAServiceProtocol. Any other things you are planning to do as a part of this jira?
          tlipcon Todd Lipcon added a comment -

          Here's a patch which adds an HAAdmin command line tool.

          Its usage output:

          Usage: java HAAdmin
              [-transitionToActive <host:port>]
              [-transitionToStandby <host:port>]
              [-checkHealth <host:port>]
              [-help <command>]
          

          Notes:

          • I didn't add it to the bin/hadoop wrapper script since this is mostly going to be used as a testing tool for now. Actual failovers will be done through the failover controller.
          • Similarly, I didn't try to integrate this with configuration for NN addresses or anything - this is a patch for common rather than HDFS. I'll move the JIRA to common.
          tlipcon Todd Lipcon added a comment - Here's a patch which adds an HAAdmin command line tool. Its usage output: Usage: java HAAdmin [-transitionToActive <host:port>] [-transitionToStandby <host:port>] [-checkHealth <host:port>] [-help <command>] Notes: I didn't add it to the bin/hadoop wrapper script since this is mostly going to be used as a testing tool for now. Actual failovers will be done through the failover controller. Similarly, I didn't try to integrate this with configuration for NN addresses or anything - this is a patch for common rather than HDFS. I'll move the JIRA to common.
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12500945/hdfs-2487.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed the unit tests build

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/323//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/323//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/323//console

          This message is automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12500945/hdfs-2487.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed the unit tests build +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/323//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/323//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/323//console This message is automatically generated.
          tlipcon Todd Lipcon added a comment -

          The test-patch results are bogus. But this just adds new code, and I ran the new unit test, verified it passes. Thanks for finding the right parent issue for this, ATM.

          tlipcon Todd Lipcon added a comment - The test-patch results are bogus. But this just adds new code, and I ran the new unit test, verified it passes. Thanks for finding the right parent issue for this, ATM.
          eli Eli Collins added a comment -

          +1 lgtm

          Nit: the param/throws javadoc for main shouldn't have periods

          eli Eli Collins added a comment - +1 lgtm Nit: the param/throws javadoc for main shouldn't have periods
          tlipcon Todd Lipcon added a comment -

          Updated javadoc - actually the javadoc you pointed out was holdover from DFSAdmin where I'd copied some of this code from. So I updated the javadoc both for the class and for this method to be correct. I'll commit this since it's just doc changes since the previous rev.

          tlipcon Todd Lipcon added a comment - Updated javadoc - actually the javadoc you pointed out was holdover from DFSAdmin where I'd copied some of this code from. So I updated the javadoc both for the class and for this method to be correct. I'll commit this since it's just doc changes since the previous rev.

          People

            tlipcon Todd Lipcon
            atm Aaron Myers
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: