Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-7757

Test file reference count is at least 3x actual value

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0, 0.24.0
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: build
    • Labels:
      None

      Description

      patch file format example

      diff --git hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/test/MapredTestDriver.java hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/test/MapredTestDriver.java
      index 26747cd..4ab14ad 100644
      — hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/test/MapredTestDriver.java
      +++ hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/test/MapredTestDriver.java

      method to count test file references will count 3 test files referenced instead of the more accurate 1 test file referenced

      grep -c -i '/test'

      1. HADOOP-7757.patch
        0.6 kB
        Jonathan Eagles
      2. HADOOP-7757.patch
        0.8 kB
        Jonathan Eagles

        Activity

        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1041 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1041/)
        HADOOP-7757. Test file reference count is at least 3x actual value (Jon Eagles via bobby) (Revision 1309864)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309864
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1041 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1041/ ) HADOOP-7757 . Test file reference count is at least 3x actual value (Jon Eagles via bobby) (Revision 1309864) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309864 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1006 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1006/)
        HADOOP-7757. Test file reference count is at least 3x actual value (Jon Eagles via bobby) (Revision 1309864)

        Result = FAILURE
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309864
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1006 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1006/ ) HADOOP-7757 . Test file reference count is at least 3x actual value (Jon Eagles via bobby) (Revision 1309864) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309864 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2014 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2014/)
        HADOOP-7757. Test file reference count is at least 3x actual value (Jon Eagles via bobby) (Revision 1309864)

        Result = ABORTED
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309864
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2014 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2014/ ) HADOOP-7757 . Test file reference count is at least 3x actual value (Jon Eagles via bobby) (Revision 1309864) Result = ABORTED bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309864 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2077 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2077/)
        HADOOP-7757. Test file reference count is at least 3x actual value (Jon Eagles via bobby) (Revision 1309864)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309864
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2077 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2077/ ) HADOOP-7757 . Test file reference count is at least 3x actual value (Jon Eagles via bobby) (Revision 1309864) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309864 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2002 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2002/)
        HADOOP-7757. Test file reference count is at least 3x actual value (Jon Eagles via bobby) (Revision 1309864)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309864
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2002 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2002/ ) HADOOP-7757 . Test file reference count is at least 3x actual value (Jon Eagles via bobby) (Revision 1309864) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309864 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        revans2 Robert Joseph Evans added a comment -

        I checked this into trunk.

        Show
        revans2 Robert Joseph Evans added a comment - I checked this into trunk.
        Hide
        revans2 Robert Joseph Evans added a comment -

        The patch looks good +1.

        Show
        revans2 Robert Joseph Evans added a comment - The patch looks good +1.
        Hide
        jeagles Jonathan Eagles added a comment -

        Manual tests performed.

        new grep commands works on both linux and mac with both patches generated from git and subversion.

        With the new test-patch ran local test-patch.sh on both patch with and without tests to verify +1 and -1 messages.

        Show
        jeagles Jonathan Eagles added a comment - Manual tests performed. new grep commands works on both linux and mac with both patches generated from git and subversion. With the new test-patch ran local test-patch.sh on both patch with and without tests to verify +1 and -1 messages.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12499774/HADOOP-7757.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 5 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/306//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12499774/HADOOP-7757.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/306//console This message is automatically generated.
        Hide
        jeagles Jonathan Eagles added a comment -

        Updated the +1 message to better reflect what is actually being measured.

        Show
        jeagles Jonathan Eagles added a comment - Updated the +1 message to better reflect what is actually being measured.
        Hide
        jeagles Jonathan Eagles added a comment -

        +1 tests included. The patch appears to include 5 new or modified tests.

        A testament to why this patch is needed.

        Show
        jeagles Jonathan Eagles added a comment - +1 tests included. The patch appears to include 5 new or modified tests. A testament to why this patch is needed.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12499772/HADOOP-7757.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 5 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/305//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12499772/HADOOP-7757.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/305//console This message is automatically generated.

          People

          • Assignee:
            jeagles Jonathan Eagles
            Reporter:
            jeagles Jonathan Eagles
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development