Hadoop Common
  1. Hadoop Common
  2. HADOOP-7716

RPC protocol registration on SS does not log the protocol name (only the class which may be different)

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-alpha
    • Component/s: None
    • Labels:
      None
    1. rcpFixLog.patch
      1 kB
      Sanjay Radia

      Issue Links

        Activity

        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Arun C Murthy made changes -
        Fix Version/s 2.0.0 [ 12320352 ]
        Fix Version/s 0.24.0 [ 12317652 ]
        Fix Version/s 0.23.3 [ 12320059 ]
        Tsz Wo Nicholas Sze made changes -
        Fix Version/s 0.24.0 [ 12317652 ]
        Fix Version/s 0.23.3 [ 12320059 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have merged this to 0.23.

        Show
        Tsz Wo Nicholas Sze added a comment - I have merged this to 0.23.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #850 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/850/)
        HADOOP-7716 RPC protocol registration on SS does not log the protocol name

        sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1178639
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #850 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/850/ ) HADOOP-7716 RPC protocol registration on SS does not log the protocol name sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1178639 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #820 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/820/)
        HADOOP-7716 RPC protocol registration on SS does not log the protocol name

        sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1178639
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #820 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/820/ ) HADOOP-7716 RPC protocol registration on SS does not log the protocol name sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1178639 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1023 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1023/)
        HADOOP-7716 RPC protocol registration on SS does not log the protocol name

        sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1178639
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1023 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1023/ ) HADOOP-7716 RPC protocol registration on SS does not log the protocol name sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1178639 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1081 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1081/)
        HADOOP-7716 RPC protocol registration on SS does not log the protocol name

        sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1178639
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1081 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1081/ ) HADOOP-7716 RPC protocol registration on SS does not log the protocol name sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1178639 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1003 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1003/)
        HADOOP-7716 RPC protocol registration on SS does not log the protocol name

        sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1178639
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1003 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1003/ ) HADOOP-7716 RPC protocol registration on SS does not log the protocol name sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1178639 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
        Sanjay Radia made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Sanjay Radia made changes -
        Summary Multiple protocol does not log the protocol name only the class which may not be the same RPC protocol registration on SS does not log the protocol name (only the class which may be different)
        Sanjay Radia made changes -
        Link This issue is related to HADOOP-7524 [ HADOOP-7524 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12497542/rcpFixLog.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/256//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/256//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12497542/rcpFixLog.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/256//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/256//console This message is automatically generated.
        Hide
        Suresh Srinivas added a comment -

        +1 for the patch.

        Show
        Suresh Srinivas added a comment - +1 for the patch.
        Sanjay Radia made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Sanjay Radia made changes -
        Field Original Value New Value
        Attachment rcpFixLog.patch [ 12497542 ]
        Hide
        Sanjay Radia added a comment -

        Log msg printed protocol class but not name which may not be the same- made mismatch debugging harder.

        Show
        Sanjay Radia added a comment - Log msg printed protocol class but not name which may not be the same- made mismatch debugging harder.
        Sanjay Radia created issue -

          People

          • Assignee:
            Sanjay Radia
            Reporter:
            Sanjay Radia
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development