Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
    • Release Note:
      Added -v option to fs -count command to display a header record in the report.

      Description

      These commands should label the output columns:

      hadoop dfs -count <dir>...<dir>
      hadoop dfs -count -q <dir>...<dir>
      

      Current output of the 2nd command above:

      % hadoop dfs -count -q /user/foo /tmp
              none             inf         9569         9493         6372553322 hdfs://nn1.bar.com/user/foo
              none             inf          101         2689       209349812906 hdfs://nn1.bar.com/tmp
      

      It is not obvious what these columns mean.

      1. HADOOP-7713-11.patch
        20 kB
        Allen Wittenauer
      2. HADOOP-7713.patch
        20 kB
        Jonathan Allen
      3. HADOOP-7713.patch
        19 kB
        Jonathan Allen
      4. HADOOP-7713.patch
        13 kB
        Jonathan Allen
      5. HADOOP-7713.patch
        18 kB
        Jonathan Allen
      6. HADOOP-7713.patch
        15 kB
        Jonathan Allen
      7. HADOOP-7713.patch
        14 kB
        Jonathan Allen
      8. HADOOP-7713.patch
        5 kB
        Jonathan Allen
      9. HADOOP-7713.patch
        13 kB
        Jonathan Allen
      10. HADOOP-7713.patch
        12 kB
        Jonathan Allen
      11. HADOOP-7713.patch
        11 kB
        Jonathan Allen

        Issue Links

          Activity

          Hide
          jonallen Jonathan Allen added a comment -

          Updated hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Count.java to optionally display header record.
          Added JUnit test class - hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestCount.java

          Show
          jonallen Jonathan Allen added a comment - Updated hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Count.java to optionally display header record. Added JUnit test class - hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestCount.java
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12497180/HDFS-364.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1322//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12497180/HDFS-364.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1322//console This message is automatically generated.
          Hide
          jonallen Jonathan Allen added a comment -

          Attempt with patch generated from SVN rather than GIT.

          Show
          jonallen Jonathan Allen added a comment - Attempt with patch generated from SVN rather than GIT.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12497276/HDFS-364.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1327//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12497276/HDFS-364.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1327//console This message is automatically generated.
          Hide
          mattf Matt Foley added a comment -

          Jon's proposed patch shows that the fix is best done in the FS-independent common code. So moving this former HDFS-364 bug to HADOOP-7713.

          Show
          mattf Matt Foley added a comment - Jon's proposed patch shows that the fix is best done in the FS-independent common code. So moving this former HDFS-364 bug to HADOOP-7713 .
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12497276/HDFS-364.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/254//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/254//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12497276/HDFS-364.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/254//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/254//console This message is automatically generated.
          Hide
          qwertymaniac Harsh J added a comment -

          +1 for the change. Would you mind updating docs for this as well?

          Show
          qwertymaniac Harsh J added a comment - +1 for the change. Would you mind updating docs for this as well?
          Hide
          jonallen Jonathan Allen added a comment -

          New patch includes documentation updates and changes required to work with updated PathData class.

          Show
          jonallen Jonathan Allen added a comment - New patch includes documentation updates and changes required to work with updated PathData class.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12510648/HADOOP-7713.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated 7 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.cli.TestCLI

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/510//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/510//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12510648/HADOOP-7713.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 7 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.cli.TestCLI +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/510//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/510//console This message is automatically generated.
          Hide
          jonallen Jonathan Allen added a comment -

          hadoop-common/src/test/resources/testConf.xml updated to reference new help message for fs -count and javadoc warning fixed

          Show
          jonallen Jonathan Allen added a comment - hadoop-common/src/test/resources/testConf.xml updated to reference new help message for fs -count and javadoc warning fixed
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12510765/HADOOP-7713.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated 7 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/512//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/512//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12510765/HADOOP-7713.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 7 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/512//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/512//console This message is automatically generated.
          Hide
          jonallen Jonathan Allen added a comment -

          updated patch contents

          Show
          jonallen Jonathan Allen added a comment - updated patch contents
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12549065/HADOOP-7713.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1626//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1626//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12549065/HADOOP-7713.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1626//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1626//console This message is automatically generated.
          Hide
          jonallen Jonathan Allen added a comment -

          Could somebody please code review this patch.

          Show
          jonallen Jonathan Allen added a comment - Could somebody please code review this patch.
          Hide
          aw Allen Wittenauer added a comment -

          I'd rather save -h for human readable for whenever someone commits code that changes numbers from 3298534883328 to 3TB. Perhaps this should be changed to -header instead?

          Show
          aw Allen Wittenauer added a comment - I'd rather save -h for human readable for whenever someone commits code that changes numbers from 3298534883328 to 3TB. Perhaps this should be changed to -header instead?
          Hide
          jonallen Jonathan Allen added a comment -

          Patch updated in line with review comment

          Show
          jonallen Jonathan Allen added a comment - Patch updated in line with review comment
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12549381/HADOOP-7713.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1636//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1636//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12549381/HADOOP-7713.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1636//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1636//console This message is automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          looks good, though this patch is the time to fix the typo in REMAINING_QUATA

          Show
          stevel@apache.org Steve Loughran added a comment - looks good, though this patch is the time to fix the typo in REMAINING_QUATA
          Hide
          jonallen Jonathan Allen added a comment -

          Corrected QUATA and reinstated unit tests that had been lost in the previous patch file.

          Show
          jonallen Jonathan Allen added a comment - Corrected QUATA and reinstated unit tests that had been lost in the previous patch file.
          Hide
          jonallen Jonathan Allen added a comment -

          Patch ready for review

          Show
          jonallen Jonathan Allen added a comment - Patch ready for review
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12549984/HADOOP-7713.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1650//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1650//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12549984/HADOOP-7713.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1650//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1650//console This message is automatically generated.
          Hide
          jonallen Jonathan Allen added a comment -

          I've just noticed the getHeader method in the ContentSummary class so I'll update the patch to use that rather than redefining the header fields in ...fs.shell.Count

          Show
          jonallen Jonathan Allen added a comment - I've just noticed the getHeader method in the ContentSummary class so I'll update the patch to use that rather than redefining the header fields in ...fs.shell.Count
          Hide
          jonallen Jonathan Allen added a comment -

          updated patch using ContentSummary.getHeader method

          Show
          jonallen Jonathan Allen added a comment - updated patch using ContentSummary.getHeader method
          Hide
          jonallen Jonathan Allen added a comment -

          Patch ready for code review

          Show
          jonallen Jonathan Allen added a comment - Patch ready for code review
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12550042/HADOOP-7713.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1653//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1653//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12550042/HADOOP-7713.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1653//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1653//console This message is automatically generated.
          Hide
          jonallen Jonathan Allen added a comment -

          Patch updated in line with some comments on a similar jira.

          Show
          jonallen Jonathan Allen added a comment - Patch updated in line with some comments on a similar jira.
          Hide
          jonallen Jonathan Allen added a comment -

          Could somebody please do a code review.

          Show
          jonallen Jonathan Allen added a comment - Could somebody please do a code review.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12554752/HADOOP-7713.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1809//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1809//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12554752/HADOOP-7713.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1809//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1809//console This message is automatically generated.
          Hide
          jonallen Jonathan Allen added a comment -

          Unfortunately this patch clashes with HADOOP-8944, if one of them can be committed then I can tweak the other and resubmit.

          Show
          jonallen Jonathan Allen added a comment - Unfortunately this patch clashes with HADOOP-8944 , if one of them can be committed then I can tweak the other and resubmit.
          Hide
          aw Allen Wittenauer added a comment -

          I think from a useability perspective, this issue falls into the same sort of category as the fsck dot code: the headers should default to on with an option to turn them off. Yes, I realize this makes it an incompatible change which would only make it eligible for trunk.

          Anyone have any other opinions?

          Show
          aw Allen Wittenauer added a comment - I think from a useability perspective, this issue falls into the same sort of category as the fsck dot code: the headers should default to on with an option to turn them off. Yes, I realize this makes it an incompatible change which would only make it eligible for trunk. Anyone have any other opinions?
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12554752/HADOOP-7713.patch
          against trunk revision .

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4464//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12554752/HADOOP-7713.patch against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4464//console This message is automatically generated.
          Hide
          daryn Daryn Sharp added a comment -

          Like the other count jira, this would be great to have in 2.x. I know we have various SE and customer monitoring scripts that depend on this command, so I'd rather not have the headers by default so we don't have to hunt down everyone using the command.

          I think the header field names in count's former help message are probably a better choice than the new ones in this patch. I don't mind the upper/lower case so much as fields that contain spaces. I often like to write utilities that split a header and use them as map keys. Spaces in the header fields thwarts that.

          I'd suggest using a single letter for the header option (maybe v(erbose)) to be inline with the other commands. Otherwise it will thwart the "one of these days" feature of allowing option bundling. Multi-char options are better implemented as "--opt".

          Show
          daryn Daryn Sharp added a comment - Like the other count jira, this would be great to have in 2.x. I know we have various SE and customer monitoring scripts that depend on this command, so I'd rather not have the headers by default so we don't have to hunt down everyone using the command. I think the header field names in count's former help message are probably a better choice than the new ones in this patch. I don't mind the upper/lower case so much as fields that contain spaces. I often like to write utilities that split a header and use them as map keys. Spaces in the header fields thwarts that. I'd suggest using a single letter for the header option (maybe v(erbose)) to be inline with the other commands. Otherwise it will thwart the "one of these days" feature of allowing option bundling. Multi-char options are better implemented as "--opt".
          Hide
          aw Allen Wittenauer added a comment -

          To me, count has always been in line with the Unix df, quota, iostat, zfs, etc storage commands where it's just default behavior to print column names. (du and ls are practically outliers!) The fact that it doesn't, I always marked up as naivety in how the Unix-equivalent commands worked. So while I can appreciate that it would be useful to have in 2.x, I just think long term it's the wrong behavior not to put the columns up by default. Casual users will still be annoyed/confused if we don't. Plus, as you said, it's a nice to have, not a necessity in 2.x.

          I definitely agree about the column names. Spaces = bad.

          Show
          aw Allen Wittenauer added a comment - To me, count has always been in line with the Unix df, quota, iostat, zfs, etc storage commands where it's just default behavior to print column names. (du and ls are practically outliers!) The fact that it doesn't, I always marked up as naivety in how the Unix-equivalent commands worked. So while I can appreciate that it would be useful to have in 2.x, I just think long term it's the wrong behavior not to put the columns up by default. Casual users will still be annoyed/confused if we don't. Plus, as you said, it's a nice to have, not a necessity in 2.x. I definitely agree about the column names. Spaces = bad.
          Hide
          daryn Daryn Sharp added a comment -

          I agree, and I'm perfectly fine with headers being default on trunk. I just don't want an incompatibility in 2.x that might be disruptive to deployment,yet I want the option because it's a pain to remember which field is which.

          Show
          daryn Daryn Sharp added a comment - I agree, and I'm perfectly fine with headers being default on trunk. I just don't want an incompatibility in 2.x that might be disruptive to deployment,yet I want the option because it's a pain to remember which field is which.
          Hide
          jonallen Jonathan Allen added a comment -

          Patch updated to work with latest trunk, I still need to tidy some things up though.

          Show
          jonallen Jonathan Allen added a comment - Patch updated to work with latest trunk, I still need to tidy some things up though.
          Hide
          jonallen Jonathan Allen added a comment -

          Patch updated with better field names in header.

          Show
          jonallen Jonathan Allen added a comment - Patch updated with better field names in header.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12662379/HADOOP-7713.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.ha.TestActiveStandbyElector

          The following test timeouts occurred in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.TestHDFSServerPorts
          org.apache.hadoop.hdfs.server.datanode.TestFsDatasetCache
          org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode
          org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
          org.apache.hadoop.hdfs.server.namenode.ha.TestHAMetrics
          org.apache.hadoop.hdfs.server.namenode.ha.TestHAStateTransitions
          org.apache.hadoop.hdfs.server.namenode.ha.TestDelegationTokensWithHA
          org.apache.hadoop.hdfs.server.namenode.TestValidateConfigurationSettings

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4493//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4493//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12662379/HADOOP-7713.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.ha.TestActiveStandbyElector The following test timeouts occurred in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestHDFSServerPorts org.apache.hadoop.hdfs.server.datanode.TestFsDatasetCache org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints org.apache.hadoop.hdfs.server.namenode.ha.TestHAMetrics org.apache.hadoop.hdfs.server.namenode.ha.TestHAStateTransitions org.apache.hadoop.hdfs.server.namenode.ha.TestDelegationTokensWithHA org.apache.hadoop.hdfs.server.namenode.TestValidateConfigurationSettings +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4493//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4493//console This message is automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          The problem with creating a flag to show something that will be the default is that a year from now we'll have wasted a perfectly good flag.

          Show
          aw Allen Wittenauer added a comment - The problem with creating a flag to show something that will be the default is that a year from now we'll have wasted a perfectly good flag.
          Hide
          daryn Daryn Sharp added a comment -

          I understand Allen's point but I'm not sure how many options we'll realistically add. Again, I'd selfishly like the option in 2.x w/o breaking monitoring scripts.

          Maybe I'm missing something obvious, but why is this needed? STRING_FORMAT.replace('d', 's')

          Show
          daryn Daryn Sharp added a comment - I understand Allen's point but I'm not sure how many options we'll realistically add. Again, I'd selfishly like the option in 2.x w/o breaking monitoring scripts. Maybe I'm missing something obvious, but why is this needed? STRING_FORMAT.replace('d', 's')
          Hide
          jonallen Jonathan Allen added a comment -

          The STRING_FORMAT.replace('d', 's') is left over from the original version of the code. The human readable changes done in HADOOP-8944 made it unnecessary and it should probably have been removed (I blame the reviewers).

          I'll tidy it up later in the week (probably not until the weekend).

          Show
          jonallen Jonathan Allen added a comment - The STRING_FORMAT.replace('d', 's') is left over from the original version of the code. The human readable changes done in HADOOP-8944 made it unnecessary and it should probably have been removed (I blame the reviewers). I'll tidy it up later in the week (probably not until the weekend).
          Hide
          jonallen Jonathan Allen added a comment -

          Removed use of STRING_FORMAT.replace.

          My thoughts on the default align with Daryn's, it would be nice to get this into the v2 branch (I can never remember what fields are returned by count and always have to have the help page open in another window).

          Show
          jonallen Jonathan Allen added a comment - Removed use of STRING_FORMAT.replace. My thoughts on the default align with Daryn's, it would be nice to get this into the v2 branch (I can never remember what fields are returned by count and always have to have the help page open in another window).
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12668656/HADOOP-7713.patch
          against trunk revision 14e2639.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract
          org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4715//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4715//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12668656/HADOOP-7713.patch against trunk revision 14e2639. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4715//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4715//console This message is automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          Sorry, but I'm pretty much against this going into branch-2 w/the default off.

          Show
          aw Allen Wittenauer added a comment - Sorry, but I'm pretty much against this going into branch-2 w/the default off.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12668656/HADOOP-7713.patch
          against trunk revision 7574df1.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5481//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12668656/HADOOP-7713.patch against trunk revision 7574df1. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5481//console This message is automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          Same as the last patch, just with doc fixes.

          Show
          aw Allen Wittenauer added a comment - Same as the last patch, just with doc fixes.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12696649/HADOOP-7713-11.patch
          against trunk revision 9112f09.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5597//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5597//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12696649/HADOOP-7713-11.patch against trunk revision 9112f09. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5597//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5597//console This message is automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          I've committed this to trunk.

          Thanks!

          Show
          aw Allen Wittenauer added a comment - I've committed this to trunk. Thanks!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7020 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7020/)
          HADOOP-7713. dfs -count -q should label output column (Jonathan Allen via aw) (aw: rev fb06c0083799fa5ca514447ba6b63ce564272805)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestCount.java
          • hadoop-common-project/hadoop-common/src/site/apt/FileSystemShell.apt.vm
          • hadoop-common-project/hadoop-common/src/test/resources/testConf.xml
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestContentSummary.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Count.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ContentSummary.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7020 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7020/ ) HADOOP-7713 . dfs -count -q should label output column (Jonathan Allen via aw) (aw: rev fb06c0083799fa5ca514447ba6b63ce564272805) hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestCount.java hadoop-common-project/hadoop-common/src/site/apt/FileSystemShell.apt.vm hadoop-common-project/hadoop-common/src/test/resources/testConf.xml hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestContentSummary.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Count.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ContentSummary.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #96 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/96/)
          HADOOP-7713. dfs -count -q should label output column (Jonathan Allen via aw) (aw: rev fb06c0083799fa5ca514447ba6b63ce564272805)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestCount.java
          • hadoop-common-project/hadoop-common/src/site/apt/FileSystemShell.apt.vm
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ContentSummary.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestContentSummary.java
          • hadoop-common-project/hadoop-common/src/test/resources/testConf.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Count.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #96 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/96/ ) HADOOP-7713 . dfs -count -q should label output column (Jonathan Allen via aw) (aw: rev fb06c0083799fa5ca514447ba6b63ce564272805) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestCount.java hadoop-common-project/hadoop-common/src/site/apt/FileSystemShell.apt.vm hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ContentSummary.java hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestContentSummary.java hadoop-common-project/hadoop-common/src/test/resources/testConf.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Count.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #830 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/830/)
          HADOOP-7713. dfs -count -q should label output column (Jonathan Allen via aw) (aw: rev fb06c0083799fa5ca514447ba6b63ce564272805)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestContentSummary.java
          • hadoop-common-project/hadoop-common/src/test/resources/testConf.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ContentSummary.java
          • hadoop-common-project/hadoop-common/src/site/apt/FileSystemShell.apt.vm
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestCount.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Count.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #830 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/830/ ) HADOOP-7713 . dfs -count -q should label output column (Jonathan Allen via aw) (aw: rev fb06c0083799fa5ca514447ba6b63ce564272805) hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestContentSummary.java hadoop-common-project/hadoop-common/src/test/resources/testConf.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ContentSummary.java hadoop-common-project/hadoop-common/src/site/apt/FileSystemShell.apt.vm hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestCount.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Count.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #93 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/93/)
          HADOOP-7713. dfs -count -q should label output column (Jonathan Allen via aw) (aw: rev fb06c0083799fa5ca514447ba6b63ce564272805)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestCount.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ContentSummary.java
          • hadoop-common-project/hadoop-common/src/test/resources/testConf.xml
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestContentSummary.java
          • hadoop-common-project/hadoop-common/src/site/apt/FileSystemShell.apt.vm
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Count.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #93 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/93/ ) HADOOP-7713 . dfs -count -q should label output column (Jonathan Allen via aw) (aw: rev fb06c0083799fa5ca514447ba6b63ce564272805) hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestCount.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ContentSummary.java hadoop-common-project/hadoop-common/src/test/resources/testConf.xml hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestContentSummary.java hadoop-common-project/hadoop-common/src/site/apt/FileSystemShell.apt.vm hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Count.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #2028 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2028/)
          HADOOP-7713. dfs -count -q should label output column (Jonathan Allen via aw) (aw: rev fb06c0083799fa5ca514447ba6b63ce564272805)

          • hadoop-common-project/hadoop-common/src/test/resources/testConf.xml
          • hadoop-common-project/hadoop-common/src/site/apt/FileSystemShell.apt.vm
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestContentSummary.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Count.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestCount.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ContentSummary.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2028 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2028/ ) HADOOP-7713 . dfs -count -q should label output column (Jonathan Allen via aw) (aw: rev fb06c0083799fa5ca514447ba6b63ce564272805) hadoop-common-project/hadoop-common/src/test/resources/testConf.xml hadoop-common-project/hadoop-common/src/site/apt/FileSystemShell.apt.vm hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestContentSummary.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Count.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestCount.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ContentSummary.java hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #97 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/97/)
          HADOOP-7713. dfs -count -q should label output column (Jonathan Allen via aw) (aw: rev fb06c0083799fa5ca514447ba6b63ce564272805)

          • hadoop-common-project/hadoop-common/src/test/resources/testConf.xml
          • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          • hadoop-common-project/hadoop-common/src/site/apt/FileSystemShell.apt.vm
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Count.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestCount.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestContentSummary.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ContentSummary.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #97 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/97/ ) HADOOP-7713 . dfs -count -q should label output column (Jonathan Allen via aw) (aw: rev fb06c0083799fa5ca514447ba6b63ce564272805) hadoop-common-project/hadoop-common/src/test/resources/testConf.xml hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml hadoop-common-project/hadoop-common/src/site/apt/FileSystemShell.apt.vm hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Count.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestCount.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestContentSummary.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ContentSummary.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2047 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2047/)
          HADOOP-7713. dfs -count -q should label output column (Jonathan Allen via aw) (aw: rev fb06c0083799fa5ca514447ba6b63ce564272805)

          • hadoop-common-project/hadoop-common/src/test/resources/testConf.xml
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestContentSummary.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/site/apt/FileSystemShell.apt.vm
          • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestCount.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Count.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ContentSummary.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2047 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2047/ ) HADOOP-7713 . dfs -count -q should label output column (Jonathan Allen via aw) (aw: rev fb06c0083799fa5ca514447ba6b63ce564272805) hadoop-common-project/hadoop-common/src/test/resources/testConf.xml hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestContentSummary.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/site/apt/FileSystemShell.apt.vm hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestCount.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Count.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ContentSummary.java
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Cherry-picked to branch-2.

          Show
          arpitagarwal Arpit Agarwal added a comment - Cherry-picked to branch-2.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7580 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7580/)
          HADOOP-7713. Update CHANGES.txt (arp: rev b9b832a0d883c0749c0e4edeb0e795c88bda9a1c)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7580 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7580/ ) HADOOP-7713 . Update CHANGES.txt (arp: rev b9b832a0d883c0749c0e4edeb0e795c88bda9a1c) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #163 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/163/)
          HADOOP-7713. Update CHANGES.txt (arp: rev b9b832a0d883c0749c0e4edeb0e795c88bda9a1c)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #163 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/163/ ) HADOOP-7713 . Update CHANGES.txt (arp: rev b9b832a0d883c0749c0e4edeb0e795c88bda9a1c) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2095 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2095/)
          HADOOP-7713. Update CHANGES.txt (arp: rev b9b832a0d883c0749c0e4edeb0e795c88bda9a1c)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2095 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2095/ ) HADOOP-7713 . Update CHANGES.txt (arp: rev b9b832a0d883c0749c0e4edeb0e795c88bda9a1c) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #897 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/897/)
          HADOOP-7713. Update CHANGES.txt (arp: rev b9b832a0d883c0749c0e4edeb0e795c88bda9a1c)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #897 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/897/ ) HADOOP-7713 . Update CHANGES.txt (arp: rev b9b832a0d883c0749c0e4edeb0e795c88bda9a1c) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #154 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/154/)
          HADOOP-7713. Update CHANGES.txt (arp: rev b9b832a0d883c0749c0e4edeb0e795c88bda9a1c)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #154 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/154/ ) HADOOP-7713 . Update CHANGES.txt (arp: rev b9b832a0d883c0749c0e4edeb0e795c88bda9a1c) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #164 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/164/)
          HADOOP-7713. Update CHANGES.txt (arp: rev b9b832a0d883c0749c0e4edeb0e795c88bda9a1c)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #164 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/164/ ) HADOOP-7713 . Update CHANGES.txt (arp: rev b9b832a0d883c0749c0e4edeb0e795c88bda9a1c) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2113 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2113/)
          HADOOP-7713. Update CHANGES.txt (arp: rev b9b832a0d883c0749c0e4edeb0e795c88bda9a1c)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2113 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2113/ ) HADOOP-7713 . Update CHANGES.txt (arp: rev b9b832a0d883c0749c0e4edeb0e795c88bda9a1c) hadoop-common-project/hadoop-common/CHANGES.txt

            People

            • Assignee:
              jonallen Jonathan Allen
              Reporter:
              nidaley Nigel Daley
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development