Hadoop Common
  1. Hadoop Common
  2. HADOOP-7703

WebAppContext should also be stopped and cleared

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.24.0
    • Fix Version/s: 2.0.2-alpha
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Improved excpetion handling of shutting down web server. (Devaraj K via Eric Yang)

      Description

      1. If listener stop method throws any exception then the webserver stop method will not be called

      public void stop() throws Exception {
          listener.close();
          webServer.stop();
      }
      

      2. also, WebAppContext stores all the context attributes, which does not get cleared if only webServer is stopped.
      so following calls are necessary to ensure clean and complete stop.

      webAppContext.clearAttributes();
      webAppContext.stop();
      

      3. Also the WebAppContext display name can be the name passed to HttpServer instance.

      webAppContext.setDisplayName(name);
      

      instead of

      webAppContext.setDisplayName("WepAppsContext");
      

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12497150/MAPREDUCE-3128.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/910//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12497150/MAPREDUCE-3128.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/910//console This message is automatically generated.
        Hide
        Devaraj K added a comment -

        I have moved it to hadoop common project and attached the same patch. Please review this.

        Show
        Devaraj K added a comment - I have moved it to hadoop common project and attached the same patch. Please review this.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12497166/HADOOP-7703.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/249//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/249//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12497166/HADOOP-7703.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/249//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/249//console This message is automatically generated.
        Hide
        Eric Yang added a comment -

        I just committed this to trunk. Thanks Devaraj K.

        Show
        Eric Yang added a comment - I just committed this to trunk. Thanks Devaraj K.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1022 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1022/)
        HADOOP-7703. Improved excpetion handling of shutting down web server.
        (Devaraj K via Eric Yang)

        eyang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1179286
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServerLifecycle.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1022 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1022/ ) HADOOP-7703 . Improved excpetion handling of shutting down web server. (Devaraj K via Eric Yang) eyang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1179286 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServerLifecycle.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1100 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1100/)
        HADOOP-7703. Improved excpetion handling of shutting down web server.
        (Devaraj K via Eric Yang)

        eyang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1179286
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServerLifecycle.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1100 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1100/ ) HADOOP-7703 . Improved excpetion handling of shutting down web server. (Devaraj K via Eric Yang) eyang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1179286 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServerLifecycle.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1038 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1038/)
        HADOOP-7703. Improved excpetion handling of shutting down web server.
        (Devaraj K via Eric Yang)

        eyang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1179286
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServerLifecycle.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1038 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1038/ ) HADOOP-7703 . Improved excpetion handling of shutting down web server. (Devaraj K via Eric Yang) eyang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1179286 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServerLifecycle.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #822 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/822/)
        HADOOP-7703. Improved excpetion handling of shutting down web server.
        (Devaraj K via Eric Yang)

        eyang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1179286
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServerLifecycle.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #822 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/822/ ) HADOOP-7703 . Improved excpetion handling of shutting down web server. (Devaraj K via Eric Yang) eyang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1179286 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServerLifecycle.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #852 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/852/)
        HADOOP-7703. Improved excpetion handling of shutting down web server.
        (Devaraj K via Eric Yang)

        eyang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1179286
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServerLifecycle.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #852 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/852/ ) HADOOP-7703 . Improved excpetion handling of shutting down web server. (Devaraj K via Eric Yang) eyang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1179286 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServerLifecycle.java
        Hide
        Alejandro Abdelnur added a comment -

        Any reason why this patch never made it to branch-2?

        Show
        Alejandro Abdelnur added a comment - Any reason why this patch never made it to branch-2?
        Hide
        Alejandro Abdelnur added a comment -

        Committed to branch-2

        Show
        Alejandro Abdelnur added a comment - Committed to branch-2

          People

          • Assignee:
            Devaraj K
            Reporter:
            Devaraj K
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development