Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.20.205.0
    • Fix Version/s: 1.2.0
    • Component/s: build
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed
    • Release Note:
      The jsvc build target is now supported for Mac OSX and other platforms as well.

      Description

      Recent changes to the build.xml determine with jsvc file to download based on the os.arch. It maps various arch values to i386 or x86_64. However, it notably doesn't consider x86_64 to be x86_64. The result is this the download fails because os-arch doesn't expand.

      build.xml:2626: Can't get http://archive.apache.org/dist/commons/daemon/binaries/1.0.2/linux/commons-daemon-1.0.2-bin-linux-${os-arch}.tar.gz
      

      This breaks test-patch.

      1. HADOOP-7968.patch
        0.9 kB
        Daryn Sharp
      2. HADOOP-7698-1.patch
        1 kB
        Daryn Sharp

        Issue Links

          Activity

          Hide
          Daryn Sharp added a comment -

          Add a check for x86_64.
          Add a fail if arch isn't set instead of trying to download a file with an unexpanded property in it.

          Show
          Daryn Sharp added a comment - Add a check for x86_64. Add a fail if arch isn't set instead of trying to download a file with an unexpanded property in it.
          Hide
          Eric Yang added a comment -

          -1, for os.arch set to x86_64. This means the compilation is done on MacOSX. Build on Mac should not include linux jsvc binary because the native library and jsvc would not work. Therefore, this was excluded intentionally.

          Show
          Eric Yang added a comment - -1, for os.arch set to x86_64. This means the compilation is done on MacOSX. Build on Mac should not include linux jsvc binary because the native library and jsvc would not work. Therefore, this was excluded intentionally.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12497058/HADOOP-7968.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/246//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12497058/HADOOP-7968.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/246//console This message is automatically generated.
          Hide
          Daryn Sharp added a comment -

          Eric, based on our conversation yesterday, is this a more reasonable change?

          Show
          Daryn Sharp added a comment - Eric, based on our conversation yesterday, is this a more reasonable change?
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12497181/HADOOP-7698-1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/250//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12497181/HADOOP-7698-1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/250//console This message is automatically generated.
          Hide
          Harsh J added a comment -

          Since we no longer carry jsvc in our build, this is not a problem anymore. Please reopen if am incorrect. Thanks for the patch though (back then) Daryn!

          Show
          Harsh J added a comment - Since we no longer carry jsvc in our build, this is not a problem anymore. Please reopen if am incorrect. Thanks for the patch though (back then) Daryn!
          Hide
          Harsh J added a comment -

          Dang, I forgot to see this was 1.x related. Reopened to check 1.x now.

          Show
          Harsh J added a comment - Dang, I forgot to see this was 1.x related. Reopened to check 1.x now.
          Hide
          Harsh J added a comment -

          Daryn's patch seems to work pretty well.

          OSX:

          ➜  hadoop-1 git:(branch-1) ✗ gst          
          # On branch branch-1
          # Changes not staged for commit:
          #   (use "git add <file>..." to update what will be committed)
          #   (use "git checkout -- <file>..." to discard changes in working directory)
          #
          #	modified:   build.xml
          #
          no changes added to commit (use "git add" and/or "git commit -a")
          ➜  hadoop-1 git:(branch-1) ✗ ant jsvc     
          Buildfile: /Users/harshchouraria/Work/code/apache/hadoop-1/build.xml
          
          jsvc:
                [get] Getting: http://archive.apache.org/dist/commons/daemon/binaries/1.0.2/darwin/commons-daemon-1.0.2-bin-darwin-universal.tar.gz
                [get] To: /Users/harshchouraria/Work/code/apache/hadoop-1/build/jsvc.x86_64/jsvc.x86_64.tar.gz
              [untar] Expanding: /Users/harshchouraria/Work/code/apache/hadoop-1/build/jsvc.x86_64/jsvc.x86_64.tar.gz into /Users/harshchouraria/Work/code/apache/hadoop-1/build/jsvc.x86_64
          
          BUILD SUCCESSFUL
          Total time: 4 seconds
          

          Linux x64:

          ➜  hadoop git:(branch-1) ✗ gst
          # On branch branch-1
          # Changed but not updated:
          #   (use "git add <file>..." to update what will be committed)
          #   (use "git checkout -- <file>..." to discard changes in working directory)
          #
          #	modified:   build.xml
          #
          no changes added to commit (use "git add" and/or "git commit -a")
          ➜  hadoop git:(branch-1) ✗ ant jsvc
          Buildfile: build.xml
          
          jsvc:
                [get] Getting: http://archive.apache.org/dist/commons/daemon/binaries/1.0.2/linux/commons-daemon-1.0.2-bin-linux-x86_64.tar.gz
                [get] To: /home/harsh/hadoop/build/jsvc.amd64/jsvc.amd64.tar.gz
              [untar] Expanding: /home/harsh/hadoop/build/jsvc.amd64/jsvc.amd64.tar.gz into /home/harsh/hadoop/build/jsvc.amd64
          
          BUILD SUCCESSFUL
          Total time: 0 seconds
          

          +1 hence, committing.

          Show
          Harsh J added a comment - Daryn's patch seems to work pretty well. OSX: ➜ hadoop-1 git:(branch-1) ✗ gst # On branch branch-1 # Changes not staged for commit: # (use "git add <file>..." to update what will be committed) # (use "git checkout -- <file>..." to discard changes in working directory) # # modified: build.xml # no changes added to commit (use "git add" and/or "git commit -a" ) ➜ hadoop-1 git:(branch-1) ✗ ant jsvc Buildfile: /Users/harshchouraria/Work/code/apache/hadoop-1/build.xml jsvc: [get] Getting: http: //archive.apache.org/dist/commons/daemon/binaries/1.0.2/darwin/commons-daemon-1.0.2-bin-darwin-universal.tar.gz [get] To: /Users/harshchouraria/Work/code/apache/hadoop-1/build/jsvc.x86_64/jsvc.x86_64.tar.gz [untar] Expanding: /Users/harshchouraria/Work/code/apache/hadoop-1/build/jsvc.x86_64/jsvc.x86_64.tar.gz into /Users/harshchouraria/Work/code/apache/hadoop-1/build/jsvc.x86_64 BUILD SUCCESSFUL Total time: 4 seconds Linux x64: ➜ hadoop git:(branch-1) ✗ gst # On branch branch-1 # Changed but not updated: # (use "git add <file>..." to update what will be committed) # (use "git checkout -- <file>..." to discard changes in working directory) # # modified: build.xml # no changes added to commit (use "git add" and/or "git commit -a" ) ➜ hadoop git:(branch-1) ✗ ant jsvc Buildfile: build.xml jsvc: [get] Getting: http: //archive.apache.org/dist/commons/daemon/binaries/1.0.2/linux/commons-daemon-1.0.2-bin-linux-x86_64.tar.gz [get] To: /home/harsh/hadoop/build/jsvc.amd64/jsvc.amd64.tar.gz [untar] Expanding: /home/harsh/hadoop/build/jsvc.amd64/jsvc.amd64.tar.gz into /home/harsh/hadoop/build/jsvc.amd64 BUILD SUCCESSFUL Total time: 0 seconds +1 hence, committing.
          Hide
          Harsh J added a comment -

          Committed to branch-1, thanks Daryn!

          Show
          Harsh J added a comment - Committed to branch-1, thanks Daryn!
          Hide
          Matt Foley added a comment -

          Closed upon release of Hadoop 1.2.0.

          Show
          Matt Foley added a comment - Closed upon release of Hadoop 1.2.0.

            People

            • Assignee:
              Daryn Sharp
              Reporter:
              Daryn Sharp
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development