Hadoop Common
  1. Hadoop Common
  2. HADOOP-7669

Fix newly introduced release audit warning.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.24.0
    • Fix Version/s: 3.0.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      It looks to me that HADOOP-7633 introduced one release audit warning.
      we need to include Apache header in that hadoop-common-project\hadoop-common\src\main\packages\templates\conf\log4j.properties.

      1. HADOOP-7669.20Security.patch
        1 kB
        Uma Maheswara Rao G
      2. HADOOP-7669.trunk.patch
        1 kB
        Uma Maheswara Rao G

        Issue Links

          Activity

          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12496087/HADOOP-7669.trunk.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/221//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/221//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12496087/HADOOP-7669.trunk.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/221//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/221//console This message is automatically generated.
          Hide
          Ravi Prakash added a comment -

          Hi Uma! I was getting 10 license missing errors I've uploaded a patch for that on https://issues.apache.org/jira/browse/HADOOP-7671 (for all the files in the conf directory)

          Show
          Ravi Prakash added a comment - Hi Uma! I was getting 10 license missing errors I've uploaded a patch for that on https://issues.apache.org/jira/browse/HADOOP-7671 (for all the files in the conf directory)
          Hide
          Uma Maheswara Rao G added a comment -

          Hi Ravi,
          This issue is for trunk. All other files are having the apache header in trunk.
          You are looking at 23 branch. In 23 branch, apache header missed for many files.

          Thanks,
          Uma

          Show
          Uma Maheswara Rao G added a comment - Hi Ravi, This issue is for trunk. All other files are having the apache header in trunk. You are looking at 23 branch. In 23 branch, apache header missed for many files. Thanks, Uma
          Hide
          Steve Loughran added a comment -

          +1 looks good, committing

          Show
          Steve Loughran added a comment - +1 looks good, committing
          Hide
          Steve Loughran added a comment -

          No test as apache:rat-check is the test itself

          Show
          Steve Loughran added a comment - No test as apache:rat-check is the test itself
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1020 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1020/)
          HADOOP-7669 Fix newly introduced release audit warning.

          stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1174653
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/packages/templates/conf/log4j.properties
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1020 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1020/ ) HADOOP-7669 Fix newly introduced release audit warning. stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1174653 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/packages/templates/conf/log4j.properties
          Hide
          Uma Maheswara Rao G added a comment -

          Hi Steve,

          Thanks a lot for taking a look!.

          We should committ this in 20Security as well. Because HADOOP-7633 got committed in that branch as well. ( Patch available)

          Thanks,
          Uma

          Show
          Uma Maheswara Rao G added a comment - Hi Steve, Thanks a lot for taking a look!. We should committ this in 20Security as well. Because HADOOP-7633 got committed in that branch as well. ( Patch available) Thanks, Uma
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #942 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/942/)
          HADOOP-7669 Fix newly introduced release audit warning.

          stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1174653
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/packages/templates/conf/log4j.properties
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #942 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/942/ ) HADOOP-7669 Fix newly introduced release audit warning. stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1174653 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/packages/templates/conf/log4j.properties
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #960 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/960/)
          HADOOP-7669 Fix newly introduced release audit warning.

          stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1174653
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/packages/templates/conf/log4j.properties
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #960 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/960/ ) HADOOP-7669 Fix newly introduced release audit warning. stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1174653 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/packages/templates/conf/log4j.properties
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #809 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/809/)
          HADOOP-7669 Fix newly introduced release audit warning.

          stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1174653
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/packages/templates/conf/log4j.properties
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #809 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/809/ ) HADOOP-7669 Fix newly introduced release audit warning. stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1174653 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/packages/templates/conf/log4j.properties
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #839 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/839/)
          HADOOP-7669 Fix newly introduced release audit warning.

          stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1174653
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/packages/templates/conf/log4j.properties
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #839 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/839/ ) HADOOP-7669 Fix newly introduced release audit warning. stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1174653 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/packages/templates/conf/log4j.properties

            People

            • Assignee:
              Uma Maheswara Rao G
              Reporter:
              Uma Maheswara Rao G
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development