Hadoop Common
  1. Hadoop Common
  2. HADOOP-7608

SnappyCodec check for Hadoop native lib is wrong

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0, 0.24.0
    • Fix Version/s: 0.23.0, 0.24.0
    • Component/s: io
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently SnappyCodec is doing:

        public static boolean isNativeSnappyLoaded(Configuration conf) {
          return LoadSnappy.isLoaded() && conf.getBoolean(
              CommonConfigurationKeys.IO_NATIVE_LIB_AVAILABLE_KEY,
              CommonConfigurationKeys.IO_NATIVE_LIB_AVAILABLE_DEFAULT);
        }
      

      But the conf check is wrong as it defaults to true. Instead it should use NativeCodeLoader.isNativeCodeLoaded()

      1. HADOOP-7608.patch
        4 kB
        Alejandro Abdelnur

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #9 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/9/)
        HADOOP-7608. SnappyCodec check for Hadoop native lib is wrong. Contributed by Alejandro Abdelnur.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171717
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/SnappyCodec.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #9 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/9/ ) HADOOP-7608 . SnappyCodec check for Hadoop native lib is wrong. Contributed by Alejandro Abdelnur. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171717 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/SnappyCodec.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #833 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/833/)
        HADOOP-7608. SnappyCodec check for Hadoop native lib is wrong. Contributed by Alejandro Abdelnur.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171719
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/SnappyCodec.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #833 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/833/ ) HADOOP-7608 . SnappyCodec check for Hadoop native lib is wrong. Contributed by Alejandro Abdelnur. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171719 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/SnappyCodec.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #803 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/803/)
        HADOOP-7608. SnappyCodec check for Hadoop native lib is wrong. Contributed by Alejandro Abdelnur.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171719
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/SnappyCodec.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #803 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/803/ ) HADOOP-7608 . SnappyCodec check for Hadoop native lib is wrong. Contributed by Alejandro Abdelnur. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171719 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/SnappyCodec.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #9 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/9/)
        HADOOP-7608. SnappyCodec check for Hadoop native lib is wrong. Contributed by Alejandro Abdelnur.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171717
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/SnappyCodec.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #9 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/9/ ) HADOOP-7608 . SnappyCodec check for Hadoop native lib is wrong. Contributed by Alejandro Abdelnur. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171717 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/SnappyCodec.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #916 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/916/)
        HADOOP-7608. SnappyCodec check for Hadoop native lib is wrong. Contributed by Alejandro Abdelnur.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171719
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/SnappyCodec.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #916 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/916/ ) HADOOP-7608 . SnappyCodec check for Hadoop native lib is wrong. Contributed by Alejandro Abdelnur. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171719 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/SnappyCodec.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #978 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/978/)
        HADOOP-7608. SnappyCodec check for Hadoop native lib is wrong. Contributed by Alejandro Abdelnur.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171719
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/SnappyCodec.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #978 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/978/ ) HADOOP-7608 . SnappyCodec check for Hadoop native lib is wrong. Contributed by Alejandro Abdelnur. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171719 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/SnappyCodec.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #901 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/901/)
        HADOOP-7608. SnappyCodec check for Hadoop native lib is wrong. Contributed by Alejandro Abdelnur.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171719
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/SnappyCodec.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #901 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/901/ ) HADOOP-7608 . SnappyCodec check for Hadoop native lib is wrong. Contributed by Alejandro Abdelnur. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171719 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/SnappyCodec.java
        Hide
        Todd Lipcon added a comment -

        Committed to 23 and trunk, thanks Alejandro

        Show
        Todd Lipcon added a comment - Committed to 23 and trunk, thanks Alejandro
        Hide
        Todd Lipcon added a comment -

        +1

        Show
        Todd Lipcon added a comment - +1
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12494817/HADOOP-7608.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/197//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/197//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12494817/HADOOP-7608.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/197//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/197//console This message is automatically generated.

          People

          • Assignee:
            Alejandro Abdelnur
            Reporter:
            Alejandro Abdelnur
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development